On Thursday 16 October 2008, Marco Martin wrote: > uhm, i think it's right at least how findInRectsCache work, because right > now it returns false only when we are sure the element does not exist, so > when is true and the rect not valid is still to be checked... > i know it's not intuitive, but don't know how to make it more intuitive, we
yeah, that is a bit unintuitive. findInRectsCache should return whether or not it was found in the cache, not whether or not it is invalid. returning a QRect() would probably be a better way to note that it's invalid. sth like: ret val rect meaning ===== === ======= false QRect() not in cache, should be looked up in the Svg true QRect() in cache, invalid element true QRect(...) in cache, valid element -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
