On Wednesday 15 October 2008, Marco Martin wrote: > On Wednesday 15 October 2008, Aaron J. Seigo wrote: > > On Wednesday 15 October 2008, Marco Martin wrote: > > > with a kconfigroup? would make sense? > > > > it's the easy answer, so i'd say: "let's go for it". > > > > we can benchmark it once it is in place and working. changing the cache > > implementation will be an easy task after we have it there in the first > > place. > > > > i'll commit my changes shortly here then, once i figure out the problem > > with the applet backgrounds > > still very rough and probably wrong in many points posting here because i'm > too tired right now to think, probably tomorrow will come up with a > slightly better version :) > > Cheers, > Marco Martin
it's a good start =) some (probably fatigue induced) issues like:
+ ? ? ? ? ? ?if (!found) {
+ ? ? ? ? ? ? ? ?return QRect();
+ ? ? ? ? ? ?} else if (rect.isValid()) {
+ ? ? ? ? ? ? ? ?return rect;
+ ? ? ? ? ? ?}
+
should probably be:
if (found && rect.isValid()) {
return rect
}
though even then ... it might not be worth checking if isValid() so non-
existent elements would also be covered.
but yeah, you're on the right track ... once this is in i'll do some more
measurements and see where we get =)
i'm also going to make the Image wallpaper plugin use a (separate) cache as
well i think so we don't have to re-process the wallpaper images everytime. i
also think i'm going to try to make the Image wallpaper plugin use fewer
threads when more than one is loaded....
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Software
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
