Pager keyboard shortcuts

2023-01-23 Thread Van Snyder
m. I added two desktops, from the pager menu obtained by right clicking in the pager in the panel. I can't switch to Desktop 5 or 6 using Alt-F5 or Alt-F6. I'd like to add those shortcuts. I remember finding a place to add shortcuts, but after searching the entire KDE settings applicatio

Re: Pager keyboard shortcuts

2023-01-18 Thread Méven
Hi van, > Is there a text file of settings for the pager that I can edit? No need, there is an UI for this. In systemsettings > Workspace > Shortcuts > KWin > "Switch to desktop". My system is in french and my plasma version is more recent (5.22.5) but I think it sho

Pager keyboard shortcuts

2023-01-18 Thread Van Snyder
m. I added two desktops, from the pager menu obtained by right clicking in the pager in the panel. I can't switch to Desktop 5 or 6 using Alt-F5 or Alt-F6. I'd like to add those shortcuts. I remember finding a place to add shortcuts, but after searching the entire KDE settings applicatio

Re: Issue with Pager 4.0

2022-04-17 Thread Alexander Potashev
Hi Pratham, To make sure your report doesn't get lost, please submit it at bugs.kde.org (select product "plasmashell"). On Mon, Mar 21, 2022 at 1:47 PM Pratham Singh CE wrote: > > Desktop shortcuts not working on plasma pager. > > Tried Shortcuts: > meta + alt +

Issue with Pager 4.0

2022-03-21 Thread Pratham Singh CE
Desktop shortcuts not working on plasma pager. Tried Shortcuts: meta + alt + tab meta + alt + down arrow control + alt + down arrow control + shift + W Environment: Plasma 5.24.3 Manjaro Linux

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

2020-02-11 Thread Will Stephenson
wstephenson abandoned this revision. wstephenson added a comment. @broulik Thanks! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27319 To: wstephenson, hein, davidedmundson, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jral

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

2020-02-11 Thread Kai Uwe Broulik
broulik added a comment. In the "Add Action..." combobox above the comment field at the end you choose say "Abandon revision" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27319 To: wstephenson, hein, davidedmundson, #plasma Cc: broulik, plasma-devel, Orage

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

2020-02-11 Thread Will Stephenson
wstephenson added a comment. Changes integrated into https://phabricator.kde.org/D27322 - how do I withdraw/close a posted diff in phabricator? :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27319 To: wstephenson, hein, davidedmundson, #plasma Cc: plasma-

D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

2020-02-11 Thread Will Stephenson
Activity Pager to add the window to an Activity was broken, because the test to see if the drop location is a running activity still treated the itemId as an integer indexing into an array of running activity indices, rather than an id string that could be a member of the list of running

D26485: [Pager] Fix switching pages on

2020-01-07 Thread Kai Uwe Broulik
broulik closed this revision. broulik added a comment. f5d1675a0dc1a1a0098eb5b1c727b5fe197e9930 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26485 To: broulik, #plasma, hein, mart

D26485: [Pager] Fix switching pages on

2020-01-07 Thread Kai Uwe Broulik
`currentPage` (which is an `int`) and `changePage` taking an `int`. BUG: 415423 FIXED-IN: 5.17.5 TEST PLAN - Dragged a file onto pager, waited for desktop switch, plasma no longer crashed - Activity pager also works fine the same way REPOSITORY R119 Plasma Desktop REVISION DETAIL https

D24238: Port the pager applet away from QtWidgets

2019-12-14 Thread David Faure
dfaure added a comment. Ah, right. Thanks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: davidedmundson, hein, apol, dfaure Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, al

D24238: Port the pager applet away from QtWidgets

2019-12-14 Thread David Edmundson
davidedmundson closed this revision. davidedmundson added a comment. @dfaure You can commandeer and then click close REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: davidedmundson, hein, apol, dfaure Cc: ognarb, broulik, plasma-devel, LeGast00n, The-

D24238: Port the pager applet away from QtWidgets

2019-12-13 Thread David Faure
dfaure added a comment. Fix pushed https://commits.kde.org/plasma-desktop/2b5e86323f180f0c51ef9af898a69a522bc379ad after the bug reporter confirmed it fixes the bug. Reopening this after it was committed is a bit weird. I can't close it, please do. REPOSITORY R119 Plasma Desktop REV

D24238: Port the pager applet away from QtWidgets

2019-12-13 Thread David Faure
dfaure added a comment. Further research leads to this possible patch http://www.davidfaure.fr/2019/windowmodel.cpp.diff REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: dfaure, hein, apol Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-De

D25933: [applets/pager] Calculate full screen geometry

2019-12-12 Thread David Edmundson
. This effectively matches the internal implementation used there. BUG: (fixme) TEST PLAN Only tested with one monitor. Pager still looks normal REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D25933 AFFECTED FILES applets/pager/plugin

D24238: Port the pager applet away from QtWidgets

2019-12-11 Thread David Faure
dfaure added a comment. Oh I see. Is there a non-deprecated method to get the overall geometry of all screens combined, or do we need to iterate over the list of screens? Surprising that this doesn't seem to be anywhere in the API !? REPOSITORY R119 Plasma Desktop REVISION DETA

D24238: Port the pager applet away from QtWidgets

2019-12-11 Thread Carl Schwan
ognarb added a comment. This patch maybe created this bug: https://bugs.kde.org/show_bug.cgi?id=414849 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24238 To: dfaure, hein, apol Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbamp

D13175: List the Activity Pager also as an alternative to e.g. the Activity Bar

2019-12-11 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R114:d9109808cd16: List the Activity Pager also as an alternative to e.g. the Activity Bar (authored by hein, committed by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https

D13175: List the Activity Pager also as an alternative to e.g. the Activity Bar

2019-12-05 Thread Nathaniel Graham
ngraham added a comment. Can this land? REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D13175 To: hein, broulik, mart Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,

D24238: Port the pager applet away from QtWidgets

2019-11-25 Thread David Faure
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:674dd5f7e090: Port the pager applet away from QtWidgets (authored by dfaure). REPOSITORY R119 Plas

D24238: Port the pager applet away from QtWidgets

2019-09-26 Thread David Faure
dfaure added inline comments. INLINE COMMENTS > broulik wrote in windowmodel.cpp:81 > Isn't that the combined geometry of all screens, not just a single screen? Oh indeed. But then this was the wrong thing to use anyway. You don't want to center the window in relation to the combined geometry,

D24238: Port the pager applet away from QtWidgets

2019-09-26 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > windowmodel.cpp:81 > QRect windowGeo = TaskFilterProxyModel::data(index, role).toRect(); > -const QRect &desktopGeo = d->desktopWidget->geometry(); > Isn't that the combined geometry of all screens, not just a single screen? RE

D24238: Port the pager applet away from QtWidgets

2019-09-26 Thread David Faure
://phabricator.kde.org/D24238 AFFECTED FILES applets/pager/plugin/pagermodel.cpp applets/pager/plugin/windowmodel.cpp To: dfaure, hein, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts

D22588: [Pager] Don't link kdelibs4support

2019-07-21 Thread Shubham
shubham added a comment. I have put up a patch to remove duplicate occurrence of DBus here. https://phabricator.kde.org/D22619 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22588 To: broulik, #plasma, hein, davidedmundson Cc: pino, shubham, plasma-devel, L

D22588: [Pager] Don't link kdelibs4support

2019-07-20 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:e75f1e5039a3: [Pager] Don't link kdelibs4support (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22588?vs=62127&id=62147

D22588: [Pager] Don't link kdelibs4support

2019-07-20 Thread Pino Toscano
pino added inline comments. INLINE COMMENTS > shubham wrote in CMakeLists.txt:18 > Could you please remove this or the occurrence below at line 21? In a separate patch, not in this one. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22588 To: broulik, #plasma,

D22588: [Pager] Don't link kdelibs4support

2019-07-20 Thread Shubham
shubham added inline comments. INLINE COMMENTS > CMakeLists.txt:18 >Qt5::Core >Qt5::DBus >Qt5::Qml Could you please remove this or the occurrence below at line 21? REPOSITORY R119 Plasma Desktop REVISION DETAIL https:/

D22588: [Pager] Don't link kdelibs4support

2019-07-20 Thread Kai Uwe Broulik
ETAIL https://phabricator.kde.org/D22588 AFFECTED FILES applets/pager/CMakeLists.txt To: broulik, #plasma, hein Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20851: [Pager] Improve label legibility

2019-04-30 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:d09d4d52e161: [Pager] Improve label legibility (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20851?vs=57220&id=57258 REVI

D20851: [Pager] Improve label legibility

2019-04-29 Thread Nathaniel Graham
ngraham updated this revision to Diff 57220. ngraham added a comment. Revert unnecessary change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20851?vs=57219&id=57220 BRANCH improve-pager-label-legibility (branched from master) REVISION DE

D20851: [Pager] Improve label legibility

2019-04-29 Thread Nathaniel Graham
improve-pager-label-legibility (branched from master) REVISION DETAIL https://phabricator.kde.org/D20851 AFFECTED FILES applets/pager/package/contents/ui/main.qml To: ngraham, #vdg, #plasma Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, al

D20851: [Pager] Improve label legibility

2019-04-26 Thread Noah Davis
ndavis added a comment. In D20851#456931 , @ngraham wrote: > [...] In the first screenshot you can see that the number "1" is actually almost invisible. I'm open to suggestions for alternative ways to improve this. Yes, but this is becaus

D20851: [Pager] Improve label legibility

2019-04-26 Thread Filip Fila
filipf added a comment. An outline could work, but maybe not at 100% opacity. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20851 To: ngraham, #vdg, #plasma Cc: filipf, abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-m

D20851: [Pager] Improve label legibility

2019-04-26 Thread Andres Betts
abetts added a comment. In D20851#456936 , @ngraham wrote: > In D20851#456932 , @abetts wrote: > > > I agree with this too. Do you think it would be too weird of other methods are used? For example:

D20851: [Pager] Improve label legibility

2019-04-26 Thread Nathaniel Graham
ngraham added a comment. In D20851#456932 , @abetts wrote: > I agree with this too. Do you think it would be too weird of other methods are used? For example: > > - Use a more legible font that is independent from system font > - Use curren

D20851: [Pager] Improve label legibility

2019-04-26 Thread Andres Betts
abetts added a comment. In D20851#456931 , @ngraham wrote: > Well, I find it almost impossible to read the text with the status quo version when there are a bunch of window outlines. In the first screenshot you can see that the number "1" is act

D20851: [Pager] Improve label legibility

2019-04-26 Thread Nathaniel Graham
ngraham added a comment. Well, I find it almost impossible to read the text with the status quo version when there are a bunch of window outlines. In the first screenshot you can see that the number "1" is actually almost invisible. I'm open to suggestions for alternative ways to improve thi

D20851: [Pager] Improve label legibility

2019-04-26 Thread Andres Betts
abetts added a comment. In D20851#456903 , @ndavis wrote: > To me, the white text with the shadows doesn't really improve legibility and just looks "off". For some reason, shadow behind small text messes with my eyes and makes it harder to focus

D20851: [Pager] Improve label legibility

2019-04-26 Thread Noah Davis
ndavis added a comment. To me, the white text with the shadows doesn't really improve legibility and just looks "off" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20851 To: ngraham, #vdg, #plasma Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zr

D20851: [Pager] Improve label legibility

2019-04-26 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently, when displaying pager labels (either number or name), text legibility is often

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

2019-04-25 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b8d753f4f00f: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

2019-04-25 Thread Björn Feber
GB_2 accepted this revision as: VDG, GB_2. GB_2 added a comment. This revision is now accepted and ready to land. Perfect. REPOSITORY R119 Plasma Desktop BRANCH modernize-pager-settings-window (branched from master) REVISION DETAIL https://phabricator.kde.org/D20796 To: ngraham, #vdg

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

2019-04-24 Thread Nathaniel Graham
ANCH modernize-pager-settings-window (branched from master) REVISION DETAIL https://phabricator.kde.org/D20796 AFFECTED FILES applets/pager/package/contents/config/config.qml applets/pager/package/contents/ui/configGeneral.qml To: ngraham, #vdg, #plasma Cc: GB_2, plasma-devel, jraleigh, rag

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

2019-04-24 Thread Björn Feber
GB_2 added a comment. Looks good UI-wise. INLINE COMMENTS > configGeneral.qml:136 > +} > +QtControls.RadioButton { > +id: noTextRadio Default radio buttons should be at the top. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D20796 To: ngrah

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

2019-04-24 Thread Nathaniel Graham
ngraham updated this revision to Diff 56926. ngraham added a comment. Also correct category icon REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20796?vs=56925&id=56926 BRANCH modernize-pager-settings-window (branched from master) REVISION DE

D20796: [Pager] Port settings window to QQC2+Kirigami FormLayout and improve UI

2019-04-24 Thread Nathaniel Graham
pager TEST PLAN All features still work. Virtual Desktops: F6791456: Pager - Virtual Desktops.png <https://phabricator.kde.org/F6791456> Activities: F6791466: Pager - Activity.png <https://phabricator.kde.org/F6791466> #VDG <https://phabricator.kde.org/tag/vdg/>

D19751: [Pager] Shrink label font size dynamically

2019-03-14 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:de1c1c93c883: [Pager] Shrink label font size dynamically (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19751?vs=53862&id=5

D19751: [Pager] Shrink label font size dynamically

2019-03-14 Thread Kai Uwe Broulik
F6690755: Screenshot_20190314_100759.png <https://phabricator.kde.org/F6690755> After F6690754: Screenshot_20190314_100735.png <https://phabricator.kde.org/F6690754> Perhaps we need an option to horizontally scale the pager? REPOSITORY R119 Plasma Desktop R

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

2018-12-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c92b97fe9390: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13748?vs=38112&id=47753

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-11-16 Thread Eike Hein
hein added a comment. @ngraham Let's progress this, do you want @phuongn to change the patch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: hein, zzag, ngraham, abetts, davidedmundson, broulik, plasma-deve

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-10-22 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R119:a2b683a10802: Implement option to toggle page navigation wraps around for pager plasmoid (authored by phuongn, committed by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

2018-09-28 Thread Marco Martin
mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > pagermodel.cpp:444 > for (auto windowModel : d->windowModels) { > -windowModel->setVirtualDesktop(0); > +windowModel->setVirtualDesktop(); >

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-09-04 Thread Nathaniel Graham
ngraham added a comment. My sense is that it would be best to put this option alongside the existing one in the virtual desktops KCM. Navigation wraps around: [] When switching with keyboard shortcuts [] When switching with a scroll Or something like th

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-09-04 Thread Phuong Nguyen
phuongn added a comment. In D14988#320052 , @hein wrote: > And @phuongn, I'm guessing you set all of these options to disabling wrap-around, right? I wasn't the original author of the very first wrap-around option for KWin, which only wo

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-09-04 Thread Eike Hein
hein added a comment. And @phuongn, I'm guessing you set all of these options to disabling wrap-around, right? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: hein, zzag, ngraham, abetts, davidedmundson, br

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-09-04 Thread Eike Hein
hein added a comment. This patch is good, but I share Kai's concern that it's perhaps suboptimal we have two-three checkboxes now to control similar behavior in different places. Does the VDG have an opinion on that @ngraham? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabri

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Phuong Nguyen
ttps://phabricator.kde.org/D14988 AFFECTED FILES applets/pager/package/contents/config/main.xml applets/pager/package/contents/ui/configGeneral.qml applets/pager/package/contents/ui/main.qml To: phuongn, #plasma, #vdg, davidedmundson Cc: zzag, ngraham, abetts, davidedmundson, broulik, plasma-d

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > zzag wrote in main.qml:130 > I think it should be `Math.min`. Also, maybe `repeater.count - 1`. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: zzag, ngraham, abe

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Vlad Zagorodniy
zzag added inline comments. INLINE COMMENTS > main.qml:130 > +(pagerModel.currentPage + 1) % repeater.count : > +Math.max(pagerModel.currentPage + 1, repeater.count); > +pagerModel.changePage(nextPage); I think it should be `Math.min`. > m

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Andres Betts
abetts added a comment. In D14988#316672 , @ngraham wrote: > I think the terminology "wraps around" is fine. Seems pretty clear to me. Cool, let's go with that. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Nathaniel Graham
ngraham added a comment. I think the terminology "wraps around" is fine. Seems pretty clear to me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: ngraham, abetts, davidedmundson, broulik, plasma-devel, ragr

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Phuong Nguyen
Page navigation wraps around" because the pager can be used to control either Desktop or Activity, so I used "Page" instead of "Desktop" and keep the rest of the string similar to existing option from Virtual Desktops settings. Using other strings might confuse user of wha

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Andres Betts
abetts added a comment. In D14988#316633 <https://phabricator.kde.org/D14988#316633>, @phuongn wrote: > Hi, it's just the default desktop changing effect. Activated by scrolling with the cursor hovering on the pager. I haven't changed the effect, just added an op

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Phuong Nguyen
phuongn added a comment. Hi, it's just the default desktop changing effect. Activated by scrolling with the cursor hovering on the pager. I haven't changed the effect, just added an option to toggle page wrapping F6220920: simplescreenrecorder-2018-08-28_17.44.42.m

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Andres Betts
abetts added a comment. Could you please put a video or gif that shows the effect? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma, #vdg, davidedmundson Cc: abetts, davidedmundson, broulik, plasma-devel, ragreen, Pitel, ZrenBot, les

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Phuong Nguyen
0549 REVISION DETAIL https://phabricator.kde.org/D14988 AFFECTED FILES applets/pager/package/contents/config/main.xml applets/pager/package/contents/ui/configGeneral.qml applets/pager/package/contents/ui/main.qml To: phuongn, #plasma, #vdg Cc: davidedmundson, broulik, plasma-devel, ragreen, P

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread Phuong Nguyen
phuongn marked an inline comment as done. phuongn added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:130 > would > > var nextPage = plasmoid.configuration.wrapPage? > (pagerModel.currentPage + 1) % repeater.count : > Math.max(page

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-28 Thread David Edmundson
davidedmundson added inline comments. INLINE COMMENTS > main.qml:130 > +(pagerModel.currentPage + 1) % repeater.count : > pagerModel.currentPage + 1; > +if (nextPage >= repeater.count) nextPage = repeater.count - > 1; > +pagerModel.changePage(

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-22 Thread Kai Uwe Broulik
broulik added a comment. You would need to read `kwinrc` manually, I suppose. I don't use virtual desktops, so I cannot comment, but I don't think three separate options is worthwhile. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #pla

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-22 Thread Phuong Nguyen
phuongn added a comment. I couldn't find an easy way to access KWindowSystem config from there. On the other hand, I personally prefer wrapping when using keyboard shortcut and no wrapping when using mouse or touchpad gesture. I figured some people might need the same flexibility. REPOSITO

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-22 Thread Kai Uwe Broulik
broulik added a comment. Shouldn't this just follow KWin's "screens wrap around" policy? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D14988 To: phuongn, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D14988: Implement option to toggle page navigation wraps around for pager plasmoid

2018-08-22 Thread Phuong Nguyen
phuongn created this revision. phuongn added a project: Plasma. Herald added a subscriber: plasma-devel. phuongn requested review of this revision. REVISION SUMMARY BUG: 361672 This patch implement an option to disable navigation wraps around for the pager plasmoid, which potentially

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

2018-07-20 Thread Eike Hein
ILES applets/pager/package/contents/ui/main.qml applets/pager/plugin/pagermodel.cpp applets/pager/plugin/pagermodel.h applets/pager/plugin/windowmodel.cpp To: hein, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14026: [Pager] Don't show a window list on hover if there is only one window

2018-07-16 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R119:7f729fa1268c: [Pager] Don't show a window list on hover if there is only one window (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14026: [Pager] Don't show a window list on hover if there is only one window

2018-07-15 Thread Eike Hein
hein accepted this revision. hein added a comment. Sorry, was traveling. REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 To: nicolasfella, hein, broulik, ngraham Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohame

D14026: [Pager] Don't show a window list on hover if there is only one window

2018-07-14 Thread Nicolas Fella
nicolasfella added a comment. @hein Ping? REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 To: nicolasfella, hein, broulik, ngraham Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D14026: [Pager] Don't show a window list on hover if there is only one window

2018-07-10 Thread Nicolas Fella
nicolasfella added a comment. In D14026#289890 , @mart wrote: > but would still make sense to know how that one window is called? The name is still there. Just some cruft around is removed REPOSITORY R119 Plasma Desktop BRANCH window

D14026: [Pager] Don't show a window list on hover if there is only one window

2018-07-10 Thread Marco Martin
mart added a comment. but would still make sense to know how that one window is called? REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 To: nicolasfella, hein, broulik, ngraham Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliez

D14026: [Pager] Don't show a window list on hover if there is only one window

2018-07-10 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1, makes sense to me. Wait for @hein or @broulik's approval too though. REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 To: ni

D14026: [Pager] Don't show a window list on hover if there is only one window

2018-07-10 Thread Nicolas Fella
4026 AFFECTED FILES applets/pager/package/contents/ui/main.qml To: nicolasfella, hein, broulik, ngraham Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14026: [Pager] Don't show a window list on hover if there is only one window

2018-07-10 Thread Nicolas Fella
on the virtual desktop show the title directly instead of "1 Window" + one-entry list. REPOSITORY R119 Plasma Desktop BRANCH windowlist REVISION DETAIL https://phabricator.kde.org/D14026 AFFECTED FILES applets/pager/package/contents/ui/main.qml To: nicolasfella, hein, brouli

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

2018-07-06 Thread Eike Hein
hein added a comment. The change would have to be in the libtm patch. But the filter model hasn't changed, all I've done in the libtm patch is that initial population loop thing in VirtualDesktopInfo. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13748 To:

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

2018-07-06 Thread Marco Martin
mart added a comment. with latest version (don't know if depends from this or libtaskmanager) i get desktops only on a single pager cell REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13748 To: hein, mart Cc: plasma-devel, ragreen, Pitel, Zr

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

2018-07-05 Thread Eike Hein
ttps://phabricator.kde.org/D13748 AFFECTED FILES applets/pager/package/contents/ui/main.qml applets/pager/plugin/pagermodel.cpp applets/pager/plugin/pagermodel.h applets/pager/plugin/windowmodel.cpp To: hein, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

2018-07-05 Thread Eike Hein
ttps://phabricator.kde.org/D13748 AFFECTED FILES applets/pager/package/contents/ui/main.qml applets/pager/plugin/pagermodel.cpp applets/pager/plugin/pagermodel.h applets/pager/plugin/windowmodel.cpp To: hein, mart Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuter

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

2018-06-26 Thread Eike Hein
Depends on D13745 <https://phabricator.kde.org/D13745>. This code is largely untested and subject to change. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D13748 AFFECTED FILES applets/pager/package/contents/ui/main.qml applets/pager/

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

2018-01-14 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:42b099355c80: Add support for initial apply rules for skip (taskbar|pager|switcher) (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

2018-01-14 Thread Martin Flöser
graesslin added a dependent revision: D9870: Add support for apply initial keep above/below window rules. REPOSITORY R108 KWin BRANCH shell-client-skip-rules REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma, hein Cc: plasma-devel, kwin, ZrenBot, progwolff,

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

2018-01-13 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH shell-client-skip-rules REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma, hein Cc: p

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

2018-01-13 Thread Martin Flöser
graesslin added a dependency: D9865: Do not call into NETWinInfo in AbstractClient::setSkipPager. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9866 To: graesslin, #kwin, #plasma Cc: plasma-devel, kwin,

D9866: Add support for initial apply rules for skip (taskbar|pager|switcher)

2018-01-13 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin. REV

D6898: [Pager] Remove unused utils.js

2017-07-25 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:4bcbecd2e913: [Pager] Remove unused utils.js (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6898?vs=17171&id=17173 REVISION DE

D6898: [Pager] Remove unused utils.js

2017-07-25 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6898 To: broulik, #plasma, hein, davidedmundson Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D6898: [Pager] Remove unused utils.js

2017-07-25 Thread Kai Uwe Broulik
broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Grepped for utils in applets/pager, didn't find anything. Pager still works. Probably from a time where most of its logic was in QML REPOS

Re: pager widget on kde 4.3.5

2017-06-12 Thread Eike Hein
Hi, is there any reason why you guys need to use 4.3.5? It's over seven years old ... Cheers, Eike On 06/11/2017 08:25 PM, Shitrit, Shahaf wrote: > Hey, > I’m using the very useful pager widget on kde 4.3.5 . > Unlike in previos kde version, there is a problem to see in which

pager widget on kde 4.3.5

2017-06-12 Thread Shitrit, Shahaf
Hey, I'm using the very useful pager widget on kde 4.3.5 . Unlike in previos kde version, there is a problem to see in which desktop I am at. Please take a look: Previos version - can clearly see in which desktop I am: New version - impossible to see the current desktop: Is there any w

[Differential] [Closed] D4360: Revamp (Activity) Pager wheel handling

2017-02-01 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:fff65ad696f4: Revamp (Activity) Pager wheel handling (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4360?vs=10753&id=10808 REVI

[Differential] [Accepted] D4360: Revamp (Activity) Pager wheel handling

2017-02-01 Thread Marco Martin
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4360 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ T

[Differential] [Request, 53 lines] D4360: Revamp (Activity) Pager wheel handling

2017-01-30 Thread Eike Hein
. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D4360 AFFECTED FILES applets/pager/package/contents/ui/main.qml applets/pager/plugin/pagermodel.cpp applets/pager/plugin/pagermodel.h EMAIL PREFERENCES https://phabricator.kde.org

  1   2   3   4   >