This revision was automatically updated to reflect the committed changes.
Closed by commit R111:f28072080b89: Add a per-process CPU usage graph shown in
the process list (authored by fvogt).
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9689?vs=2520
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R111 KSysguard Library
BRANCH
history
REVISION DETAIL
https://phabricator.kde.org/D9689
To: fvogt, #plasma, broulik
Cc: kossebau, broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
al
fvogt updated this revision to Diff 25206.
fvogt added a comment.
Declare PercentageHistoryEntry as Q_PRIMITIVE_TYPE
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9689?vs=25109&id=25206
BRANCH
history
REVISION DETAIL
https://phabricator.kde
kossebau added a comment.
Looks like a very nice to have feature :) (no review though, not my
playground, was just curious when you pointed to it on irc)
INLINE COMMENTS
> ProcessModel.h:210
> +Q_DECLARE_METATYPE(QVector);
> +
> #endif
You could also add ` Q_DECLARE_TYPEINFO(ProcessModel::
fvogt updated this revision to Diff 25109.
fvogt added a comment.
Address review comments.
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9689?vs=24935&id=25109
BRANCH
history
REVISION DETAIL
https://phabricator.kde.org/D9689
AFFECTED FILES
broulik added a comment.
+1
INLINE COMMENTS
> ksysguardprocesslist.cpp:124
> +// Draw the history graph
> +if(hasHistory)
> +{
Coding style
> processtest.cpp:221
> +void testProcess::testCPUGraphHistory() {
> +KSysGuardProcessList *processList = new K
fvogt updated this revision to Diff 24935.
fvogt added a comment.
Rebase on current master. (Apparently my local master wasn't setup to follow
origin...)
REPOSITORY
R111 KSysguard Library
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9689?vs=24921&id=24935
BRANCH
history
REV
fvogt retitled this revision from "[WIP] Add a per-process CPU usage graph
shown in the process list" to "Add a per-process CPU usage graph shown in the
process list".
fvogt edited the test plan for this revision.
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org
