broulik added a comment.
+1
INLINE COMMENTS
> ksysguardprocesslist.cpp:124
> + // Draw the history graph
> + if(hasHistory)
> + {
Coding style
> processtest.cpp:221
> +void testProcess::testCPUGraphHistory() {
> + KSysGuardProcessList *processList = new KSysGuardProcessList;
> + processList->show();
This leaks (note how the other tests delete it afterwards), or wrap it in a
`QScopedPointer`
> processtest.cpp:226
> + // Access the PercentageHistoryRole to enable collection
> + for(int i = 0; i < model->rowCount({}); i++) {
> + auto index = model->index(i, ProcessModel::HeadingCPUUsage, {});
`rowCount()` already has a default argument for `index`
REPOSITORY
R111 KSysguard Library
REVISION DETAIL
https://phabricator.kde.org/D9689
To: fvogt, #plasma
Cc: broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
