kossebau added a comment.

  Looks like a very nice to have feature :) (no review though, not my 
playground, was just curious when you pointed to it on irc)

INLINE COMMENTS

> ProcessModel.h:210
> +Q_DECLARE_METATYPE(QVector<ProcessModel::PercentageHistoryEntry>);
> +
>  #endif

You could also add ` Q_DECLARE_TYPEINFO(ProcessModel::PercentageHistoryEntry, 
Q_PRIMITIVE_TYPE);` for some mini-opt, given the vector is changing size now 
and then (and needs its data copied to the new array).

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D9689

To: fvogt, #plasma
Cc: kossebau, broulik, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to