hein added a comment.
Comment added:
https://commits.kde.org/knotifications/9472dc7b9c63d10e5b707d1e3e3c3a24111fbe9d
INLINE COMMENTS
> davidedmundson wrote in knotificationmanager.cpp:136
> QLatin1String * 5
- 6 :P
> davidedmundson wrote in knotificationmanager.cpp:156
> No reason we can't
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:1e048a10f861: Lazy-instanciate and lazy-load
KNotification plugins. (authored by hein).
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9165?vs=23426&id=23427
davidedmundson accepted this revision.
davidedmundson added inline comments.
INLINE COMMENTS
> knotificationmanager.cpp:160
> +[&action, &pluginFound](const KPluginMetaData &data) {
> +if (pluginFound) {
> +return false;
please add a comment explai
hein updated this revision to Diff 23426.
hein added a comment.
Add and utilize a X-KDE-KNotification-OptionName field in
KNotificationPlugin to try and avoid more instanciations.
REPOSITORY
R289 KNotifications
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9165?vs=23417&id=2342
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
One minor comment, then good to go.
INLINE COMMENTS
> knotificationmanager.cpp:136
> +addPlugin(plugin);
> +} else if (action == QStringLiteral("Taskbar")) {
> +
hein added a subscriber: Frameworks.
REPOSITORY
R289 KNotifications
REVISION DETAIL
https://phabricator.kde.org/D9165
To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
hein created this revision.
hein added reviewers: Plasma, Frameworks, davidedmundson.
Restricted Application added projects: Plasma, Frameworks.
REVISION SUMMARY
KNotificationManager always instanciates all of its built-in plugins
as well as any externally supplied icons as soon as the first
