davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
One minor comment, then good to go.
INLINE COMMENTS
> knotificationmanager.cpp:136
> + addPlugin(plugin);
> + } else if (action == QStringLiteral("Taskbar")) {
> + plugin = new NotifyByTaskbar(this);
QLatin1String * 5
> knotificationmanager.cpp:156
> + } else {
> + // TODO KF6: We need to instantiate all plugins to be able to call
> + // KNotificationPlugin::optionName. It would much much nicer if we
No reason we can't add that field now and for compatibility instantiate if that
field is not set.
REPOSITORY
R289 KNotifications
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9165
To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
