hein added a comment.

  Comment added: 
https://commits.kde.org/knotifications/9472dc7b9c63d10e5b707d1e3e3c3a24111fbe9d

INLINE COMMENTS

> davidedmundson wrote in knotificationmanager.cpp:136
> QLatin1String * 5

- 6 :P

> davidedmundson wrote in knotificationmanager.cpp:156
> No reason we can't add that field now and for compatibility instantiate if 
> that field is not set.

Good point, will do.

REPOSITORY
  R289 KNotifications

REVISION DETAIL
  https://phabricator.kde.org/D9165

To: hein, #plasma, #frameworks, davidedmundson
Cc: #frameworks, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to