fvogt added inline comments.
INLINE COMMENTS
> ivan wrote in tools.js:185
> I don't like this change. Would rather have this stated explicitly than rely
> on the implementation in the favmodel. Can you make this part also aware of
> which model is behind the favoriteModel variable?
With yet an
ivan added a comment.
Somehow I didn't submit the comment when I wrote it. See above.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8178
To: fvogt, #plasma, davidedmundson
Cc: ivan, hein, davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff,
lesliezha
ivan added inline comments.
INLINE COMMENTS
> tools.js:185
> console.log("Removing from all activities");
> -favoriteModel.removeFavoriteFrom(favoriteId, ":any");
> -
> +favoriteModel.removeFavorite(favoriteId);
> } else if (actionId == "_kicker_favorite_add") {
I d
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:06f01ed291ca: Fix editing items in SimpleFavoritesModel
(authored by fvogt).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8178?vs=20437&id=20579
REVISION
fvogt added a comment.
re. the comments: I did not write any of that, it simply got added by the
tools.js sync. If this is supposed to be removed, please tell Ivan.
I did test this patch for all types of favorites, but not in relation to
activities as I'm not too familiar with them.
REPOSI
hein added a comment.
Please make sure the spam is gone (console.log), etc.
The "this crashes Qt" comment": That was written by Ivan originally.
Please make sure and test that this patch works with both kinds of favorites.
I'm travelling and am indisposed currently.
REPOSITORY
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> tools.js:32
> actionList.unshift(separator);
> +// actionList = actions.concat(actionList); // this crashes Qt
> O.o
>
rikmills added a comment.
Built with the above patch, and on quick testing it seems to resolve the
issue for me. I am not a user of activities, so my testing there to make sure
existing behaviour on the standard favourites was still the same, may not be as
thorough as desirable.
REPOSITORY
fvogt added a comment.
Someone needs to have a look at the kickoff tools.js diff - it got out of
sync apparently.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8178
To: fvogt, #plasma
Cc: rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
REVISION SUMMARY
tools.js is supposed to support both KaStatsFavoritesModel (used for
favorite applications) and SimpleFavoritesModel (used for system actions,
like poweroff/reboot/lo
10 matches
Mail list logo
