fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma.
REVISION SUMMARY tools.js is supposed to support both KaStatsFavoritesModel (used for favorite applications) and SimpleFavoritesModel (used for system actions, like poweroff/reboot/logout). The latter did not work though, as tools.js unconditionally calls methods only present in KaStatsFavoritesModel. This commit makes KaStatsFavoritesModel API compatible to SimpleFavoritesModel and changes the relevant code in tools.js to support both. Additionally, this syncs applets/kickoff/package/contents/code/tools.js again. BUG: 385463 TEST PLAN Before this patch it wasn't possible to remove system actions from the favorites bar. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8178 AFFECTED FILES applets/kicker/package/contents/code/tools.js applets/kicker/plugin/kastatsfavoritesmodel.cpp applets/kickoff/package/contents/code/tools.js To: fvogt, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
