davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > tools.js:32 > actionList.unshift(separator); > + // actionList = actions.concat(actionList); // this crashes Qt > O.o > actionList.unshift.apply(actionList, actions); I don't understand the comment; are you explaining why you're using unshift instead of concat? > tools.js:177 > > + console.log(actionId); > + ? REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8178 To: fvogt, #plasma, davidedmundson Cc: davidedmundson, rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
