This revision was automatically updated to reflect the committed changes.
Closed by commit R102:7c0f85162ee9: Implement sorting of the device tree items
(authored by isaact, committed by cfeck).
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7155?vs=26293&
davidedmundson accepted this revision.
davidedmundson added a comment.
@cfeck go for it.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7155
To: isaact, #plasma, cfeck, broulik, davidedmundson
Cc: davidedmundson, cfeck, broulik, anthonyfieroni, plasma-devel, rag
cfeck accepted this revision.
cfeck added a comment.
This revision is now accepted and ready to land.
Looks like we lost tracking this. If nobody objects, I will commit this next
week.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7155
To: isaact, #plasma, cfe
isaact updated this revision to Diff 26293.
isaact added a comment.
Hi @broulik, I've rebased the diff based on the latest source revision
(https://phabricator.kde.org/R102:d3d3ee543a17a3859bf2204c15dc7c36804eed15).
Unfortunately I don't have commit access.
REPOSITORY
R102 KInfoCenter
broulik accepted this revision.
broulik added a comment.
Working well, thanks and sorry it took so long.
Do you have commit access? You perhaps need to rebase the patch since in the
meantime the code was modernized and your patch doesn't cleanly apply anymore.
I can take care of this if you
isaact edited the summary of this revision.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7155
To: isaact, #plasma, cfeck
Cc: cfeck, broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
isaact edited the summary of this revision.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7155
To: isaact, #plasma, cfeck
Cc: cfeck, broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
isaact updated this revision to Diff 19184.
isaact marked 4 inline comments as done.
isaact added a comment.
Updated code as per feedback
REPOSITORY
R102 KInfoCenter
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7155?vs=17758&id=19184
REVISION DETAIL
https://phabricator.kde.or
isaact marked 6 inline comments as done.
isaact added a comment.
Thanks for the feedback - diff has been updated
INLINE COMMENTS
> broulik wrote in devicelisting.cpp:49
> Why disable again?
I've removed the disable as it's pointless
> anthonyfieroni wrote in soldevice.cpp:165
> left->number
isaact added a comment.
In https://phabricator.kde.org/D7155#138825, @cfeck wrote:
> Isaac, do you want to work on the requested changes?
Sorry for the long delay in responding - I will work on the suggestions this
weekend.
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https:/
cfeck requested changes to this revision.
cfeck added a comment.
This revision now requires changes to proceed.
Isaac, do you want to work on the requested changes?
REPOSITORY
R102 KInfoCenter
REVISION DETAIL
https://phabricator.kde.org/D7155
To: isaact, #plasma, cfeck
Cc: cfeck, broulik
broulik added inline comments.
INLINE COMMENTS
> devicelisting.cpp:49
> populateListing();
> +setSortingEnabled(true);
> }
Why disable again?
> soldevice.cpp:153
> +const SolDevice * otherDevice = dynamic_cast(&other);
> +if (otherDevice != nullptr)
> +{
Coding style:
anthonyfieroni added a reviewer: Plasma.
anthonyfieroni added inline comments.
INLINE COMMENTS
> soldevice.cpp:165
> +const Solid::Processor *right =
> otherDevice->tiedDevice.as();
> +return left->number() > right->number();
> +}
left->number() < rig
isaact created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
This patch attempts to fix the following bug in KInfoCenter:
https://bugs.kde.org/show_bug.cgi?id=380355 (Bug 380355 - Processors numbers
list
14 matches
Mail list logo
