anthonyfieroni added a reviewer: Plasma. anthonyfieroni added inline comments.
INLINE COMMENTS > soldevice.cpp:165 > + const Solid::Processor *right = > otherDevice->tiedDevice.as<const Solid::Processor>(); > + return left->number() > right->number(); > + } left->number() < right->number() ? > soldevice.cpp:169 > + { > + return other.text(0) < text(0); > + } Reverse again ? > soldevice.cpp:177 > +} > \ No newline at end of file Add a new line. > soldevice.h:108 > > + virtual bool operator< (const QTreeWidgetItem & other) const; > protected: Why virtual ? REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7155 To: isaact, #plasma Cc: anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas