isaact marked 6 inline comments as done. isaact added a comment.
Thanks for the feedback - diff has been updated INLINE COMMENTS > broulik wrote in devicelisting.cpp:49 > Why disable again? I've removed the disable as it's pointless > anthonyfieroni wrote in soldevice.cpp:165 > left->number() < right->number() ? This is reversed as it's sorted in the opposite order (ascending) to the other entries (descending) > anthonyfieroni wrote in soldevice.cpp:169 > Reverse again ? These are also sorted in ascending order, so that it goes from sda1, sda2, etc. > anthonyfieroni wrote in soldevice.h:108 > Why virtual ? Habit - removed REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7155 To: isaact, #plasma, cfeck Cc: cfeck, broulik, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
