This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ea59c63a815a: Match subsequences in application runner
(authored by rthomas, committed by aacid).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5870?vs=14
rthomas added a comment.
@aacid : I have assigned the Plasma-Workspace repo to this revision. Please
commit this patch on my behalf. I think I'll hold on for a while before
applying for commit access.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5870
To
rthomas set the repository for this revision to R120 Plasma Workspace.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D5870
To: rthomas, #plasma, davidedmundson
Cc: aacid, davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed,
aacid added a comment.
This has no repo assigned, so i was going to commit it but could not.
You can apply for a developer account if you think you need it at
https://community.kde.org/Infrastructure/Get_a_Developer_Account
REVISION DETAIL
https://phabricator.kde.org/D5870
To: rthomas
rthomas added a comment.
No, I don't have commit access yet. Can I apply for a developer account now?
I haven't done so until now.
REVISION DETAIL
https://phabricator.kde.org/D5870
To: rthomas, #plasma, davidedmundson
Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff,
le
davidedmundson added a comment.
Do you have commit access?
REVISION DETAIL
https://phabricator.kde.org/D5870
To: rthomas, #plasma, davidedmundson
Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart, lukas
davidedmundson accepted this revision.
This revision is now accepted and ready to land.
REVISION DETAIL
https://phabricator.kde.org/D5870
To: rthomas, #plasma, davidedmundson
Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, s
rthomas added a comment.
Uh.. ping?
REVISION DETAIL
https://phabricator.kde.org/D5870
To: rthomas, #plasma
Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas
rthomas marked 3 inline comments as done.
REVISION DETAIL
https://phabricator.kde.org/D5870
To: rthomas, #plasma
Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas
rthomas updated this revision to Diff 14603.
rthomas added a comment.
- Splitting the query using splitRef() instead of split()
- Using QLatin1Char(' ') as the separator to split the query
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D5870?vs=14559&id=14603
REVISION DETAIL
http
davidedmundson added inline comments.
INLINE COMMENTS
> rthomas wrote in servicerunner.cpp:203
> Could you explain why would we want to use splitRef instead of split? I'm not
> sure I understand the need for it.
split copies the strings.
splitRef creates references to a location within an exits
rthomas added inline comments.
INLINE COMMENTS
> apol wrote in servicerunner.cpp:101
> use a foreach
I'm skipping the first string in strList because that string has already been
accounted for relavace right before the call to increaseMatchRelavance.
Relevance is incremented by 0.01 only based
apol added a comment.
+1
INLINE COMMENTS
> servicerunner.cpp:101
> +
> +for(int i=1; i +{
use a foreach
> servicerunner.cpp:203
> +//Splitting the query term to match using subsequences
> +QStringList queryList = term.split(" ");
> +
`splitRef(QLatin1Char('
rthomas created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Match applications in krunner using subsequences instead of substrings. This
allows matching applications using parts of its name, instead of
14 matches
Mail list logo
