davidedmundson added inline comments.

INLINE COMMENTS
> rthomas wrote in servicerunner.cpp:203
> Could you explain why would we want to use splitRef instead of split? I'm not 
> sure I understand the need for it.

split copies the strings.
splitRef creates references to a location within an exitsting string without 
copying it.

Result is the same but faster.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5870

To: rthomas, #plasma
Cc: davidedmundson, apol, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, lukas

Reply via email to