apol added a comment.

  +1

INLINE COMMENTS

> servicerunner.cpp:101
> +
> +        for(int i=1; i<strList.size(); i++)
> +        {

use a foreach

> servicerunner.cpp:203
> +        //Splitting the query term to match using subsequences
> +        QStringList queryList = term.split(" ");
> +

`splitRef(QLatin1Char(' '))`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5870

To: rthomas, #plasma
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, lukas

Reply via email to