This revision was automatically updated to reflect the committed changes.
Closed by commit R134:639bf33c0192: Queue some connections which cannot be
autodetected (authored by leinir).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D5409?vs=13386&id=13566#toc
REPOSITORY
R134 Discover Sof
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
Go for it, let's see how it goes.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5409
To: leinir, #discover_software_store, apol
Cc: plasma-devel, sps
leinir updated this revision to Diff 13386.
leinir marked an inline comment as done.
leinir added a comment.
Changed the KNS backend's main queued connection to somewhere a tiny bit more
central. This causes us to require KNewStuff master, but we already require a
bunch of master stuff elsewh
leinir marked an inline comment as done.
leinir added inline comments.
INLINE COMMENTS
> apol wrote in KNSBackend.cpp:330
> Then maybe it's KNS that should be syncing?
> i.e. `connect(m_engine, &KNSCore::Engine::signalEntriesLoaded, this,
> &KNSBackend::receivedEntries);`
>
> Or even have KNSCo
apol requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5409
To: leinir, #discover_software_store, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, a
apol added inline comments.
INLINE COMMENTS
> KNSBackend.cpp:330
> m_page = 0;
> -connect(this, &KNSBackend::receivedResources, stream,
> &ResultsStream::resourcesFound);
> +connect(this, &KNSBackend::receivedResources, stream,
> &ResultsStream::resourcesFound, Qt::Queu
leinir added a comment.
In https://phabricator.kde.org/D5409#101510, @apol wrote:
> Are you sure? Which other threads? From the rendering?
Yeah, the crashes happen when forwarding the data updates to the view, which
has potentially changed in the meantime.
REPOSITORY
R134 Disco
apol added a comment.
Are you sure? Which other threads? From the rendering?
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D5409
To: leinir, #discover_software_store, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,
leinir created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Some of the connections we make are doing cross-thread calls, but in
functions which exist on objects which live inside the same thread.
Conse
