apol added inline comments.

INLINE COMMENTS

> KNSBackend.cpp:330
>          m_page = 0;
> -        connect(this, &KNSBackend::receivedResources, stream, 
> &ResultsStream::resourcesFound);
> +        connect(this, &KNSBackend::receivedResources, stream, 
> &ResultsStream::resourcesFound, Qt::QueuedConnection);
>          connect(this, &KNSBackend::searchFinished, stream, 
> &ResultsStream::deleteLater);

Then maybe it's KNS that should be syncing?
i.e. `connect(m_engine, &KNSCore::Engine::signalEntriesLoaded, this, 
&KNSBackend::receivedEntries);`

Or even have KNSCore emit from the object's thread:
http://doc.qt.io/qt-5/threads-qobject.html#signals-and-slots-across-threads

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D5409

To: leinir, #discover_software_store, apol
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Reply via email to