This revision was automatically updated to reflect the committed changes.
Closed by commit R108:fd58c68ba5a4: Set wayland output scale (authored by
davidedmundson).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3159?vs=8501&id=13964
REVISION DETAIL
https://ph
davidedmundson added a dependency: D3498: Add scaling to DRM backend.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D3159
To: davidedmundson, graesslin, #plasma
Cc: broulik, graesslin, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas,
davidedmundson updated this revision to Diff 8501.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Add a scale method to the backends and proxy this to wl_output
Also add a --scale argument for testing
REPOSITORY
rKWIN KWin
CHANGES SI
graesslin added inline comments.
INLINE COMMENTS
> x11windowed_backend.cpp:201-205
> +//generally we don't need to normalise input to the output
> scale; however because we're getting input
> +//from a host window that doesn't understand scaling, we need to
> apply it ou
davidedmundson updated this revision to Diff 7989.
davidedmundson marked 4 inline comments as done.
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
- Squash with input scaling
- Squash with client size surface normal commit
- hopefully fix
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in scene_qpainter.cpp:311-313
> ah so that's basically the "scale everything up" if output has a scale, but
> not yet the "surface has a scale of 2"?
What this code is doing is painting in output normalised space; no matter
graesslin added inline comments.
INLINE COMMENTS
> davidedmundson wrote in scene_qpainter.cpp:311-313
> I'm harnassing QPainter's internal scaling.
>
> The old code:
>
> painter->drawImage(toplevel->clientPos(),
>pixmap->image(),
>
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in scene_qpainter.cpp:311-313
> I don't understand how the scaling comes in here?
I'm harnassing QPainter's internal scaling.
The old code:
painter->drawImage(toplevel->clientPos(),
pix
davidedmundson updated this revision to Diff 7966.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
WIP: high DPI scaling support in kwin.
Surface events are all normalised by surface_scale
Output is normalised to output_scale
From
graesslin accepted this revision.
graesslin added a reviewer: graesslin.
This revision is now accepted and ready to land.
REPOSITORY
rKWIN KWin
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D3159
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
davidedmundson updated this revision to Diff 7677.
davidedmundson added a comment.
Restricted Application edited projects, added KWin; removed Plasma.
qvector::fill
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D3159?vs=7666&id=7677
BRANCH
master
REVISION
broulik added inline comments.
INLINE COMMENTS
> x11windowed_backend.cpp:477-480
> +QVector ret;
> +for (auto it = m_windows.constBegin(); it != m_windows.constEnd(); ++it)
> {
> +ret << initialOutputScale();
> +}
QVector &QVector::fill(const T &value, int size = -1)
Assign
davidedmundson updated this revision to Diff 7666.
davidedmundson marked 3 inline comments as done.
davidedmundson added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
int -> real
REPOSITORY
rKWIN KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D
davidedmundson added inline comments.
INLINE COMMENTS
> graesslin wrote in main_wayland.cpp:638
> hmm I'm not sure whether we should implement it as an int factor. Even if
> Wayland only supports integer scaling, I think that's a bad idea and we
> should rather go with fractal scaling from the
graesslin added a comment.
I suggest to also implement in the virtual platform in order to be able to
auto-test it.
INLINE COMMENTS
> main_wayland.cpp:528
> +i18n("The scale for windowed mode.
> Default value is 1."),
> +
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
Provides a virtual method in Screens where backends can supply the scale
of each screen, t
16 matches
Mail list logo
