graesslin added a comment.
I suggest to also implement in the virtual platform in order to be able to
auto-test it.
INLINE COMMENTS
> main_wayland.cpp:528
> + i18n("The scale for windowed mode.
> Default value is 1."),
> + QStringLiteral("height"));
> + scaleOption.setDefaultValue(QString::number(1));
careful here: copy and paste error
> main_wayland.cpp:638
> int outputCount = 1;
> + int outputScale = 1;
>
hmm I'm not sure whether we should implement it as an int factor. Even if
Wayland only supports integer scaling, I think that's a bad idea and we should
rather go with fractal scaling from the start. Of course towards Wayland we
need to expose it as integer scaling. But in case Wayland gets an update we
would be prepared.
> wayland_server.cpp:353
> OutputInterface *output = m_display->createOutput(m_display);
> + output->setScale(s->scale(i));
> const QRect &geo = s->geometry(i);
At the moment KWin doesn't scale yet. I think we should not start to export
scale to Wayland as long as we don't support it.
The idea behind the scale in Wayland is that the compositor itself scales up
all surfaces which don't provide the correct scale factor. Just mentioning in
case you are not aware of it.
REPOSITORY
rKWIN KWin
REVISION DETAIL
https://phabricator.kde.org/D3159
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, kwin, lesliezhai, ali-mohamed, hardening,
jensreuterberg, abetts, sebas
