D29847: Fixes compile problem for freebsd because of missing crypt.h

adridg added a comment. This review should be closed: a change landed via invent that makes it unnecessary (`` is no longer used in the users kcm). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd C

D29847: Fixes compile problem for freebsd because of missing crypt.h

meven added a comment. In D29847#674811 , @usta wrote: > In D29847#674807 , @adridg wrote: > > > https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes > > > > There's already a CM

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta added a comment. In D29847#674807 , @adridg wrote: > https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes > > There's already a CMake-time check for ``, it's just not used. (`HAVE_CRYPT_H`) @adridg having or not

D29847: Fixes compile problem for freebsd because of missing crypt.h

adridg added a comment. https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes There's already a CMake-time check for ``, it's just not used. (`HAVE_CRYPT_H`) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 To: usta, #plasma, bcooks

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta added a comment. or if this is just for linux think we can make it just directly if defined(Q_OS_LINUX) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29847 To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd Cc: tcberner, adridg, plasma-devel, Or

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta updated this revision to Diff 83237. usta added a project: FreeBSD. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29847?vs=83235&id=83237 REVISION DETAIL https://phabricator.kde.org/D29847 AFFECTED FILES kcms/users/src/user.cpp To: usta, #pl

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta added a comment. Sorry i have written one of them twice , so is this aproach wrong ? #if !defined(Q_OS_UNIX) && !defined(Q_OS_BSD4) && !defined(Q_OS_FREEBSD) && !defined(Q_OS_NETBSD) && !defined(Q_OS_OPENBSD) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta added inline comments. INLINE COMMENTS > tcberner wrote in user.cpp:23 > wouldn't it be a bit more portable to check for the header file in cmake? > (OpenBSD also has the same issue, I would assume from [1]) > > [1] > https://www.freebsd.org/cgi/man.cgi?query=crypt&apropos=0&sektion=3&man

D29847: Fixes compile problem for freebsd because of missing crypt.h

tcberner added inline comments. INLINE COMMENTS > user.cpp:23 > #include > +#ifndef Q_OS_FREEBSD > #include wouldn't it be a bit more portable to check for the header file in cmake? (OpenBSD also has the same issue, I would assume from [1]) [1] https://www.freebsd.org/cgi/man.cgi?query=cr

D29847: Fixes compile problem for freebsd because of missing crypt.h

ngraham added a reviewer: adridg. ngraham added a subscriber: adridg. ngraham added a comment. Adding @adridg as a reviewer. Note that we have moved to Gitlab, so future contributions should be submitted at invent.kde.org. Thanks! You can find the documentation at https://community.kde.o

D29847: Fixes compile problem for freebsd because of missing crypt.h

usta created this revision. usta added reviewers: Plasma, bcooksley. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. usta requested review of this revision. REVISION SUMMARY Freebsd compile is not working last 17 days because of missing crypt.h crypt method is in unist