tcberner added inline comments.

INLINE COMMENTS

> user.cpp:23
>  #include <user.h>
> +#ifndef Q_OS_FREEBSD
>  #include <crypt.h>

wouldn't it be a bit more portable to check for the header file in cmake? 
(OpenBSD also has the same issue, I would assume from [1])

[1] 
https://www.freebsd.org/cgi/man.cgi?query=crypt&apropos=0&sektion=3&manpath=OpenBSD+6.7&arch=default&format=html

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29847

To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to