usta added a comment.

  In D29847#674807 <https://phabricator.kde.org/D29847#674807>, @adridg wrote:
  
  > https://invent.kde.org/adridg/plasma-desktop/-/tree/normalize-includes
  >
  > There's already a CMake-time check for `<crypt.h>`, it's just not used. 
(`HAVE_CRYPT_H`)
  
  
  @adridg having or not having crypt_h I think won't solve this problem because 
it looks like Linux needs it on the other hand BSD system doesn't have it and 
use unistd.h
  instead of crypt.h so doesn't we still need to check if the system is linux 
or not ? I have almost 0 knowledge about bsd systems so i think anyone who has 
knowledge 
  on this topic might be more suitable for this patch request. ( at first, I 
have just think about freebsd and now i can see there are other alternatives 
(net,open,... bsd has similar issue ) )

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29847

To: usta, #plasma, bcooksley, ngraham, adridg, #freebsd
Cc: tcberner, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, arrowd, sebas, apol, 
ahiemstra, mart

Reply via email to