This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9c3c2d1a2379: Add support for layers to PagePoolAction.
(authored by masonm).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D29294?vs=81640&id=81935#toc
REPOSITORY
R169 Kirigami
CHANGES SIN
masonm updated this revision to Diff 81640.
masonm added a comment.
Fix preventing layer from pushing itself
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29294?vs=81619&id=81640
BRANCH
add-pagepool-layer-support (branched from master)
REVISION DETAIL
masonm updated this revision to Diff 81619.
masonm marked an inline comment as not done.
masonm added a comment.
Add _private QtObject back and comment why
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29294?vs=81610&id=81619
BRANCH
add-pagepool-layer-
masonm marked an inline comment as not done.
masonm added inline comments.
INLINE COMMENTS
> cblack wrote in PagePoolAction.qml:161
> this isn't how you do private objects, drop `property QtObject _private` and
> access by ID
Actually I realized why I did this now: the Action type does not allo
masonm updated this revision to Diff 81610.
masonm added a comment.
Code review changes 1
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29294?vs=81606&id=81610
BRANCH
add-pagepool-layer-support (branched from master)
REVISION DETAIL
https://phabrica
cblack added inline comments.
INLINE COMMENTS
> tst_layers.qml:19-25
> +function initTestCase() {
> +mainWindow.show()
> +}
> +
> +function cleanupTestCase() {
> +mainWindow.close()
> +}
You want to use `when: windowShown`
> tst_layers.qml:27
> +
> +function
masonm updated this revision to Diff 81606.
masonm added a comment.
Handle checked status with exclusive groups
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29294?vs=81588&id=81606
BRANCH
add-pagepool-layer-support (branched from master)
REVISION DET
masonm updated this revision to Diff 81588.
masonm added a comment.
Honor checkable state of Action
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D29294?vs=81562&id=81588
BRANCH
add-pagepool-layer-support (branched from master)
REVISION DETAIL
https:
masonm created this revision.
masonm added reviewers: Kirigami, mart.
masonm added a project: Kirigami.
masonm requested review of this revision.
REVISION SUMMARY
Currently PagePoolAction only supports pushing to a pageStack, but often it
makes sense to use layers to push modal/contextual pages
