masonm created this revision. masonm added reviewers: Kirigami, mart. masonm added a project: Kirigami. masonm requested review of this revision.
REVISION SUMMARY Currently PagePoolAction only supports pushing to a pageStack, but often it makes sense to use layers to push modal/contextual pages (outside of the primary pageStack flow). This change introduces support for a "useLayers" property that can be set on PagePoolAction, allowing it use the pageStack.layers StackView (if it exists). It also includes a unit test and a couple fixes uncovered by the test. TEST PLAN See the tst_layers unit test included. REPOSITORY R169 Kirigami BRANCH add-pagepool-layer-support (branched from master) REVISION DETAIL https://phabricator.kde.org/D29294 AFFECTED FILES .gitignore autotests/CMakeLists.txt autotests/pagepool/tst_layers.qml src/controls/PagePoolAction.qml src/controls/PageRow.qml src/pagepool.cpp src/pagepool.h To: masonm, #kirigami, mart Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson