cblack added inline comments.
INLINE COMMENTS
> tst_layers.qml:19-25
> + function initTestCase() {
> + mainWindow.show()
> + }
> +
> + function cleanupTestCase() {
> + mainWindow.close()
> + }
You want to use `when: windowShown`
> tst_layers.qml:27
> +
> + function applicationWindow() { return mainWindow; }
> +
Unused.
> PagePoolAction.qml:63
> + * This is intended for use with PageRow layers to allow
> PagePoolActions to
> + * push context-specific pages onto the layers stack.
> + */
@since 5.70
@since org.kde.kirigami 2.12
> PagePoolAction.qml:161
> +
> + property QtObject _private: QtObject {
> + id: _private
this isn't how you do private objects, drop `property QtObject _private` and
access by ID
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D29294
To: masonm, #kirigami, mart
Cc: cblack, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos,
ngraham, apol, ahiemstra, davidedmundson
