D23306: Add AppStream metadata file

2019-08-21 Thread Nathaniel Graham
ngraham added a comment. All right, hopefully the third time's the charm: D23328 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23306 To: ngraham, apol, mak, #plasma Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-De

D23306: Add AppStream metadata file

2019-08-21 Thread Matthias Klumpp
mak added a comment. In D23306#515666 , @kossebau wrote: > In D23306#515662 , @mak wrote: > > > In D23306#515616 , @kossebau wrote: > > > > > Thanks! Th

D23306: Add AppStream metadata file

2019-08-21 Thread Nathaniel Graham
ngraham added a comment. In D23306#516094 , @kossebau wrote: > @ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix: > > > While desktop-application metadat

D23306: Add AppStream metadata file

2019-08-21 Thread Friedrich W. H. Kossebau
kossebau added a comment. @ngraham You used the "appdata.xml" file suffix here. I noticed yesterday when reading the spec that it now declares that as legacy suffix: > While desktop-application metadata is commonly stored in /usr/share/metainfo/%{id}.metainfo.xml (with a .metainfo.xml ex

D23306: Add AppStream metadata file

2019-08-21 Thread Friedrich W. H. Kossebau
kossebau added a comment. Hi @mak, so seems we appdata content creators are still unsure what to do, allow me to put the last question of last night again to your attention: In D23306#515666 , @kossebau wrote: > In D23306#515662

D23306: Add AppStream metadata file

2019-08-21 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes. Closed by commit R124:b249a3d4e76e: Add AppStream metadata file (authored by ngraham). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64221&id=64222 REVISION DETAIL h

D23306: Add AppStream metadata file

2019-08-21 Thread Nathaniel Graham
ngraham updated this revision to Diff 64221. ngraham marked an inline comment as done. ngraham added a comment. Remove unnecessary X-AppStream-Ignore property REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64171&id=64221 BRANCH add-appda

D23306: Add AppStream metadata file

2019-08-21 Thread Friedrich W. H. Kossebau
kossebau added inline comments. INLINE COMMENTS > kdesystemsettings.desktop:163 > X-DBUS-ServiceName=org.kde.systemsettings > +# Otherwise Discover and other software centers show two System Settings > entries > +X-AppStream-Ignore=true For what I understood from "No. A launchable tag always b

D23306: Add AppStream metadata file

2019-08-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D23306#515662 , @mak wrote: > In D23306#515616 , @kossebau wrote: > > > Thanks! Though reading it, leaves open questions with me: > > > > - what is meant by "referenc

D23306: Add AppStream metadata file

2019-08-20 Thread Matthias Klumpp
mak added a comment. In D23306#515616 , @kossebau wrote: > In D23306#515609 , @mak wrote: > > > @kossebau How to hide .desktop files from AppStream is now more visible in https://www.freedesktop.org

D23306: Add AppStream metadata file

2019-08-20 Thread Nathaniel Graham
ngraham updated this revision to Diff 64171. ngraham added a comment. Add `project_group` and `compulsory_for_desktop` tags REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64169&id=64171 BRANCH add-appdata-file (branched from master) REV

D23306: Add AppStream metadata file

2019-08-20 Thread Nathaniel Graham
ngraham added a comment. @mak The link https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-compulsory_for_desktop seems broken. I found a reference to `compulsory_for_desktop` at https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html, but it poin

D23306: Add AppStream metadata file

2019-08-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D23306#515609 , @mak wrote: > @kossebau How to hide .desktop files from AppStream is now more visible in https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html#spec-appdata-introduction as

D23306: Add AppStream metadata file

2019-08-20 Thread Matthias Klumpp
mak added a comment. In D23306#515595 , @ngraham wrote: > In fact there are three possible relationships: > > - App is associated with desktop, but not required by it or limited to it (e.g. Dolphin, Gwenview, Nautilus, GNOME Music) --

D23306: Add AppStream metadata file

2019-08-20 Thread Nathaniel Graham
ngraham added a comment. In fact there are three possible relationships: - App is associated with desktop, but not required by it or limited to it (e.g. Dolphin, Gwenview, Nautilus, GNOME Music) - App requires desktop (e.g. KDE System Settings, GNOME System Settings, GNOME Tweaks) -

D23306: Add AppStream metadata file

2019-08-20 Thread Matthias Klumpp
mak added a comment. In D23306#515592 , @ngraham wrote: > In D23306#515589 , @mak wrote: > > > In D23306#515577 , @ngraham wrote: > > > > > Adjust accor

D23306: Add AppStream metadata file

2019-08-20 Thread Nathaniel Graham
ngraham added a comment. In D23306#515589 , @mak wrote: > In D23306#515577 , @ngraham wrote: > > > Adjust according to review comments > > > This will work. I would change `System Settings` to

D23306: Add AppStream metadata file

2019-08-20 Thread Matthias Klumpp
mak added a comment. Adding a `project_group` may also be a nice idea: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-project_group REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23306 To: ngraham, apol, mak, #plasma Cc: kossebau

D23306: Add AppStream metadata file

2019-08-20 Thread Matthias Klumpp
mak added a comment. In D23306#515585 , @kossebau wrote: > @mak: tnanks for the hint. will also see to use X-AppStream-Ignore for kdevelop then. any chance we can see this trick documented on https://www.freedesktop.org/software/appstream/docs/s

D23306: Add AppStream metadata file

2019-08-20 Thread Matthias Klumpp
mak added a comment. In D23306#515577 , @ngraham wrote: > Adjust according to review comments This will work. I would change `System Settings` to ` KDE System Settings` or `Plasma System Settings`, just like GNOME sets a name like "GNOME

D23306: Add AppStream metadata file

2019-08-20 Thread Nathaniel Graham
ngraham updated this revision to Diff 64169. ngraham added a comment. Add `` tag so searching for it from the old URLs still works REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64168&id=64169 BRANCH add-appdata-file (branched from maste

D23306: Add AppStream metadata file

2019-08-20 Thread Friedrich W. H. Kossebau
kossebau added a comment. @mak: tnanks for the hint. will also see to use X-AppStream-Ignore for kdevelop then. any chance we can see this trick documented on https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html , please? :) REPOSITORY R124 System Settings R

D23306: Add AppStream metadata file

2019-08-20 Thread Nathaniel Graham
ngraham added a comment. Thanks for the into @mak, that's very helpful. I've removed one of the launchable tags since only one .desktop file has the info that you would want to use to launch it as a KDE user. And I've added `X-AppStream-Ignore=true` to one of the .desktop files. Does th

D23306: Add AppStream metadata file

2019-08-20 Thread Nathaniel Graham
ngraham updated this revision to Diff 64168. ngraham added a comment. Adjust according to review comments REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64161&id=64168 BRANCH add-appdata-file (branched from master) REVISION DETAIL htt

D23306: Add AppStream metadata file

2019-08-20 Thread Matthias Klumpp
mak added a comment. There's also a FAQ entry for this, apparently I only documented this for Debian Developers back in the day ^^ > https://wiki.debian.org/AppStream/Guidelines#How_to_exclude_.desktop_files_from_the_metadata ===

D23306: Add AppStream metadata file

2019-08-20 Thread Matthias Klumpp
mak added a comment. @ngraham > Alternative to D23302 . According to the AppStream documentation (https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html), > adding an AppStream metadata file with multiple launchable tags

D23306: Add AppStream metadata file

2019-08-20 Thread Nathaniel Graham
ngraham created this revision. ngraham added reviewers: apol, mak, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Alternative to D23302 . According to the AppStream