mak added a comment.

  In D23306#515577 <https://phabricator.kde.org/D23306#515577>, @ngraham wrote:
  
  > Adjust according to review comments
  
  
  This will work. I would change `<name>System Settings</name>` to `<name> KDE 
System Settings</name>` or `<name>Plasma System Settings</name>`, just like 
GNOME sets a name like "GNOME Videos" instead of "Videos" in their metadata. 
Otherwise this name will confuse users of GNOME, I guess.
  You'll also highly likely want to set `compulsory_for_desktop` ( 
https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html#tag-ct-compulsory_for_desktop
 ) to prevent this app to be removable on Plasma.
  So adding
  
    <compulsory_for_desktop>KDE</compulsory_for_desktop>
    <compulsory_for_desktop>Plasma</compulsory_for_desktop>
  
  will do the trick (AppStream recognizes "Plasma", but the desktop is actually 
known as "KDE" everywhere in Freedesktop, so just using "KDE" would probably be 
sufficient and compatible with everything. Having "Plasma" as well won't hurt 
though)
  Ypu may want FSFAP <https://spdx.org/licenses/FSFAP.html> as 
`metadata_license` as it's much shorter than CC0 and mixes well with GPL. 
However that's a personal choice and not required for anything. CC0 would work 
just fine.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23306

To: ngraham, apol, mak, #plasma
Cc: kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Reply via email to