apol added inline comments.
INLINE COMMENTS
> mart wrote in delegaterecycler.cpp:373
> https://doc.qt.io/qt-5/qquickitem.html#Flag-enum
>
> you can set the focusscope flag on top of any qquickitem, FocusScope is just
> an empty item that doesn't do anything that setting thjat flag in its ctor
>
apol updated this revision to Diff 58012.
apol added a comment.
Go for a more elegant approach: use Keys.forwardsTo and expose the item
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21128?vs=57870&id=58012
BRANCH
arcpatch-D21128
REVISION DETAIL
http
mart added inline comments.
INLINE COMMENTS
> apol wrote in delegaterecycler.cpp:373
> DelegateRecycler can't be a FocusScope itself because QQuickFocusScope is
> private API.
>
> We could put it in a FocusScope but then this opens a can of worms WRT sizes.
https://doc.qt.io/qt-5/qquickitem.ht
apol updated this revision to Diff 57870.
apol added a comment.
Remove unnecessary name
REPOSITORY
R169 Kirigami
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D21128?vs=57865&id=57870
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D21128
AFFECTED FILES
src/cont
apol marked an inline comment as done.
apol added inline comments.
INLINE COMMENTS
> mart wrote in delegaterecycler.cpp:373
> this doesn't look right. especially because it will help with keyboard
> navigation, but not with accessibility at all.
>
> The proper solutuion should be make DelegateR
mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> PrivateActionToolButton.qml:100
> +
> +readonly property var p0: Shortcut {
> +sequence: label.MnemonicData.sequence
why p0?
apol created this revision.
apol added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Forward DelegateRecycler keyboard events to the actual delegate.
Have PrivateActionToolButton tr
