apol added inline comments.

INLINE COMMENTS

> mart wrote in delegaterecycler.cpp:373
> https://doc.qt.io/qt-5/qquickitem.html#Flag-enum
> 
> you can set the focusscope flag on top of any qquickitem, FocusScope is just 
> an empty item that doesn't do anything that setting thjat flag in its ctor
> 
> QQuickFocusScope::QQuickFocusScope(QQuickItem *parent)
> : QQuickItem(parent)
> {
> 
>   setFlag(ItemIsFocusScope);
> 
> }

I tried it, but it doesn't really make a difference, since the event was 
already being delivered to the item, the recycler, the problem was that the key 
stroke never reached the actual delegate.

I've changed it to use the declarative API, I think it looks more elegant.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D21128

To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein

Reply via email to