mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> PrivateActionToolButton.qml:100
> +
> + readonly property var p0: Shortcut {
> + sequence: label.MnemonicData.sequence
why p0?
having another shortcut here isn't nice, but is kinda necessary since how the
desktop style paints the text in the button background
just remove p0
> delegaterecycler.cpp:373
> +
> +bool DelegateRecycler::event(QEvent* event)
> +{
this doesn't look right. especially because it will help with keyboard
navigation, but not with accessibility at all.
The proper solutuion should be make DelegateRecycler a FocusScope (and i
*think* setting activefocusontab to false tough not 100% sure now)
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D21128
To: apol, #kirigami, mart
Cc: plasma-devel, domson, dkardarakos, apol, davidedmundson, mart, hein
