D19796: [Device Notifier] Restore Solid notification messages

thsurrel updated this revision to Diff 57736. thsurrel added a comment. Fix comments. Thank you for the review! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19796?vs=57722&id=57736 BRANCH arc_removed_devices REVISION DETAIL https://phabri

D19796: [Device Notifier] Restore Solid notification messages

thsurrel updated this revision to Diff 57722. thsurrel added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19796?vs=53978&id=57722 BRANCH arc_removed_devices REVISION DETAIL https://phabricator.kde.org/D19796 AFFECTED FILE

D20773: [Task Manager] Bring to current desktop with middle-click

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a416f16b562b: [Task Manager] Bring to current desktop with middle-click (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20773?vs=56865

D20773: [Task Manager] Bring to current desktop with middle-click

thsurrel updated this revision to Diff 56865. thsurrel added a comment. Fixes as per Nate's comments. Thanks for the review! REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20773?vs=56842&id=56865 BRANCH arc_middleclick REVISION DETAIL https:/

D20773: [Task Manager] Bring to current desktop with middle-click

thsurrel created this revision. thsurrel added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY This adds a new possible action when middle-click is used on a task in the task manager:

D19796: [Device Notifier] Restore Solid notification messages

thsurrel added a comment. Anyone could have a look at this ? Thanks in advance. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19796 To: thsurrel, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreut

D18438: [Task Manager] When closing apps, resize only when mouse is out.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2861ae7cc675: [Task Manager] When closing apps, resize only when mouse is out. (authored by thsurrel). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D18438?vs=53394&id=54147#toc REPOSITORY R

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel added a comment. I can land this myself. Thank you again for all your help. REPOSITORY R119 Plasma Desktop BRANCH arc_taskmanagerclose (branched from master) REVISION DETAIL https://phabricator.kde.org/D18438 To: thsurrel, #plasma, #vdg, hein Cc: hein, plasma-devel, jraleig

D19796: [Device Notifier] Restore Solid notification messages

thsurrel created this revision. thsurrel added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Commit 17380886

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel added a comment. Ping Does this seem better now, @hein ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18438 To: thsurrel, #plasma, #vdg, hein Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterber

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

thsurrel added a comment. And I could guide you around the kernel except in the graphic area ... REVISION DETAIL https://phabricator.kde.org/D19678 To: vishaw, #plasma, ngraham Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abe

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

thsurrel added a comment. Yeah, that would help if I had a laptop that has this behavior, but I couldn't find any. REVISION DETAIL https://phabricator.kde.org/D19678 To: vishaw, #plasma, ngraham Cc: thsurrel, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19678: Feature: Add an option to adjust screen brightness by quadratic curve instead of linear when using brightness keys

thsurrel added a comment. I would love to see something like this getting in somehow, but as Nate described, we run into a problem with literally the first person that tested the patch. That sounds statistically bad. I did not find a way to ensure that a given minimal step would turn on

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel added a comment. Thank you so much for your patient reviews! As a side note, I noticed something a bit odd while testing: if the task manager is configured with grouping, and you open a bunch of Kate instances and close them all at once by middle-clicking on the "grouped task",

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel updated this revision to Diff 53394. thsurrel added a comment. Fix code for groups and WinId-less tasks. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18438?vs=53240&id=53394 BRANCH arc_taskmanagerclose (branched from master) REVISION D

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel updated this revision to Diff 53240. thsurrel added a comment. Use the WinIdList role REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18438?vs=50291&id=53240 BRANCH arc_taskmanagerclose (branched from master) REVISION DETAIL https://pha

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel added a comment. Hi @hein, could you help me finish this patch ? Can you have a look at my previous question ? Many thanks in advance. REPOSITORY R119 Plasma Desktop BRANCH arc_taskmanagerclose (branched from master) REVISION DETAIL https://phabricator.kde.org/D18438 To: ths

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel added inline comments. INLINE COMMENTS > hein wrote in Task.qml:155 > Getting close, but `pid` is not reliable. It's not available for all tasks > (e.g. remote X11 clients). You need to use the window id role instead. I do not find a window id role, maybe I am not looking in the right

D16914: [Runners KCM] Focus the search field by default

thsurrel updated this revision to Diff 50294. thsurrel added a comment. Focus on load REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16914?vs=45551&id=50294 BRANCH arc_focussearch (branched from master) REVISION DETAIL https://phabricator.kde.o

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel updated this revision to Diff 50291. thsurrel added a comment. Improvements as per #hein comments Keep resizing if the task being closed with the middle button is the last one in the task manager. That matches Firefox behavior. Thanks again for the fast reviews. REPOSITORY

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel updated this revision to Diff 50196. thsurrel added a comment. Let's be as smart as Firefox! Thanks for the review REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18438?vs=50024&id=50196 BRANCH arc_taskmanagerclose (branched from master)

D18438: [Task Manager] When closing apps, resize only when mouse is out.

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When closing several apps from the task manager with the mouse middle button, it is conve

D16212: [Device Notifier] Add a button to unmount all devices

This revision was automatically updated to reflect the committed changes. Closed by commit R120:81db74434cd5: [Device Notifier] Add a button to unmount all devices (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=49644&i

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 49644. thsurrel added a comment. Display the unmountAll button only when there are some MOUNTED devices. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=49640&id=49644 BRANCH arc_unmountall (branche

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. There is a regression, I did not notice at first. By storing the connectedRemovables and not the mountedRemovables, the unmountAll button will appear even if nothing is mounted. That's not good. I have to update a list in the onMountedChanged slot as I was doing be

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added inline comments. INLINE COMMENTS > broulik wrote in FullRepresentation.qml:113 > How about adding the following to the button: > > Layout.alignment: Qt.AlignRight > Layout.preferredWidth: minimumWidth That does not seem to do the trick. I am trying to have the button at a fix

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added inline comments. INLINE COMMENTS > broulik wrote in devicenotifier.qml:122 > This is for having the bindings refresh, right? Yes indeed. Any better ways ? REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from master) REVISION DETAIL https://phabricator.kde

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel marked 6 inline comments as done. thsurrel added inline comments. INLINE COMMENTS > broulik wrote in DeviceItem.qml:92 > Can we assume "action" is always unmount? If the device is removable and mounted, than the action can only be unmounting, yes. > broulik wrote in FullRepresentation

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 49640. thsurrel added a comment. Trying to improve based on broulik comments. Thank you very much for the review! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=46999&id=49640 BRANCH arc_unmounta

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. A last minute review in case this can get into 5.15 ? Please :) REPOSITORY R120 Plasma Workspace BRANCH arc_unmountall (branched from master) REVISION DETAIL https://phabricator.kde.org/D16212 To: thsurrel, #plasma, #vdg, ngraham Cc: broulik, ngraham, plasma-

D16170: [Device Notifier] Restore busy indicator

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a7b2ecdb12b8: [Device Notifier] Restore busy indicator (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16170?vs=46093&id=49060 REVI

D17402: [Device Notifier] Disable the possibility to unmount the root partition

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1a5507bd57a: [Device Notifier] Disable the possibility to unmount the root partition (authored by thsurrel). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17402?vs=47024&id=49038#toc REPOSIT

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. Thanks for this one too ! I forgot to mention this third patch: D16170 :) REPOSITORY R120 Plasma Workspace BRANCH arc_unmountroot (branched from master) REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #

D17127: [Device Notifier] Keep the device label & icon after unmounting

This revision was automatically updated to reflect the committed changes. Closed by commit R120:cb3237987b26: [Device Notifier] Keep the device label & icon after unmounting (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17127?

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel added a comment. Thank you very much for taking a look. If you have a bit of time, I have two other patches about the device notifier that have been waiting for a while: D17402 and D16212 . REPOSITORY R120 P

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel added a comment. This patch fixes a regression that appeared in this cycle, that would be good if someone could review it so that we don't ship it with 5.15. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17127 To: thsurrel, #plasma Cc: filipf, pl

D17874: [dimdisplay] Effectively waits display to wake-up

thsurrel added a comment. Sorry I did not have any time to test this, but I am really interested to see the result. I am back from my holidays now, I should be able to test tomorrow. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D17874 To: anthonyfieroni, mart,

D16918: [dimdisplay] Do not change screen brightness on invalid values

thsurrel added a comment. Neither helped... The problem may not be in plasma. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D16918 To: anthonyfieroni, #plasma, broulik, mart Cc: thsurrel, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, j

D17420: [Device Notifier] Fix action button vertical alignment

This revision was automatically updated to reflect the committed changes. Closed by commit R120:2c541ac87c4d: [Device Notifier] Fix action button vertical alignment (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17420?vs=47080&

D17420: [Device Notifier] Fix action button vertical alignment

thsurrel updated this revision to Diff 47080. thsurrel added a comment. No more magic :( REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17420?vs=47079&id=47080 BRANCH arc_alignment (branched from master) REVISION DETAIL https://phabricator.kd

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. I made another patch that fixes the alignment D17420 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg Cc: abetts, ngraham, broulik, plasma-devel, ragreen, Pitel,

D17420: [Device Notifier] Fix action button vertical alignment

thsurrel created this revision. thsurrel added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH arc_alignment (branched from master) REVISION DETAIL https://phabrica

D17401: [Device Automounter KCM] Improve the tree view header spacing

This revision was automatically updated to reflect the committed changes. Closed by commit R119:66e05cb9c097: [Device Automounter KCM] Improve the tree view header spacing (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17401?vs=4

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. You need to configure the plasmoid and select to show "All devices". It's showing removable devices only by default (which sounds pretty sane!). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma, #vdg Cc:

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel added a comment. Can you develop why ? Is because of the added code ? From a usability point of view, does it not make sense to disable something that is not possible ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17402 To: thsurrel, #plasma,

D17402: [Device Notifier] Disable the possibility to unmount the root partition

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH arc_unmountroot (branched from master) REVISION DETAIL https:/

D17394: [Device Notifier] Fix transition animation

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ab47422c1b41: [Device Notifier] Fix transition animation (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17394?vs=47001&id=47023 RE

D17394: [Device Notifier] Fix transition animation

thsurrel added a comment. In D17394#372523 , @broulik wrote: > Is this Bug 379759? I don't think so, but I will have a look at that one too. If any of you guys can have a look at my other device notifier patches, that would be really

D17394: [Device Notifier] Fix transition animation

thsurrel added inline comments. INLINE COMMENTS > davidedmundson wrote in DeviceItem.qml:197 > alwaysRunToEnd : true That does not work by itself. REPOSITORY R120 Plasma Workspace BRANCH arc_transitions (branched from master) REVISION DETAIL https://phabricator.kde.org/D17394 To: thsur

D17401: [Device Automounter KCM] Improve the tree view header spacing

thsurrel created this revision. thsurrel added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REPOSITORY R119 Plasma Desktop BRANCH arc_automounter_kcm (branched from master) REVISION DETAIL https://phab

D16918: [dimdisplay] Do not change screen brightness on invalid values

thsurrel added a comment. This bug is bothering me too and I haven't found a fix either. I use an external screen connected to my laptop and I turn my laptop screen off by setting its brightness to 0. Then whenever I go away for a moment and the screen is turned off because energy saving ki

D17394: [Device Notifier] Fix transition animation

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY In the specific case of having the device notifier opened and inserting a device that has

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel marked an inline comment as done. thsurrel added inline comments. INLINE COMMENTS > ngraham wrote in devicenotifier.qml:51 > En Anglais, les mots n'utilisent pas la lettre «u» aussi souvent qu'en > Français. :) Je ne savais pas que tu parlais français ! 👍 REPOSITORY R120 Plasma Work

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel marked 2 inline comments as done. thsurrel added inline comments. INLINE COMMENTS > ngraham wrote in devicenotifier.qml:51 > mountedRemouvables -> mountedRemovables (and change all other instances, > obviously) I put too much French into this one ;) REPOSITORY R120 Plasma Workspace

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 46999. thsurrel added a comment. Improvements as per Nate's comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=46939&id=46999 BRANCH arc_unmountall (branched from master) REVISION DETAIL ht

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 46939. thsurrel added a comment. Fix button width REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=43929&id=46939 BRANCH arc_unmountall (branched from master) REVISION DETAIL https://phabricator.k

D17203: [Task Manager] Move apps to activities from the context menu

thsurrel abandoned this revision. thsurrel added a comment. I use it differently then ! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17203 To: thsurrel, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, ab

D17203: [Task Manager] Move apps to activities from the context menu

thsurrel added a comment. Yes, indeed. But it is just a proposal. This patch mimics what is done for desktops: you can move a window to a desktop or to all of them. You lose the ability to add a window to an activity, but do we have a strong use case for that ? I personally always want to _

D17203: [Task Manager] Move apps to activities from the context menu

thsurrel created this revision. thsurrel added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY The task manager context menu offers to _add_ applications to activities, but the main u

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel added a comment. Hi @filipf, thanks for trying that out. I realized that the problem is only present when working with master, the problem appeared with a recent commit. I updated the summary accordingly. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel updated this revision to Diff 46160. thsurrel added a comment. Fix REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17127?vs=46094&id=46160 BRANCH arc_notifier_labels (branched from master) REVISION DETAIL https://phabricator.kde.org/D

D17127: [Device Notifier] Keep the device label & icon after unmounting

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When unmounting a device, the device notifier keeps the information of the device and its ico

D16170: [Device Notifier] Restore busy indicator

thsurrel updated this revision to Diff 46093. thsurrel added a comment. Update the storage size every 5 seconds Thank you for catching this one @mart ! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16170?vs=43513&id=46093 BRANCH arc_busyindic

D15963: [KonsoleProfiles applet] Fix initial focus

This revision was automatically updated to reflect the committed changes. Closed by commit R114:d6ee79f20adb: [KonsoleProfiles applet] Fix initial focus (authored by thsurrel). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15963?vs=42917&id=46092 REVIS

D16053: [Window List]Fix initial focus

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8ff87951cff8: [Window List]Fix initial focus (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16053?vs=43170&id=46091 REVISION DETAIL

D16170: [Device Notifier] Restore busy indicator

thsurrel added a comment. Ping ! Anyone could have a look at this patch ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16170 To: thsurrel, #plasma, #vdg, broulik, bruns Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D16914: [Runners KCM] Focus the search field by default

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. TEST PLAN Start krunner, click on the parameter button on the left. In the window opening, the plugin search b

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. Should I do anything special about this Diff ? Do we just keep it as it is for reference ? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vdg, drosca, ngraham Cc: ngraham, broulik, nicolasfe

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. Absolutely, as said in my previous comment, I agree the usefulness of the OSD in that case is very much questionable. I was raising questions on a different level: - would it be import to be consistent and show an OSD in the jack case if we are showing one in

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. Having a visual feedback would be useful when pairing bluetooth speakers IMO (does it ? I don't have any to test with). For a jack connection, that is indeed less useful, but that would be consistent. In addition, the plasma-pa has an option to turn the OSD off,

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. The speaker icon could maybe get a newer version that would be different than the one used to show the volume level ? It does also look a bit unpolished compared to the headphone one. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricat

D16170: [Device Notifier] Restore busy indicator

thsurrel added a comment. It is awaiting a review. As I said in an older comment, I don't know if there are some drawbacks to not do polling, but i have been using this patch for a while and it works well. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. In D16082#356109 , @drosca wrote: > What do you mean with "sink change"? Do you mean that plugging in something in jack will trigger adding new sink (device) to Pulseaudio? That will only be the case for USB headphones,

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. So, it seems that pulseaudio can not tell the difference what we are plugging in the jack connector on a laptop, but I guess it must be the same behavior with computers that get a sink change when switching from internal speaker to external ? REPOSITORY R115 Plas

D16082: Notify headphone being plugged in on some hardware

thsurrel added a comment. I should be able to test that tonight. But what happens today on a computer that does a _sink change_ (and not a port change like on my computer) when plugging in speakers in a laptop jack connector ? Can it tell it is not headphones ? Anybody could try that ?

D16082: Notify headphone being plugged in on some hardware

thsurrel marked 5 inline comments as done. thsurrel added a comment. Ping ! Anybody else managed to test this ? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D16082 To: thsurrel, #plasma, #vdg, drosca Cc: broulik, nicolasfella, plasma-devel, rag

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel updated this revision to Diff 43929. thsurrel added a comment. Add a text label to the new button Fixes to hide the button correctly when devices unmount REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16212?vs=43624&id=43929 BRANCH ar

D16219: [Lock Screen] Do not try to unlock when unvisible

This revision was automatically updated to reflect the committed changes. Closed by commit R120:754efdedd4ee: [Lock Screen] Do not try to unlock when unvisible (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16219?vs=43792&id=43

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel updated this revision to Diff 43792. thsurrel added a comment. Do not access parent property directly Thanks for the comment davidedmundson REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16219?vs=43644&id=43792 BRANCH arc_enterpressed

D16241: [Folder View] Improve layout and formatting of Icons page

thsurrel added a comment. That looks much better! Any reason why the "Text lines" parameter in the Icon panel is not aligned with the rest of the form ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16241 To: ngraham, #plasma, #vdg, hein Cc: thsurrel, pla

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel added a comment. The bug is https://bugs.kde.org/show_bug.cgi?id=395671 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16219 To: thsurrel, #plasma, #vdg Cc: davidedmundson, abetts, filipf, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moh

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel added a comment. In D16219#343399 , @filipf wrote: > The new lock screen runs the risk of adding extra steps for the user. This is one change that can help the issue because IIRC in Windows you also have a double lock screen and pressin

D16219: [Lock Screen] Do not try to unlock when unvisible

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY In the lock screen, pressing the enter key while the UI is not yet visible ends up trying

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. F6330071: screenshot2.png F6330070: screenshot1.png Visually, I find it better with the label: two similar icons do not end up in the same area. REPOSITORY R120 Plasma Workspace

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel added a comment. What wording do you think would fit ? It seems quite some effort has been put in avoiding the work "mount". I am also a bit scared of the size the button would take in some languages and if it could collide with "Storage Volume". But maybe it should be somewhere e

D16212: [Device Notifier] Add a button to unmount all devices

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When at least one removable device is mounted, a button shows up that will allow to unmou

D16170: [Device Notifier] Restore busy indicator

thsurrel added a comment. The bad news with this patch is that I don't understand it fully. Why were we doing polling before ? Why was it breaking the 'state' propagation ? What does it change not to do it anymore (performance hit ? something else ?) ? REPOSITORY R120 Plasma Workspace R

D16170: [Device Notifier] Restore busy indicator

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY This patch fixes two issues: - the 'state' of the device now propagates correctly, tha

D15840: [Folder View] Remember selected item when navigating in subfolders

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6736bdaa4bbd: [Folder View] Remember selected item when navigating in subfolders (authored by thsurrel). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15840

D16082: Notify headphone being plugged in on some hardware

thsurrel updated this revision to Diff 43271. thsurrel added a comment. Fixes as per broulik comments. Thanks for the review! REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16082?vs=43237&id=43271 BRANCH arc_ports (branched from mast

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 43266. thsurrel added a comment. I'm not sure how I managed to lose this bit when preparing this. Thanks for your patience, hein, I have been doing a pretty poor job on this patch. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://p

D16082: Notify headphone being plugged in on some hardware

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY On my computer, plugging the headphones in and out does not create a sink change but only

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 43190. thsurrel added a comment. Use gridView.visibleArea REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15840?vs=43158&id=43190 BRANCH arc_folderview3 (branched from master) REVISION DETAIL https://phabri

D16053: Fix initial focus

thsurrel created this revision. thsurrel added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY Now arrow key nav works when opening a panel applet via keyboard shortcut. Fixes the same p

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 43158. thsurrel added a comment. Limit index and position to the current gridview state, in case some elements have disappeared since we visited the parent folder. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org

D16045: [Device Notifier] Auto-hide popup after device is unmounted

This revision was automatically updated to reflect the committed changes. Closed by commit R120:581889351e09: [Device Notifier] Auto-hide popup after device is unmounted (authored by thsurrel). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16045?vs=4

D16045: [Device Notifier] Auto-hide popup after device is unmounted

thsurrel updated this revision to Diff 43133. thsurrel added a comment. Fix as per broulik comments. Thanks! REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16045?vs=43129&id=43133 BRANCH arc_autohide (branched from master) REVISION DETAIL htt

D16045: [Device Notifier] Auto-hide popup after device is unmounted

thsurrel created this revision. thsurrel added reviewers: Plasma, VDG, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision. REVISION SUMMARY When unmounting a removable device from dolphin, the device notifier will popup

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel added a comment. In D15840#337446 , @hein wrote: > I like the goal here, but it's not a given the stored index is still valid when navigating back - the folder contents could have changed. It'd be hygienic to bound the access when poppi

D15840: [Folder View] Remember selected item when navigating in subfolders

thsurrel updated this revision to Diff 42966. thsurrel added a comment. Pop all history info at once when navigating back REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15840?vs=42624&id=42966 BRANCH arc_folderview3 (branched from master) REVISIO

  1   2   >