thsurrel added a comment.

  In D15840#337446 <https://phabricator.kde.org/D15840#337446>, @hein wrote:
  
  > I like the goal here, but it's not a given the stored index is still valid 
when navigating back - the folder contents could have changed. It'd be hygienic 
to bound the access when popping from the history.
  
  
  Thanks for the review. I don't know if the modifications I just made 
correspond to what you had in mind.
  But I tested both cases where A/ one of the parent folder we were into is 
deleted, in that case navigating back displays a message that this folder does 
not exist anymore, and B/ that the content of the folder changes. In case B, 
the Y position we are moving to might be incorrect if lots of files we added 
before. But I don't know what to do about that, and if it is worth the trouble 
... :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15840

To: thsurrel, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to