thsurrel created this revision. thsurrel added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. thsurrel requested review of this revision.
REVISION SUMMARY Commit 17380886 <https://phabricator.kde.org/R120:17380886d9b8d0437544125e5fdc406ad6c5d1c3> in the devicenotifications data engine brought in two problems with the Device Notifier: - the notifications are now cleared once a device is unmounted, this results in the "You can now safely remove this device" message not to be shown anymore. - since each notification is no longer its own data source, it is possible to get into a situation where one device would only receive a first notification but not any subsequent ones. This patch attempts to fix these two problems. TEST PLAN Mount a removable device and unmount it through the Device Notifier. A message should appear for a few seconds saying you can safely remove that device. REPOSITORY R120 Plasma Workspace BRANCH arc_removed_devices REVISION DETAIL https://phabricator.kde.org/D19796 AFFECTED FILES applets/devicenotifier/package/contents/ui/DeviceItem.qml applets/devicenotifier/package/contents/ui/FullRepresentation.qml applets/devicenotifier/package/contents/ui/devicenotifier.qml To: thsurrel, #plasma, broulik Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
