Re: Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Ryan Bitanga
------ On 2010-06-22 11:47:11, Ryan Bitanga wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/4440/ > ---

Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4440/ --- Review request for Plasma. Summary --- This patch adds oauth support for th

Re: Review Request: Twitter OAuth support for microblog dataengine

2010-06-22 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/4440/ --- (Updated 2010-06-22 11:47:11.665544) Review request for Plasma. Summary --

Re: Review Request: Window runner to switch windows and desktops

2009-07-28 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1828 --- Looks good :) trunk/KDE/kdebase/workspace/plasma/runners/windows/win

Re: Review Request: Allow runners to do quick prepare and teardown for match sessions

2009-07-27 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1133/#review1808 --- Ship it! I like the concept. I can't think of better names for the me

Re: Review Request: Window runner to switch windows and desktops

2009-07-26 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1788 --- trunk/KDE/kdebase/workspace/plasma/runners/windows/windowsrunner.cpp

Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-25 Thread Ryan Bitanga
es. maybe it should be added to > > plasma.h instead? > > Ryan Bitanga wrote: > I couldn't think of any other use case so I opted to keep it as a > protected function of AbstractRunner. I'm not sure having a public function > for retrieving a list of actions would be

Re: Review Request: Multiple actions support for Nepomuk Search Runner

2009-07-25 Thread Ryan Bitanga
-------- On 2009-07-25 04:50:49, Ryan Bitanga wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/689/ > -

Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-24 Thread Ryan Bitanga
hink of another use for it, we could move it to plasma.h - Ryan --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/#review1760 ---------

Re: Review Request: Multiple actions support for Nepomuk Search Runner

2009-07-24 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/689/ --- (Updated 2009-07-25 04:50:49.249665) Review request for Plasma. Changes ---

Re: Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-24 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/ --- (Updated 2009-07-25 01:24:26.349811) Review request for Plasma. Changes --

Review Request: Allow AbstractRunner to parse QMenus for actions

2009-07-24 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1115/ --- Review request for Plasma. Summary --- This adds a convenience method to Ab

Re: Review Request: Window runner to switch windows and desktops

2009-07-24 Thread Ryan Bitanga
> On 2009-07-24 12:06:13, Ryan Bitanga wrote: > > When displaying a matching window, I think it would be better to display > > the icon of the window itself and not a generic icon for all matches just > > like what the windows runner in playground does. > > > &g

Re: Review Request: Window runner to switch windows and desktops

2009-07-24 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1114/#review1732 --- When displaying a matching window, I think it would be better to displ

Review Request: Support for replies and direct messages in microblog dataengine

2009-07-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1007/ --- Review request for Plasma. Summary --- This adds support for obtaining repl

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- (Updated 2009-05-13 10:52:19.305291) Review request for Plasma. Changes ---

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- (Updated 2009-05-13 10:17:27.601695) Review request for Plasma. Changes ---

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- (Updated 2009-05-13 10:11:27.207850) Review request for Plasma. Changes ---

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
ply, visit: http://reviewboard.kde.org/r/694/#review1107 ------- On 2009-05-13 07:13:18, Ryan Bitanga wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/694/ > ---

Re: Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- (Updated 2009-05-13 07:13:18.590840) Review request for Plasma. Summary (update

Review Request: Adaptive Search for KRunner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/694/ --- Review request for Plasma. Summary --- This enables adaptive search for KRun

Review Request: Multiple actions support for Nepomuk Search Runner

2009-05-13 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/689/ --- Review request for Plasma. Summary --- Reposting patch for multiple actions

Review Request: Time based queue policy for slow speed runners

2009-02-08 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/41/ --- Review request for Plasma. Summary --- Reposting the patch from a couple of w

Re: Review Request: Default queue policy for normal speed runners

2009-01-19 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/338/ --- (Updated 2009-01-19 21:51:15.407302) Review request for Plasma. Summary -

Review Request: Default queue policy for normal speed runners

2009-01-19 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/338/ --- Review request for Plasma. Summary --- This patch revives the original

Review Request: Libkonq support for the nepomuk search runner

2009-01-17 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/334/ --- Review request for Plasma. Summary --- This is a two month old patch t

Re: Review Request: Multiple action support for KRunner

2008-11-03 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/178/ --- (Updated 2008-11-03 03:39:51.296708) Review request for Plasma. Summary -

Review Request: QuickSand - KRunner Integration

2008-11-03 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/252/ --- Review request for Plasma. Summary --- The patch integrates QuickSand

Re: Review Request: Multiple action support for KRunner

2008-09-17 Thread Ryan Bitanga
e constructor will be used > > (think of multiple kickoff applets, for instance?); perhaps the apidox > > should be altered to make self() sound less required =) :) - Ryan --- This is an automatically generated e-mai

Re: Review Request: Multiple action support for KRunner

2008-09-17 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/178/ --- (Updated 2008-09-17 02:11:27.950696) Review request for Plasma. Summary -

Re: Review Request: Multiple action support for KRunner

2008-09-08 Thread Ryan Bitanga
nough? why the additional internal > > iterator? slightly dangerous if actions are removed as well, i'd imagine > > (either way, but more so with the internal iterator) Well actions aren't supposed to be removed until a runner is unloaded. That means that the

Re: Review Request: Multiple action support for KRunner

2008-09-08 Thread Ryan Bitanga
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.vidsolbach.de/r/178/ --- (Updated 2008-09-08 04:52:02.917524) Review request for Plasma. Summary -