> On 2009-07-25 06:02:09, Aaron Seigo wrote: > > looks ok, and yes the camel case includes should be added.
forgot to update the description. added the camel case includes shortly before 4.3 was branched. hehe > On 2009-07-25 06:02:09, Aaron Seigo wrote: > > trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.cpp, > > line 79 > > <http://reviewboard.kde.org/r/689/diff/2/?file=9024#file9024line79> > > > > is this actually needed? shouldn't the catalog be automatically loaded? Most of this code is 10 months old and carried over from a time we manually added the catalogs. Took it out just now :) - Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/689/#review1764 ----------------------------------------------------------- On 2009-07-25 04:50:49, Ryan Bitanga wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/689/ > ----------------------------------------------------------- > > (Updated 2009-07-25 04:50:49) > > > Review request for Plasma. > > > Summary > ------- > > Reposting patch for multiple actions support for the Nepomuk search runner. > It adds open with and service menu actions to the nepomuk search runner. > > Now uses the new KFileItemActions and KFileItemListProperties and no longer > depends on libkonq. > > Minor style issue: the two new classes in KIO don't have camel case includes > yet, and I wasn't sure if I should add them myself. > > Another possible point for improvement: move the parseMenu method to > AbstractRunner as something like an addActionsFromMenu method to reuse code > between runners (useful for the locations runner and the window management > runner which I'm thinking of moving into kdereview) > > > Diffs > ----- > > > trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.h > 999602 > > trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.cpp > 999602 > > trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/queryclientwrapper.cpp > 999602 > > Diff: http://reviewboard.kde.org/r/689/diff > > > Testing > ------- > > > Thanks, > > Ryan > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
