----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/689/ -----------------------------------------------------------
(Updated 2009-07-25 04:50:49.249665) Review request for Plasma. Changes ------- Update to use the convenience method for extracting actions from menus in AbstractRunner Summary ------- Reposting patch for multiple actions support for the Nepomuk search runner. It adds open with and service menu actions to the nepomuk search runner. Now uses the new KFileItemActions and KFileItemListProperties and no longer depends on libkonq. Minor style issue: the two new classes in KIO don't have camel case includes yet, and I wasn't sure if I should add them myself. Another possible point for improvement: move the parseMenu method to AbstractRunner as something like an addActionsFromMenu method to reuse code between runners (useful for the locations runner and the window management runner which I'm thinking of moving into kdereview) Diffs (updated) ----- trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.h 999602 trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/nepomuksearchrunner.cpp 999602 trunk/KDE/kdebase/workspace/plasma/runners/nepomuksearch/queryclientwrapper.cpp 999602 Diff: http://reviewboard.kde.org/r/689/diff Testing ------- Thanks, Ryan _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
