D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#392659 , @ngraham wrote: > After much discussion in the #VDG room, we decided to put this on hold and revisit it for 5.16. The problem here is that we're worried that this c

D18206: Improve the Look and Feel KCM

rooty added a comment. +1 from me if you want you could drop the article by the way and make it "Choose Look and Feel theme" it's like "Configure Network Settings" vs "Configure the Network Settings" REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18206 T

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#391560 , @ngraham wrote: > I believe you'll need to file a sysadmin ticket to get that changed. Will do! Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#391371 , @davidedmundson wrote: > @rooty if you want to re-apply for a commit account, I'll approve it. Thank you you guys! One problem though - I used an alias (Pete Cho) on identity.kde.org, but i'd lik

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49230. rooty added a comment. Use units.smallSpacing for padding consistently except when bodyText.lineCount > 1, spruce things up REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49209&id=49230 BRANCH

D17975: [Notifications] Add padding to notifications

rooty added a comment. You were right! Thank you so much, it was so much easier when I started thinking about it as a math problem rather than a design problem. I'm going to upload another diff, I hope this one stands up to scrutiny. I apologize for the very long "implicitHeight" but it

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49209. rooty added a comment. Fix lower border cutoff for fonts > 10 pt REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49208&id=49209 BRANCH master REVISION DETAIL https://phabricator.kde.org/D1797

D17975: [Notifications] Add padding to notifications

rooty added a comment. >> How do we get the icon size to increase in proportion to increasing font size > > See units.cpp in plasma-framework. It's complex. I don't think that's a relevant topic you need to go down Yeah, also I'm not sure it's the right approach - icons might

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49208. rooty added a comment. Correct padding with just icon + heading + no text, make icon padding even for 10 pt sized fonts other than Noto Sans REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49132&i

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#391008 , @filipf wrote: > ^ Yes, it's important to note that additional (and unwanted) padding underneath the icon can happen with master, while this patch can add the same above the icon. From my layman's unders

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#390875 , @ngraham wrote: > With this patch: F6539252: With patch.png TLDR: Yup, but that's only **the tip of the iceberg** (of the problems that plague //both master

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#390336 , @rooty wrote: > Is there a way to give the icon itself padding? I've been using anchors but there's nothing I can think of to anchor it to? If I anchor it to the notification text in any way, I can add a

D17975: [Notifications] Add padding to notifications

rooty added a comment. There is one small problem, with almost every version I've submitted so far. The padding above the icon and below the icon is the same (7 px with 1x scaling) if Noto Sans is used as the default font, which is basically perfect. However, if another font is used, th

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49132. rooty added a comment. Remove unnecessary comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49131&id=49132 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 AFFECTED FI

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49131. rooty added a comment. Use margin in bottomPart instead REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=49110&id=49131 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 AFFECT

D18147: Change certain integers to decimals for even padding; fix uneven padding with heading only notifications

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D18147 AFFECTED FILES applets/notifications/package/c

D17975: [Notifications] Add padding to notifications

rooty added a comment. Hey @davidedmundson I know I'm a little late but should I use your suggestion instead? I just figured out how to do it using Layout.bottomMargin :D REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg

D17975: [Notifications] Add padding to notifications

rooty updated this revision to Diff 49110. rooty added a comment. Change certain integers to decimals for more even padding; fix padding in heading-only notifications REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48943&id=49110 BRANCH

D17975: [Notifications] Add padding to notifications

rooty added a comment. @broulik If the consensus is that the notifications should stay "tight" (no padding), I'd very much prefer to add padding to the left and right of the icon (it's really stuck-on right now), and to push the notification icon down a bit if there's a bodyText.lineCount >

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389760 , @filipf wrote: > FWIW if I backport the spacings and margins prior to D3560 it works great for me. The symmetry around the icon is better than with this diff. (only No

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389695 , @broulik wrote: > We explicitly removed the padding in Plasma 5.9 to reduce popup sizes, this effectively reverts this decision… Sort of. This is basically what they looked like: F6537353: image

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389613 , @davidedmundson wrote: > BTW, if you want a neater solution: (though consider this optional) > Instead, use Layout.topMargin on the titleBar and Layout.bottomMargin on the lowerPart. I love it

D17975: [Notifications] Add padding to notifications

rooty added a comment. > I wouldn't want the attitude of "breaking other themes is unfortunate, but.." becoming a pattern because openness to customization is our main selling point. You've made your point. But allow me to flesh it out - it seems we've reached an impasse; in simple ter

D17975: [Notifications] Add padding to notifications

rooty added a comment. @davidedmundson I've tried using implicitHeight: Math.max(appIconItem.valid || imageItem.nativeWidth > 0 ? units.iconSizes.large : 0, (mainLayout.height + ((bodyText.lineCount > 1) ? 0.5 : ((bodyText.lineCount == 0) ? 0 : 2) * units.smallSpacing))) // Add units.

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389580 , @filipf wrote > I'd much rather if there was some padding added in Breeze and then you only fix the wrong spacing to right of the notification. Even if that wouldn't work, I don't get the sense we've ful

D17975: [Notifications] Add padding to notifications

rooty added a comment. In D17975#389567 , @Codezela wrote: > why every notification width is too wide > why its not resize depends on the content on it with some little padding what do you mean? the width of the entire notification? RE

D17975: [Notifications] Add padding to notifications

rooty added a comment. > Wouldn't it be better to somehow add padding globally? Not really feasible because you don't necessarily want padding everywhere (for example, Adapta does this and i think it looks unsightly) F6536644: adapta-popup.png Ad

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. In D17975#389443 , @ngraham wrote: > This is no longer WIP, right? Oh so I can rename it? Sure! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17975 To: rooty, #vdg, #plasma, ngr

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

rooty added a comment. wow scrolling down took a while haha sure fine with me, crop em (except for Lake Bled?) REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc: mart, rooty, plasma-devel, kvanton, jraleigh, GB_2,

D18019: [Digital Clock] Add ability to set a custom date format string

rooty added a comment. a thousand times yes... this is amazing REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18019 To: Zren, #plasma, #vdg Cc: rooty, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. In D17975#388788 , @ngraham wrote: > Could you update the images in the Summary section instead of posting new ones in comments? The visual history of the patch is not really important to preserve, and having the images on

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. I removed "0.75 * units.smallSpacing" because it's not an integer - the result is that the margins are slightly uneven, but considering they weren't ever entirely even, and the difference between the margins gets more pronounced with increasing font size (and scaling f

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48943. rooty added a comment. Use integers/halves and line counts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48711&id=48943 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17975 AFF

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. Hey guys, I feel silly asking this but I'm using a different computer right now - how do I get this computer's arcanist to lock onto and update this diff (instead of creating an entirely new diff...)? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabri

D18087: Use integers or halves, and correct for text margins using line count

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REPOSITORY R120 Plasma Workspace BRANCH notification-padding (branched from master) REVISION DETAIL https://phabricator.kde.org/D18087 AFFECTED FI

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

rooty added a comment. Still not sure if we should have also included the grassland F6507127: jean-pierre-brungs-103087-unsplash.jpg REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg

D18048: [Connections] Add search ellipsis to network connection search

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds an ellipsis to the search function in Connections / System Settings. REPOSITORY R116 Plasma Network Management Apple

D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds an ellipsis to the filter and search labels in Font Management and Date and Time. REPOSITORY R119 Plasma Desktop BR

D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch renames the label "Find file type or filename pattern" to "Search for file type or filename pattern..." REPOSITORY R126 K

D17906: [kirigami] Do not use light font styles for headings (2/3)

rooty added a comment. In D17906#388052 , @mart wrote: > can we still keep as light the first level of heading, which is huge (and use that sparsingly) and go to levels from 2 onwards where needed smaller and bigger? nope, very much agai

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. @davidedmundson Is there anything I can put in the code to get the icons to scale properly? this is a screenshot of master (not this patch): F6529598: image.png I've tried multiplying units.iconSizes.large by the scaling f

D17975: [WIP, Notifications] Add padding to notifications

rooty marked an inline comment as done. rooty added a comment. In D17975#386685 , @ngraham wrote: > A bit more padding is good! > > 1. Making this pixel-perfect with every combination of font and font size is going to be impossible sadly. Wit

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48711. rooty added a comment. Change shift in height of notification to an integer REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48709&id=48711 BRANCH notification-padding (branched from master) REV

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. In D17975#386665 , @ngraham wrote: > Can you clarify what the ultimate visual goal here? Clearly defining that might help to tighten up your code and thought process. > > Also, what remaining issues make this WIP? I fin

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48709. rooty added a comment. Add margins to the right of the buttons on the right border REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48708&id=48709 BRANCH notification-padding (branched from maste

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. Okay, so I figured out how to add padding to the buttons as well, by adding a right margin to the mainLayout part (hence the deleted comment describing how I couldn't figure it out, my bad): F6525782: before-n-after.png REPOS

D17975: [WIP, Notifications] Add padding to notifications

rooty added a comment. Hey so I'd also like for the Open... (image three in each set) button to shift by one units.smallSpacing to the left. The close button does, if I add "rightMargin: units.smallSpacing" into ColumnLayout / mainLayout, but the Open... button doesn't. I just don't kn

D17975: [WIP, Notifications] Add padding to notifications

rooty updated this revision to Diff 48708. rooty added a comment. Correct spelling REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17975?vs=48707&id=48708 BRANCH notification-padding (branched from master) REVISION DETAIL https://phabricator.k

D17975: [WIP, Notifications] Add padding to notifications

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch aims to add padding to the notification widget and fully remedy the issues that arise once it is applied. TEST PLAN [Comi

D17934: [Kickoff] Increase Kickoff information label readability

rooty updated this revision to Diff 48644. rooty added a comment. Roll back vertical alignment change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17934?vs=48578&id=48644 BRANCH centered-infolabel (branched from master) REVISION DETAIL https:

D17023: [Kickoff] Change search label and username font size

rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17023 To: rooty, romangg, ngraham Cc: mart, filipf, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty abandoned this revision. rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17022 To: rooty, ngraham, romangg Cc: filipf, abetts, davidedmundson, plasma-devel,

D17935: [Clipboard] Use ellipsis in the search field label ('Search...' instead of 'Search')

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch adds the ellipsis (...) to the search field label in Clipboard so as to make it consistent with the labels in Kickoff, Kicke

D17023: [Kickoff] Change search label and username font size

rooty abandoned this revision. rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17023 To: rooty, romangg, ngraham Cc: mart, filipf, plasma-devel, GB_2, ragreen, Pi

D17934: [Kickoff] Increase Kickoff information label readability

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch vertically centers the information label (infolabel) that appears once a user hovers/runs over their username with their m

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17022 To: rooty, ngraham, romangg Cc: filipf, abetts, davidedmundson, plasma-devel, GB_2, ragreen, Pitel, ZrenBot

D16988: [Kickoff] Make the visible search field unfocused by default

rooty abandoned this revision. rooty added a comment. Seeing as this causes the latest plasmashell to lock up and I was never too enthusiastic about the change either, I'm going to close this, sorry guys. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988

D17020: [Kickoff] Reenable hover to show system information

rooty abandoned this revision. rooty added a comment. Abandoned because of parent (D16988 ). REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17020 To: rooty, ngraham, romangg Cc: filipf, plasma-devel, GB_2, ragreen, Pitel, Z

D17916: [Login and lock screens] Do not use light font styles for the sddm clock

rooty updated this revision to Diff 48534. rooty added a comment. Apply patch to login theme as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17916?vs=48531&id=48534 BRANCH normal-fonts-lckscrclock (branched from master) REVISION DETAIL

D17916: [Login and lock screens] Do not use light font styles for the sddm clock

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch removes the line of code that required that the lock screen use a light font style. This patch is also closely related to

D17598: Improve "No internet connection!" error message

rooty added a comment. it might work on the left, but i think this is better because it takes up the entire pane, and is important enough to warrant doing so for example, F6517329: image.png F6517334: image.png

D17598: Improve "No internet connection!" error message

rooty added a comment. loving the icon, it really stresses the importance of checking whether your internet connection's working without being (too) imposing REPOSITORY R134 Discover Software Store BRANCH better-no-connectivity-error-message (branched from master) REVISION DETAIL http

D17615: [FolderView] Fix blurry icon labels

rooty added a comment. my bad, i just didn't copy the entire contents of the plasma-desktop/containments/desktop/package/contents/ui/code folder off of github (just the FolderItemDelegate.qml), it works fine now that it's all up to date REPOSITORY R119 Plasma Desktop REVISION DETAIL ht

D17615: [FolderView] Fix blurry icon labels

rooty added a comment. yup i rename it and it turns all blurry, irrespective of where the panel is or how much the icons have been selected / moved around REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17615 To: filipf, #plasma Cc: rooty, plasma-devel, GB_2,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. > That's not a feature we have; the wallpapers of the lock screen, login screen, and desktops are all independent. Whether or not this is desirable is an entirely different issue, but operating with the limitation of not having that, there is no point to a "mild blur"

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. so i take it you're open to the idea of an unobtrusive type of blur? i get that you want to preserve the wallpaper, but sometimes it really does get in the way (snow, mountains, clouds, etc.) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kd

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#368991 , @ngraham wrote: > You have two options: > > - Stop insulting people and their work > - Go away naaate you're taking all of this way too personally first of all,, @raddison's got a valid poi

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#367971 , @filipf wrote: > In D16988#367970 , @rooty wrote: > > > Suffice it to say, you can't use any of the other patches (except the font size / label change) witho

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#366146 , @ngraham wrote: > D17020 , D17022 , and D17023 still include duplicated changes from this pat

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

rooty added a comment. In D16879#362527 , @ngraham wrote: > IMHO spread 0.1 doesn't provide enough contrast against the toughest backgrounds: > > F6432627: Screenshot_20181119_124804.png ouch yo

D17023: [Kickoff] Change search label and username font size

rooty updated this revision to Diff 45869. rooty added a comment. - Remove (duplicated) code shared with D17020 and D17022 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1702

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty updated this revision to Diff 45868. rooty added a comment. - Remove duplicated code common to D17020 , D17022 and D17023 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST

D17022: [Kickoff] Enable Esc to close Kickoff and Tab to switch to Search

rooty added a comment. In D17022#362813 , @davidedmundson wrote: > I appreciate the effort to split up a big commit, but this isn't quite right. > > There's duplicated code changes both here and in https://phabricator.kde.org/D17020

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362808 , @broulik wrote: > > The notifications widget also forces NativeRendering in one of its components rather than leave it open for discussion. > > It does because it's using a `TextEdit` directly to make

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. In D17034#362786 , @hein wrote: > This isn't an acceptable patch, sorry - we can't just randomly sprinkle a different font rasterizer into the UI. The rasterization should be consistent throughout the system and consistent

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. (LOL I accidentally removed the comment) NativeRendering really is the gift that keeps on giving. F6432908: nativerendering.png QtRendering renders a lot better. F6432910: qtrendering.png

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. NativeRendering truly is the gift that keeps on giving F6432893: nativerendering.png This is what happens if I specify that JobDetailsItem.qml use QtRendering F6432899: qtrendering.png RE

D17034: [Kickoff] Fix bad kerning in tab labels

rooty added a comment. this has been bugging me/us for years, glad you finally decided to patch it :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17034 To: filipf, ngraham, #vdg, #plasma Cc: rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-moh

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#362635 , @ngraham wrote: > In D16031#362634 , @rooty wrote: > > > Another fair point: Why not just pick an image that doesn't really interfere with the boxes and icon

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. In D16031#362566 , @ngraham wrote: > Thing is, if we're going to reduce the blur that much, why not just show the original image? That's a fair point. Another fair point: Why not just pick an image that doesn't re

D17023: [Kickoff] Depends on D16988, Change search label and username font size

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY Included commits in branch kickoff-visible-and-unfocused-fonts-type: 78eb4b0d4e08 [Kickoff] Depends on D16988

D17022: [Kickoff] Depends on D16988, Enable Esc to close Kickoff and Tab to switch to Search

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY #Summary: #Test Plan: #Subscribers: 1. NEW DIFFERENTIAL REVISION 2. Describe the changes in this new revision. # I

D17020: [Kickoff] Depends on D16988, Reenable hover to show system information

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch reenables the mouseover to show system information function introduced by Nate Graham and tailors it to D16988

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45820. rooty added a comment. - [Kickoff] Make search field unfocused but visible REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45757&id=45820 BRANCH kickoff-visible-and-unfocused (branched from master

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. Thanks! Ironically, I do like it focused too 🤣 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D16988 To: rooty, #plasma, #vdg, romangg, ngraham, davidedmundson Cc: abetts, gladhorn, chempfling, filipf, plasma-devel, ragreen, Pitel,

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > You can do this as you see fit. I would recommend though in this case to make a patch series where patches depend on each other since otherwise it can become difficult to keep all the independent patches consistent with each other. Excellent. > I believe in

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#362281 , @romangg wrote: > I like all the changes, but they should go into separate patches: Patches that would patch this patch or patches that would each patch master separately? REPOSITORY R119 Plasm

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Why does it make it easy? Sorry I have no idea what I was thinking when I wrote that. It doesn't. (I think my point was that it works regardless of the focus being drawn away from it?) > - By default search field looks unactivated but has focus. Arrow up/dow

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

rooty added a comment. my real name is Kresimir Cohar, email address: kco...@gmail.com thanks you guys :D i just realized i have a pseudonym on kde identity... i might have to fix that REPOSITORY R119 Plasma Desktop BRANCH kickoff-leaner-separators (branched from master) REVISION

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#362206 , @chempfling wrote: > In D16988#362160 , @rooty wrote: > > > Okay so from what I can tell: > > > > (1) Kicker takes the focus off the search field when yo

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. Okay so from what I can tell: (1) Kicker takes the focus off the search field when you go through the results by either mouse or keyboard. This makes it easy to go back to the search field by typing or using the arrow keys (to add more words etc.) (2) Krunner bec

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. @gladhorn More food for though, by the way: in this patch (and the master) the search field is focused while searching and while navigating the search results - it still accepts input even though you've technically navigated away from it. Should this functionality be k

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Actually this sounds like it might help our cause. Especially when the search bar can be tabbed into, that's really nice. The problem is that we would like to focus to be on the selected item, such as the one that gets launched when pressing enter. The search should

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

rooty added a comment. People have been complaining about the blur, but is it necessary to do away with it, or is it a better idea to run with it like they do in Windows Fluent Design (Deepin too actually)? F6431816: image.png This theme, for exam

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > Right, I agree. In fact, that's how Kicker does it: the search field is focused by default, but if you mouse over a list item, then focus visually moves to the list. I'm supportive of doing that sort of thing here. Then the Kicker and Kickoff search fields would even

D16937: [Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. > And I'm afraid I don't think we can do #1. @chempfling and @gladhorn have been working hard to push on accessibility, and one thing I've learned in the past week weeks is how important focus is. Making sure that the active element both has and looks like it has focus

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45757. rooty added a comment. - Trim unnecessary code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45753&id=45757 BRANCH kickoff-visible-and-unfocused (branched from master) REVISION DETAIL https:/

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45753. rooty added a comment. - Fix broken states and return ability to hover REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45751&id=45753 BRANCH kickoff-visible-and-unfocused (branched from master) R

D16988: [Kickoff] Make the visible search field unfocused by default

rooty updated this revision to Diff 45751. rooty added a comment. - Tidy up some more REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16988?vs=45750&id=45751 BRANCH kickoff-visible-and-unfocused (branched from master) REVISION DETAIL https://pha

  1   2   >