D17039: ASAN: Fix leak in KAStatsFavoritesModel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7f83492a654c: ASAN: Fix leak in KAStatsFavoritesModel (authored by kfunk). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17039?vs=45867&id=46246 REVISION D

D17039: ASAN: Fix leak in KAStatsFavoritesModel

kfunk added a comment. I think the `QSharedPointer` overhead is very much negligible in this case here. And doesn't require refactoring of the original code. This is not performance sensitive code (compared to the costs of the QAIM-modifications), no? If you think the memory leak can be

D17039: ASAN: Fix leak in KAStatsFavoritesModel

kfunk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kfunk requested review of this revision. REVISION SUMMARY Trace: Direct leak of 336 byte(s) in 6 object(s) allocated from: #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel

D17025: Perf: Do expensive regexp construction earlier

This revision was automatically updated to reflect the committed changes. kfunk marked an inline comment as done. Closed by commit R120:a46179d9497a: Perf: Do expensive regexp construction earlier (authored by kfunk). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabric

D17025: Perf: Do expensive regexp construction earlier

kfunk marked an inline comment as done. kfunk added inline comments. INLINE COMMENTS > apol wrote in systemtray.cpp:88 > Shouldn't we prefer QRegularExpression? Thought the same, but the new QRegularExpression doesn't allow wildcard matching. REPOSITORY R120 Plasma Workspace BRANCH master

D17032: Fix a few memory leaksASAN: Fix leak in XWindowTasksModel

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e2ba40a4912a: Fix a few memory leaks (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17032?vs=45850&id=45854#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDAT

D17032: Fix a few memory leaksASAN: Fix leak in XWindowTasksModel

kfunk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kfunk requested review of this revision. REVISION SUMMARY Trace: Direct leak of 24 byte(s) in 3 object(s) allocated from: #0 0x544cc0 in operator new(unsigned long) (/home/kfunk/devel/

D17025: Perf: Do expensive regexp construction earlier

kfunk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kfunk requested review of this revision. REVISION SUMMARY SystemTray::serviceRegistered is called tons of times; the regexp construction inside the for-loop is expensive and should be avoided.

D15429: Simplify cmake code: link to Qt5::GuiPrivate.

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. I think that makes sense. +1. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH Plasma/5.13 REVISION DETAIL https://phabricator.kde.org/D15429 To: dfaure, kfunk, kosseb

Re: vnc client keyboard mapping

a Linux system. (see https://github.com/TigerVNC/tigervnc/releases) Regards, Kevin > Is it supported in KDE plasma (that works fine in other systems.) > > Regards, > > S.Ancelot -- Kevin Funk | kf...@kde.org | http://kfunk.org signature.asc Description: This is a digitally signed message part.

D8307: Make Qt5::X11Extras really optional

This revision was automatically updated to reflect the committed changes. Closed by commit R871:c50470387510: Make Qt5::X11Extras really optional (authored by kfunk). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8307?vs=20787&id=20804 REVISION DETAIL http

D8308: macOS: Don't create bundles for test executables

This revision was automatically updated to reflect the committed changes. Closed by commit R871:c8dbb830aace: macOS: Don't create bundles for test executables (authored by kfunk). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8308?vs=20788&id=20803 REVISION

D8308: macOS: Don't create bundles for test executables

kfunk added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:7 > Maybe we could assume tests are non_gui by default? `ecm_add_test(...)` does that. `ecm_mark_as_test(...)` doesn't. Might make sense to change that for `ecm_mark_as_test(...)`, indeed. REPOSITORY R871 DrKonqi B

D8309: Modernize: Use nullptr where possible

This revision was automatically updated to reflect the committed changes. kfunk marked an inline comment as done. Closed by commit R871:abb6999b736b: Modernize: Use nullptr where possible (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8309?vs=20789&id=20800#toc REPOS

D8309: Modernize: Use nullptr where possible

kfunk marked an inline comment as done. kfunk added inline comments. INLINE COMMENTS > broulik wrote in backtracegenerator.cpp:69 > `Q_ASSERT(!m_proc && !m_temp)`? > iirc Clang doesn't like comparisons to `nullptr` very much (at least in > `QCOMPARE`) and I find it cleaner That can't be problem

D8307: Make Qt5::X11Extras really optional

kfunk added a reviewer: sitter. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D8307 To: kfunk, rjvbb, sitter Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8309: Modernize: Use nullptr where possible

kfunk added a reviewer: sitter. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D8309 To: kfunk, sitter Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8308: macOS: Don't create bundles for test executables

kfunk added a reviewer: sitter. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D8308 To: kfunk, rjvbb, sitter Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8309: Modernize: Use nullptr where possible

kfunk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D8309 AFFECTED FILES src/aboutbugreportingdialog.h src/backtracegener

D8307: Make Qt5::X11Extras really optional

kfunk added a reviewer: rjvbb. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D8307 To: kfunk, rjvbb Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8308: macOS: Don't create bundles for test executables

kfunk added a reviewer: rjvbb. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D8308 To: kfunk, rjvbb Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8308: macOS: Don't create bundles for test executables

kfunk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R871 DrKonqi BRANCH master REVISION DETAIL https://phabricator.kde.org/D8308 AFFECTED FILES CMakeLists.txt src/tests/backtraceparsertest/CMa

D8307: Make Qt5::X11Extras really optional

kfunk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise may fail with: CMake Warning at CMakeLists.txt:32 (find_package): Found package configuration file: /Users/kfunk/

D8264: Fix build of breeze-icons on the Android CI

kfunk accepted this revision. kfunk added a comment. This revision is now accepted and ready to land. That comment could be a bit more verbose and better placed (i.e. move it next to `set(BINARY_ICONS_RESOURCE_OPTION_DEFAULT OFF)` and make it something along "When cross-compiling qrcAlias wou

D8264: Fix build of breeze-icons on the Android CI

kfunk requested changes to this revision. kfunk added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:23 > +if (CMAKE_CROSSCOMPILING) > +set(GENERATE_ICONS_DEFAULT OFF) > +else() Better: `GENERATE_ICONS_DEFAULT` -> `BINARY_ICONS_RESOURCE_OPTIO

D5791: Allow to disable blinking cursor completely

kfunk added a comment. FTR, some links: http://git.net/ml/kwrite-devel/2015-05/msg00016.html https://superuser.com/questions/546426/how-to-disable-blinking-cursor-in-opensuse-12-2-kde-virtualbox REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL

D5791: Allow to disable blinking cursor completely

This revision was automatically updated to reflect the committed changes. Closed by commit R135:4be9b478e529: Allow to disable blinking cursor completely (authored by kfunk). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5791

D5791: Allow to disable blinking cursor completely

kfunk added a comment. @Plasma devs: Comments? There are some users out there who'd like to see this feature. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5791 To: kfunk, mck182, graesslin Cc: kossebau, plasma-devel, ZrenBot,

D6054: Use explicit flag values or explicit constructor instead of nullptr

kfunk accepted this revision. This revision is now accepted and ready to land. REPOSITORY R278 KWindowSystem BRANCH nonullptrforflagsplease REVISION DETAIL https://phabricator.kde.org/D6054 To: kossebau, #plasma, graesslin, kfunk Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff,

D5955: Fix compilation on CentOS 6

This revision was automatically updated to reflect the committed changes. Closed by commit R111:bb556d8cea2f: Fix compilation on CentOS 6 (authored by kfunk). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5955?vs=14798&id=14799 REVISION DETAIL ht

D5955: Fix compilation on CentOS 6

kfunk updated this revision to Diff 14798. kfunk added a comment. Conditionally link to librt REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5955?vs=14795&id=14798 BRANCH master REVISION DETAIL https://phabricator.kde.org/D5955 AFFECTED FIL

D5955: Fix compilation on CentOS 6

kfunk added a comment. Alright, I now see why this is no longer required under Linux: https://stackoverflow.com/a/32649327/592636 > Since glibc 2.17, the library linking -rt is no longer required. > The clock_* are now part of the main C library. You can see the change history of glib

D5955: Fix compilation on CentOS 6

kfunk added a reviewer: jriddell. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D5955 To: kfunk, jriddell Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D5955: Fix compilation on CentOS 6

kfunk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Issue: processui/CMakeFiles/processui.dir/ProcessModel.cpp.o: In function `TimeUtil::systemUptimeSeconds()': ProcessModel.cpp:(.t

D5791: Allow to disable blinking cursor completely

kfunk updated this revision to Diff 14355. kfunk added a comment. Allow 0, but otherwise keep the lower bound of 200 REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5791?vs=14353&id=14355 BRANCH master REVISION DETAIL

D5791: Allow to disable blinking cursor completely

kfunk added reviewers: mck182, graesslin. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D5791 To: kfunk, mck182, graesslin Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, luk

D5791: Allow to disable blinking cursor completely

kfunk added a comment. This is so trivial, yet I saw the demand for being able to disable the blinking cursor several times... Am I missing something or why was the minimum 200? REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D57

D5791: Allow to disable blinking cursor completely

kfunk created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D5791 AFFECTED FILES src/platformthem

D4929: DrKonqi : lldb support

kfunk requested changes to this revision. kfunk added a comment. This revision now requires changes to proceed. So, plasma-workspace is usually way out of my comfort zone, I'm commenting anyway since RJVB urged me to do it. See my notes. INLINE COMMENTS > backtracegenerator.cpp:62 > +

[Differential] [Commented On] D3809: Use new xkbcommon API for consumed modifiers

kfunk added a comment. In https://phabricator.kde.org/D3809#72334, @graesslin wrote: > could I ask you a favor? Please trust the maintainer. If I write no it's not possible then I mean that. This is the knowledge only core devs can have. To you it looks like a trivial change. To me it i

[Differential] [Commented On] D3809: Use new xkbcommon API for consumed modifiers

kfunk added a comment. In https://phabricator.kde.org/D3809#72205, @graesslin wrote: > In https://phabricator.kde.org/D3809#72177, @kfunk wrote: > > > This patch makes it impossible to build kwin on Ubuntu 16.10 (latest Ubuntu release) against distro libxkbcommon package -- isn't it p

[Differential] [Commented On] D3809: Use new xkbcommon API for consumed modifiers

kfunk added a comment. This patch makes it impossible to build kwin on Ubuntu 16.10 (latest Ubuntu release) -- isn't it possible to stay compatible with XKB 0.5.0 for some more time? Note: looks like libxkbcommon-0.7.0 was released 2016-11-11, so just one month ago. REPOSITORY R108 K

[Differential] [Closed] D947: Fix path of kcheckpass when pass to chown

This revision was automatically updated to reflect the committed changes. Closed by commit rKSCREENLOCKERfcfeae0cf4d6: Fix path of kcheckpass when passing it to chown (authored by kfunk). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D947?vs=2307&id=2676#toc REPOSITORY rKSCREENLOCKER K

[Differential] [Commented On] D947: Fix path of kcheckpass when pass to chown

kfunk added a comment. Thinking about it: Path should probably be either - `$ENV{DESTDIR}${CMAKE_INSTALL_PREFIX}/...` - Or deduced from a generator expression REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D947 EMAIL PREFERENCES https://phabr

[Differential] [Updated, 2 lines] D947: Fix path of kcheckpass when pass to chown

kfunk updated this revision to Diff 2307. kfunk added a comment. Fix message REPOSITORY rKSCREENLOCKER KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D947?vs=2306&id=2307 BRANCH master REVISION DETAIL https://phabricator.kde.org/D947 AFFECTED FILES kcheckpass

[Differential] [Updated] D947: Fix path of kcheckpass when pass to chown

kfunk added a reviewer: graesslin. REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D947 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kfunk, graesslin Cc: plasma-devel ___

[Differential] [Request, 2 lines] D947: Fix path of kcheckpass when pass to chown

kfunk created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY Now this still fails for me when installing kscreenlocker to $HOME: chown: changing ownership of ‘/home/kfunk/devel/install/kf5/lib/x86_64-linux-gnu/libexec/kcheckpa

Re: robots.txt in quickgit.kde.org

On Wednesday, January 06, 2016 10:30:52 AM Ben Cooksley wrote: > On Wed, Jan 6, 2016 at 3:17 AM, Kevin Funk wrote: > > On Wednesday, December 30, 2015 12:57:23 PM Ben Cooksley wrote: > >> On Tue, Dec 29, 2015 at 11:16 PM, Kevin Funk wrote: > >> > On Tuesday, Dec

Re: robots.txt in quickgit.kde.org

R for robots, in order to avoid abuse. Cheers, Kevin > > Cheers > > Lydia > > Regards, > Ben > > > -- > > Lydia Pintscher - http://about.me/lydia.pintscher > > KDE e.V. Board of Directors / KDE Community Working Group > > http://kde.org - http://open

Re: robots.txt in quickgit.kde.org

On Wednesday, December 30, 2015 12:57:23 PM Ben Cooksley wrote: > On Tue, Dec 29, 2015 at 11:16 PM, Kevin Funk wrote: > > On Tuesday, December 29, 2015 10:39:01 PM Ben Cooksley wrote: > >> On Tue, Dec 29, 2015 at 7:59 AM, Lydia Pintscher wrote: > >> > On Sun,

[Powerdevil] [Bug 352442] extremely slow response on brightness hotkeys

https://bugs.kde.org/show_bug.cgi?id=352442 --- Comment #9 from Kevin Funk --- @Igor: Do you have a link to the upstream issue? Is there a bug report at all? -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel

Re: Review Request 123040: Make selection in krunner wrapping

Marco said, I think it's consistent with tab behavior in general: Tabbing through something usually *cycles* through the list. Right now it's awkward to see the result you want at the bottom of the list in KRunner but then have to press tabs ~15 times to get there. - Kevin Funk On March

[kio-extras] [Bug 343153] New: kio_sftp crashes if sftp_write(...) fails (double-free in sftpProtocol::sftpPut)

https://bugs.kde.org/show_bug.cgi?id=343153 Bug ID: 343153 Summary: kio_sftp crashes if sftp_write(...) fails (double-free in sftpProtocol::sftpPut) Product: kio-extras Version: unspecified Platform: Other O

Re: Review Request 122158: Run convert-to-cmake-automoc.pl over files

://git.reviewboard.kde.org/r/122158/diff/ Testing --- Thanks, Kevin Funk ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122157: Run convert-to-cmake-automoc.pl over files

, Kevin Funk ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 122158: Run convert-to-cmake-automoc.pl over files

0a812492a5b9d482859f04c3f55bcf1eb3d88a38 kstyle/animations/oxygendockseparatorengine.cpp 084ec245b7e7752e13c51e0772dc0b12df0452ba kstyle/animations/oxygenenabledata.cpp 9b6c389bc46104d51c02090398539d87a24cf701 Diff: https://git.reviewboard.kde.org/r/122158/diff/ Testing --- Thanks, Kevin Funk

Review Request 122157: Run convert-to-cmake-automoc.pl over files

/imagescaler.cpp 7989091fdae915647f165cbce2c8a4e88a0909b8 applets/frame/picture.cpp 635d845dee9653a7918f16eedbca477aa1455aab Diff: https://git.reviewboard.kde.org/r/122157/diff/ Testing --- Thanks, Kevin Funk ___ Plasma-devel mailing list Plasma

Re: Review Request 120877: Convert switch statements to if/else due to MSVC limitation

x27;t see a better solution either => Go for it. - Kevin Funk On Oct. 30, 2014, 1:35 a.m., Andrius da Costa Ribas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewbo

[Breeze] [Bug 341291] New: Issues with vertical spacing between items in tree views

https://bugs.kde.org/show_bug.cgi?id=341291 Bug ID: 341291 Summary: Issues with vertical spacing between items in tree views Product: Breeze Version: unspecified Platform: Other OS: Linux Status:

Re: Review Request 119604: Fix build of KDELibs4Support, qMessageFormatString

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119604/#review63880 --- Ship it! Ship It! - Kevin Funk On Aug. 4, 2014, 5:21 p.m

Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.

> On Oct. 31, 2013, 3:27 p.m., Kevin Funk wrote: > > Bump. Can we have this fixed soonish? Nicolas, can you push? Bump again -- Without this fix, controlling volume in KMix via the mouse wheel is close to impossible. Can someone push?

Re: Review Request 113124: MouseEventListener: Don't process event from children multiple times.

? - Kevin Funk On Oct. 6, 2013, 7:36 p.m., Nicolás Alvarez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.