kfunk requested changes to this revision. kfunk added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > CMakeLists.txt:23 > +if (CMAKE_CROSSCOMPILING) > + set(GENERATE_ICONS_DEFAULT OFF) > +else() Better: `GENERATE_ICONS_DEFAULT` -> `BINARY_ICONS_RESOURCE_OPTION_DEFAULT` (consistent naming) Also add some comment why it's disabled when cross-compiling. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D8264 To: apol, #frameworks, #plasma, kfunk Cc: kfunk, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
