Re: Polishing sprint in May: dates?

2014-03-20 Thread Ignat Semenov
question! Best regards, Ignat Semenov Sebastian Kügler wrote: > Hey, > > A bunch of us want to get together in May to put finishing touches in > Plasma Next. This sprint is important because it allows us to sit down and > fix remaining bugs. > > I am proposing dates here, th

Re: Menu branch

2013-04-24 Thread Ignat Semenov
to Sho for reviewing the branch and nitpicking on everything, as well as general support. :) Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Menu branch

2013-04-21 Thread Ignat Semenov
OK forget that, just talked to aseigo and he told me there still is a usecase (and probably a few of those) for manual arrangement in the standalone mode. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-de

Re: Menu branch

2013-04-21 Thread Ignat Semenov
quot;Icons" when it's a standalone applet? That said, when I factor out the actions code, this is something to consider. Thank you! Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Menu branch

2013-04-21 Thread Ignat Semenov
Done! Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Menu branch

2013-04-19 Thread Ignat Semenov
way more readable, in my opinion, not to say the it is now easier to configure the layout (I have had troubles wrapping my head around the top to bottom right to left stuff as well). Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma

Re: Menu branch

2013-04-17 Thread Ignat Semenov
A UI draft: http://imagebin.org/254401 Maybe move "Icon size" to the "Arrangement" section? Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Menu branch

2013-04-17 Thread Ignat Semenov
num bracing them all in there. All the others, which you should have noticed, are enums with qvariant's since that gives you compiler warnings and errors in case you mess up - a nice thing imho :) Thank you for the advice! Best regards, Ignat Semenov __

Re: Menu branch

2013-04-17 Thread Ignat Semenov
2013] [00:15:06]returns true Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Menu branch

2013-04-17 Thread Ignat Semenov
he action data, hence QVariant's and Q_DECLARE_METATYPE. QVariant::operator==() fails for user defined types, including Q_DECLARE_METATYPE'd enums. Debugged together with tsdgeos and steveire. So we have to workaround that, in a manually written loop, which I put in a helper func. Thank yo

Re: Folderview: add "Unsorted" to the "sort Icons" context menu?

2013-04-02 Thread Ignat Semenov
Bump? Any considerations / opinions / ideas? Thank you! Best regards, Ignat Semenov On Fri, Mar 29, 2013 at 11:55 PM, Ignat Semenov wrote: > Hello guys! > > I've been polishing the context menu and Display page lately, both the > looks > and the code, and discovered

Folderview: add "Unsorted" to the "sort Icons" context menu?

2013-03-29 Thread Ignat Semenov
hat a the first option in the sorting context menu? Thank you! Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Please delete 2 branches

2013-02-03 Thread Ignat Semenov
Hello guys! I'd like an admin to delete the branches: remotes/origin/fvport remotes/origin/plasma/isemenov/folderview-qml The first one is a mistake, the second one has stuck and we decided to start a new one instead, ditching the old one. Thank you! Best regards, Ignat Se

A folderview QGraphicsView related bug

2012-05-18 Thread Ignat Semenov
asma library? 2)Any ideas when underMouse() might fail like this when not dragging? Seems to be completely random. Basically, we need to change the iteration loop to something more reliable, and that will fix the bug. Best regards, Ignat Semenov ___ Plasma-d

Review Request: Hide action buttons at certain icon sizes

2012-03-26 Thread Ignat Semenov
ded "+" button.. although the patch submitted in thei review request should go in regardless of such a checkbox being added because at some icon sizes, the action icons are a plain annoyance, indeed. Thanks, Ignat Semenov ___ Plasma-devel mailing

Re: Review Request: Scroll automatically when touching the border with the rubberband

2012-03-24 Thread Ignat Semenov
while scrollling automatically as a result of dragging the rubberband over the view border? Fredrik, what do you think? Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Scroll automatically when touching the border with the rubberband

2012-03-24 Thread Ignat Semenov
e640b Diff: http://git.reviewboard.kde.org/r/104396/diff/ Testing --- Tested, works. Maybe we should also stop automatic scrolling if the user releases the LMB while scrollling automatically as a result of dragging the rubberband over the view border? Fredrik, what do you think? Thanks,

Re: Workflow Idea for 4.10

2012-03-23 Thread Ignat
Hello fellow plasma devs! Ping? Any info on there issues? I understand I'm not a core dev yet, so probably not enough experience to talk about workflows and affect decisions, but these are some really existing issues with the Gerrit system as used in Qt development. Bet regards, Ignat Se

Re: Review Request: Less repainting on mousePressEvent(), moseReleaseEvent() and mouseDoubleClickEvent() in FolderView::IconView

2012-03-22 Thread Ignat Semenov
marter way. Diffs (updated) - plasma/applets/folderview/iconview.h 12e93b3 plasma/applets/folderview/iconview.cpp 5c4e086 Diff: http://git.reviewboard.kde.org/r/103822/diff/ Testing --- Testing done against master, seems to behave indentically. Thanks, Ign

Re: Review Request: Add a link to the current desktop folder instead of an icon applet if the desktop is set to folderview on the "Add to Desktop" Kickoff action

2012-03-20 Thread Ignat Semenov
::link() if that's the case. Diffs (updated) - plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp 99c2649 Diff: http://git.reviewboard.kde.org/r/103830/diff/ Testing --- Tested, works. Thanks, Ignat Semenov ___ Plasma-devel m

Re: Review Request: add public slot FolderView::addUrl(KUrl)

2012-03-20 Thread Ignat Semenov
n applet. Diffs (updated) - plasma/applets/folderview/folderview.h 4e441eb plasma/applets/folderview/folderview.cpp 121d1e7 Diff: http://git.reviewboard.kde.org/r/104328/diff/ Testing --- Tested, works. Thanks, Ignat Semenov ___ Pla

Review Request: add public slot FolderView::addUrl(KUrl)

2012-03-17 Thread Ignat Semenov
erview.cpp 121d1e7 Diff: http://git.reviewboard.kde.org/r/104328/diff/ Testing --- Tested, works. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add a link to the current desktop folder instead of an icon applet if the desktop is set to folderview on the "Add to Desktop" Kickoff action

2012-03-17 Thread Ignat Semenov
uot;folderview" plugin is used in the desktop containment and performs a KIO::link() if that's the case. Diffs (updated) - plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp 8db9655 Diff: http://git.reviewboard.kde.org/r/103830/diff/ Testing --- Test

Re: Review Request: do not crash when passing a url in the ctor e.g. when creating a folderview by dropping a folder onto the desktop

2012-03-17 Thread Ignat Semenov
://git.reviewboard.kde.org/r/104311/diff/ Testing --- Tested, works. Would be nice to give the code a static analyzer run, if there was a decent static analyzer available in Linux. Anybody have relevant experience? Thanks, Ignat Semenov ___ Plasma-devel mailing

Re: Review Request: do not crash when passing a url in the ctor e.g. when creating a folderview by dropping a folder onto the desktop

2012-03-17 Thread Ignat Semenov
://git.reviewboard.kde.org/r/104311/diff/ Testing --- Tested, works. Would be nice to give the code a static analyzer run, if there was a decent static analyzer available in Linux. Anybody have relevant experience? Thanks, Ignat Semenov ___ Plasma-devel mailing

Review Request: do not crash when passing a url in the ctor e.g. when creating a folderview by dropping a folder onto the desktop

2012-03-17 Thread Ignat Semenov
--- Tested, works. Would be nice to give the code a static analyzer run, if there was a decent static analyzer available in Linux. Anybody have relevant experience? Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https

Re: Review Request: Save scrollbar position on plasma exit

2012-03-17 Thread Ignat Semenov
ser is able to scroll the view while the layout is in > progress, this should also abort restoring the position. > > Also, I'm wondering if we really need to save the position separately for > the iconview and the listview, or if we should use the same key. > >

Re: Review Request: Save scrollbar position on plasma exit

2012-03-16 Thread Ignat Semenov
r/104258/diff/ Testing --- Tested both the icon view and the list view, works fine. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Save scrollbar position on plasma exit

2012-03-16 Thread Ignat Semenov
lasma/applets/folderview/listview.cpp 94efe44 Diff: http://git.reviewboard.kde.org/r/104258/diff/ Testing --- Tested both the icon view and the list view, works fine. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@

Re: Review Request: Save scrollbar position on plasma exit

2012-03-16 Thread Ignat Semenov
-- Tested both the icon view and the list view, works fine. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Save scrollbar position on plasma exit

2012-03-14 Thread Ignat Semenov
ser is able to scroll the view while the layout is in > progress, this should also abort restoring the position. > > Also, I'm wondering if we really need to save the position separately for > the iconview and the listview, or if we should use the same key. > >

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
/listview.cpp b17e7c4 Diff: http://git.reviewboard.kde.org/r/104258/diff/ Testing --- Tested both the icon view and the list view, works fine. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mai

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
ser is able to scroll the view while the layout is in > progress, this should also abort restoring the position. > > Also, I'm wondering if we really need to save the position separately for > the iconview and the listview, or if we should use the same key. > >

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
rPosition() manually after startup? Folder mtime is a nice idea, one more corner case, will try to implement. - Ignat --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104258/#review11354

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
iew.h 4e441eb plasma/applets/folderview/folderview.cpp a94ce87 plasma/applets/folderview/iconview.cpp 5c4e086 plasma/applets/folderview/listview.cpp b17e7c4 Diff: http://git.reviewboard.kde.org/r/104258/diff/ Testing --- Tested both the icon view and the list view, works fine. T

Re: Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
icon view and the list view, works fine. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Save scrollbar position on plasma exit

2012-03-13 Thread Ignat Semenov
w.cpp 5c4e086 plasma/applets/folderview/listview.cpp b17e7c4 Diff: http://git.reviewboard.kde.org/r/104258/diff/ Testing --- Tested both the icon view and the list view, works fine. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-

Re: Workflow Idea for 4.10

2012-03-13 Thread Ignat Semenov
Ben Cooksley wrote: > On Tue, Mar 13, 2012 at 7:58 PM, Ignat Semenov > wrote: >> Hello fellow KDE devs! >> >> While I'm not an experienced developer nor manager, the planned >> transition to gerrit really troubles me. In particular, I have the >>

Re: Workflow Idea for 4.10

2012-03-12 Thread Ignat Semenov
lation requires authentication just to browse the existing requests read-only. Is it possible to do it differently or is this a shortcoming of gerrit ( or its "design feature")? Pretty user- and newcomer-unfriendly, too. Best regards, Ignat Semenov ___

Re: Review Request: Add a link to the current desktop folder instead of an icon applet if the desktop is set to folderview on the "Add to Desktop" Kickoff action

2012-03-02 Thread Ignat Semenov
t; Applet and which doesn't result in assumptions about what the source or > > targets are. OK how about if we commit this for 4.8.1 and provide the 100% correct fix in master and 4.8.2? - Ignat --- This is an automatically gen

Unreproducible bug

2012-02-28 Thread Ignat Semenov
tly in the meanwhile. So I'd like to ask you guys, especially Aaron:have you fixed any containment sizing related bugs recently? Anything in the desktop containment or deeper in libplasma? If not, I'll just dig into the FW code to try and figure stuff out.. Best re

Folderview selection marker, revisited

2012-02-20 Thread Ignat Semenov
le the marker - but that would void my work on the automatic detection. Opinions? This may look like a minor issue not worth sucha long email and such a long discussion, but these minor nitpicks, or lack thereof, do sum up to crate a positive user experienc

Re: constraints and size hints

2012-02-13 Thread Ignat Semenov
h inherits popupApplet) behave identically, remaining narrow and tall in the panel. What is worse, it does not repaint on panel resize! There even is a bug somewhere complaining about that issue. Maybe there is a call that inhibits repaints somewhere? Best regards, Ign

constraints and size hints

2012-02-12 Thread Ignat Semenov
is not how things should be done. Waiting for two people (mostly one) to come up on IRC to finish your code is not normal ither. Thus, I encourage those in the know to document this area with examples and a real explanation, as seen in the Qt docs. Thank you a lot in advance. Be

Newspaper layout problems and KNode bugs

2012-02-11 Thread Ignat Semenov
ncast if you wish, but you most probably can reproduce it yourself. Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Newspaper layout

2012-02-11 Thread Ignat Semenov
hird click of the 'X', it was sometimes impossible to put applets in the necessary column / row, ipossible to control applets' size, applets overlapping each other, etc. I can make a screencast if you wish, but you most probably can reproduce i

Newspaper layout

2012-02-11 Thread Ignat Semenov
the 'X', it was sometimes impossible to put applets in the necessary column / row, ipossible to control applets' size, applets overlapping each other, etc. I can make a screencast if you wish, but you most probably can reproduce it yourself. Best regards, Ignat Semenov __

Review Request: Fix collapsed folderview in panels

2012-02-10 Thread Ignat Semenov
6e2a Diff: http://git.reviewboard.kde.org/r/103915/diff/diff Testing --- Tested the hell out of it:dragged the panel around the screen on all the 4 screen edges - no problems noticed. Changed Panel icon size in the Icons KCM, updates on the fly. Thanks, Ignat Sem

Re: Review Request: Fix folderview sorting

2012-02-09 Thread Ignat Semenov
results similar to Dolphin sorting of the same folder (surpise! :) ). Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

FrameSVG manual reload on themeChanged()

2012-02-09 Thread Ignat Semenov
ivate::themeChanged(), an unconditional one.) So, I'd like to avoid this second repaint (via update()), and reload the framesvg manually. How can I do that? Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.o

Review Request: Fix folderview sorting

2012-02-08 Thread Ignat Semenov
, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Take sorting order into account in ProxyModel::lessThan() in order to give folders precedence regardless of the sort order used

2012-02-07 Thread Ignat Semenov
g/r/103884/diff/diff Testing --- Tested, builds and works as described above. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview

2012-02-06 Thread Ignat Semenov
Marco Martin wrote: > On Mon, Feb 6, 2012 at 9:22 AM, Ignat Semenov > wrote: >> Hello fellow plasma devs! >> >> This change, while trivial, contains 2 strings, "Ascending" and >> "Desending". I've found out that the very same strings already

Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview

2012-02-06 Thread Ignat Semenov
commit can be backported to 4.8? Best regards, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Less repainting on mousePressEvent(), moseReleaseEvent() and mouseDoubleClickEvent() in FolderView::IconView

2012-02-05 Thread Ignat Semenov
; > plasma/applets/folderview/iconview.cpp, line 2605 > > <http://git.reviewboard.kde.org/r/103822/diff/1/?file=48118#file48118line2605> > > > > Change the name of this variable to 'rect'. Indeed, it is not necessarily dirty. Copy-paste :) - Ignat ---

Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview

2012-02-03 Thread Ignat Semenov
Diff: http://git.reviewboard.kde.org/r/103860/diff/diff Testing --- Tested, works. Changes the icon sort direction, even though the actual sorting is sometimes broken (my next task, most probably.) Thanks, Ignat Semenov ___ Plasma-devel mailing

Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview

2012-02-03 Thread Ignat Semenov
rview/folderview.h e458d77 plasma/applets/folderview/folderview.cpp 54ea14a Diff: http://git.reviewboard.kde.org/r/103860/diff/diff Testing --- Tested, works. Changes the icon sort direction, even though the actual sorting is sometimes broken (my next task, most probably.) Thanks, Ignat Se

Re: Review Request: Allow to choose between ascending and descending icon sort order in folderview

2012-02-03 Thread Ignat Semenov
lasma/applets/folderview/folderview.cpp 54ea14a Diff: http://git.reviewboard.kde.org/r/103860/diff/diff Testing --- Tested, works. Changes the icon sort direction, even though the actual sorting is sometimes broken (my next task, most probably.) Thanks, Ignat Se

Review Request: Allow to choose between ascending and descending icon sort order in folderview

2012-02-03 Thread Ignat Semenov
org/r/103860/diff/diff Testing --- Tested, works. Changes the icon sort direction, even though the actual sorting is sometimes broken (my next task, most probably.) Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request: Apply the IconView model settings to the PopupView in the PopupView constructor for consistency

2012-02-02 Thread Ignat Semenov
0243b2f plasma/applets/folderview/popupview.cpp 7fdb3f7 Diff: http://git.reviewboard.kde.org/r/103851/diff/diff Testing --- Tested, works. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Review Request: Fix incorrect painting of Plasma::IconWidget on double-click with KDE set to double-click

2012-01-31 Thread Ignat Semenov
() signal. Diffs - plasma/widgets/iconwidget.cpp 1161cc4 Diff: http://git.reviewboard.kde.org/r/103831/diff/diff Testing --- Tested on desktop and in the panel with KDE set to both double- and single-click, works fine. Thanks, Ignat Semenov

Review Request: Add a link to the current desktop folder instead of an icon applet if the desktop is set to folderview on the "Add to Desktop" Kickoff action

2012-01-31 Thread Ignat Semenov
derview" plugin is used in the desktop containment and performs a KIO::link() if that's the case. Diffs - plasma/desktop/applets/kickoff/ui/contextmenufactory.cpp 8db9655 Diff: http://git.reviewboard.kde.org/r/103830/diff/diff Testing --- Tested, works.

Review Request: Less repainting on mousePressEvent(), moseReleaseEvent() and mouseDoubleClickEvent() in FolderView::IconView

2012-01-29 Thread Ignat Semenov
http://git.reviewboard.kde.org/r/103822/diff/diff Testing --- Testing done against master, seems to behave indentically. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix the issues introduced with the iconshrink patch

2012-01-29 Thread Ignat Semenov
etting the proper patch done. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

2012-01-20 Thread Ignat Semenov
anging the paintItem() code to use the itemSize() rect and observing the improved behaviour. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

2012-01-20 Thread Ignat Semenov
: http://git.reviewboard.kde.org/r/103735/diff/diff Testing --- Tested by manually changing the paintItem() code to use the itemSize() rect and observing the improved behaviour. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

2012-01-19 Thread Ignat Semenov
gt; > > > > hm can be cons. also, spaces around the + signs, please Will do. - Ignat --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103735/#review9953 --

Re: Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

2012-01-19 Thread Ignat Semenov
esting --- Tested by manually changing the paintItem() code to use the itemSize() rect and observing the improved behaviour. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Account for the SVG margins in FolderView::IconView::itemSize()

2012-01-19 Thread Ignat Semenov
) rect and observing the improved behaviour. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix the double-click icon shrink issue in the FolderView applet

2012-01-13 Thread Ignat Semenov
, works both with KDe set ot single- and double-click. Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Fix the issues introduced with the iconshrink patch

2012-01-12 Thread Ignat Semenov
d.kde.org/r/103685/diff/diff Testing --- This is not final, there is 1 pixel offset bug in the halo drawing code. I'm going to sleep today, this review request is just to show that I'm aware that I have screwed things up and am working on getting the proper patch do

Review Request: Fix the double-click icon shrink issue in the FolderView applet

2012-01-12 Thread Ignat Semenov
/applets/folderview/iconview.h 38cad54 plasma/applets/folderview/iconview.cpp 842e158 Diff: http://git.reviewboard.kde.org/r/103679/diff/diff Testing --- Tested, works both with KDe set ot single- and double-click. Thanks, Ignat Semenov

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
. Peter, we'd like to know the rationale for exposing such an option in the configuration UI. - Ignat Semenov On Jan. 3, 2012, 5:21 p.m., Ignat Semenov wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
only on Plasma restart and not on the fly after hitting the Appy or Ok buttons. Aaron, please, have a look into this. This happens with any settings, not onyl the ones I added. (My settings code is absolutely identical to the "Click to view folder"

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
to view folder" settigns code). Thanks, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
to > make it as global as can be. Otherwise they have crap to configure in dolphin > and then every folderview they own. Plus it keeps it clean; good idea. > > Ignat Semenov wrote: > OK. So, are you fine with the implementation code? > > If yes, I will commit t

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
its may come in later. Please, give me a final decision on this. Do I maybe need to wait for Aaron to approve this (a week, that is)? - Ignat --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
n this applet are applied only on Plasma restart and not on the fly after hitting the Appy or Ok buttons. Aaron, please, have a look into this. This happens with any settings, not onyl the ones I added. (My settings code is absolutely identical to the "Click to view folder" setti

Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
Appy or Ok buttons. Aaron, please, have a look into this. This happens with any settings, not onyl the ones I added. (My settings code is absolutely identical to the "Click to view folder" settigns code). Thanks, Ignat Semenov ___ Pla

FolderView Overlay Incapsulation Question

2012-01-01 Thread Ignat Semenov
e configAccepted() method no longer aplies settings, which is perfectly fine per se. But, now when we click Apply or OK, the settings are written to the disk, but are **not** applied. Tested in trunk. This needs some solution as well. Best regards, Ignat Semenov __

Review Request: Apply the new settings in Folderview on clicking the "Apply" button

2011-12-26 Thread Ignat Semenov
ould go before the timer or after it. My guess is that the timer call is there in order to allow the newly written settings to sync to the hard disk, so I put the call at the very end of the accepted() method. Thanks, Ignat Semenov ___ Pl

Re: Review Request: Fïx two little bugs: one with default contrast settings and one with plasma popup alignment.

2011-12-26 Thread Ignat Semenov
button. - Ignat Semenov On Dec. 24, 2011, 5:35 p.m., Nikita Churaev wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: KWin GLES needs testers

2011-01-02 Thread Ignat Semenov
27;t seen any jerkies yet That's it after half an hour of normal use, no crashes except for the mentioned crash in the config dialog. Regards, Ignat Semenov P.S. As you say, nouveau allows for GLES (didn't know about that, btw.) Can test this as well if necessary.

Re: The state of KWin

2010-12-26 Thread Ignat Semenov
he most time to investigate and the least amount of lines to submit after solving the problem, don't you think.) Cheers, Ignat Semenov ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: The state of KWin

2010-12-26 Thread Ignat Semenov
at it's too early, but it's better to do things earlier that later anyway, don't you think? And mind you I'm from Russia, but that should not be a problem anyway, hope so at least. Cheers, Ignat Semenov aka thorGT ___ Plasma-devel ma

Review Request: Embed "Virtual Desktops" KCM into the pager configuration dialog

2010-05-26 Thread Ignat Semenov
I build it on my machine, if I press OK in the embedded KCM after changging something in it, Plasma quits. No crash, just quits. Marco Martin has applied the patch and he has no such problem. Please investigate. Until solved this request is a draft. Than

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Ignat Semenov
#x27;d like to know what other graphics design people think about this. If decided upon, then the conversion should be easy and can be done in less than a day, so it's not that difficult, IMO. Regards Ignat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 2: The Default Button

2010-05-25 Thread Ignat Semenov
the default button, but not > > the separator change. > > Ignat Semenov wrote: > Please, show me a config dialog with a separator in KDE. No offense, but > I really haven't found one. Again, it creates visual noise and again, we > agreed on removing it. An

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 2: The Default Button

2010-05-25 Thread Ignat Semenov
the default button, but not > > the separator change. Please, show me a config dialog with a separator in KDE. No offense, but I really haven't found one. Again, it creates visual noise and again, we agreed on removing it. - Ignat --

Re: Review Request: Properly hide KConfigDialog page headers when there is no header text set

2010-05-25 Thread Ignat Semenov
em. Again, discussed with pinheiro and notmart on #oxygen. We agreed to avoid bad information duplication. I'd really likt to see it that way. - Ignat --- This is an automatically ge

Re: Review Request: Properly hide KConfigDialog page headers when there is no header text set

2010-05-25 Thread Ignat Semenov
After applying the patch, no headers appear in the Plasma configuration dialogs, which use KConfigDialog::addPage(QWidget *, QString &, QString &). It doesn't break BC as the cnahge is done in a private class. Thanks, Ignat ___ Plasm

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-25 Thread Ignat Semenov
t me wrong, was a long discussion on how to improve what we have in Plasma in this area, it raised quite some questions). String freeze - well, let's do it on the left for 4.5 and then on the right. I'd really like to see it that way. - Ignat -

Re: Review Request: Change device notifier tooltips to respect plasma tooltip style

2010-05-25 Thread Ignat Semenov
And maybe no text at all for the separators? Like one more font face and not aligned with anything either. (Yes, I like to remove stuff ;) On Tue, May 25, 2010 at 8:22 PM, Aaron J. Seigo wrote: > On May 22, 2010, Jacopo De Simoi wrote: >> I'm playing around with that now, and here's what I got so

Review Request: Plasmoid Configuration Dialogs Saga Part 2: The Default Button

2010-05-24 Thread Ignat Semenov
/4130/diff Testing --- Builds fine. The dialog has no "Default" button and no separator at the bottom. Thanks, Ignat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Properly hide KConfigDialog page headers when there is no header text set

2010-05-24 Thread Ignat Semenov
After applying the patch, no headers appear in the Plasma configuration dialogs, which use KConfigDialog::addPage(QWidget *, QString &, QString &). It doesn't break BC as the cnahge is done in a private class. Thanks, Ignat ___ Plasm

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-23 Thread Ignat Semenov
http://reviewboard.kde.org/r/4119/s/410/ Thanks, Ignat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-23 Thread Ignat Semenov
Oxygen style and I've already filed a bug against Oxygen. Thanks, Ignat ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: Plasmoid Configuration Dialogs Saga Part 1 : The Pager

2010-05-23 Thread Ignat Semenov
Diff: http://reviewboard.kde.org/r/4119/diff Testing --- Built it and it really scales properly now. There is only a minor problem with Oxygen style and I've already filed a bug against Oxygen. Thanks, Ignat ___ Plasma-devel mailing list P

Re: Pager Configuration Dialog

2010-05-23 Thread Ignat Semenov
Patch version 2.Regards,Ignat new_non_expanding.patch Description: Binary data ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Pager Configuration Dialog

2010-05-23 Thread Ignat Semenov
ou like more and what fits better into KDE style.Going on to task manager.Regards,Ignat new.patch Description: Binary data ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

  1   2   >