----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103529/#review9282 -----------------------------------------------------------
Ship it! Given that two developers have both given positive feedback on the relevant parts of the patch, although independently, I can use the right to give the review a ship it! Nikita Churaev, do you have a developer account to commit the changes? If not, you can request a developer account at your identity.kde.org personal page using a similarly named button. - Ignat Semenov On Dec. 24, 2011, 5:35 p.m., Nikita Churaev wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103529/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2011, 5:35 p.m.) > > > Review request for kdelibs and Plasma. > > > Description > ------- > > Contrast bug: KGlobalSettings::contrast() returns different default value > than KGlobalSettings::contrastF(). Oxygen uses contrastF() while KDE color > control module uses contrast(), so when the user first uses color settings, > contrast appears to change. > > Plasma popup bug: Right-aligned popups are one pixel away from right edge of > the screen and top-aligned popups (when panel is on top) are one pixel inside > panel. This is because the bug in QRect, where right() and bottom() value > return value that is less than the true value by one. This is a feature-bug > that Qt developers aren't going to fix because of compatiability reasons. My > patch just applies + 1 compensation to all expressions that use > QRect::right() and QRect::bottom(). > > > Diffs > ----- > > kdeui/kernel/kglobalsettings.cpp 819b314 > plasma/corona.cpp 366a9df > > Diff: http://git.reviewboard.kde.org/r/103529/diff/diff > > > Testing > ------- > > > Thanks, > > Nikita Churaev > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
