----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103860/ -----------------------------------------------------------
(Updated Feb. 3, 2012, 7:16 p.m.) Review request for Plasma, Aaron J. Seigo and Marco Martin. Description ------- This patch allows to select between acsending and descending icon sort order in folderview. THe QVariant() and the short-circuit if's in cg.readEntry() / cg.writeEntry() stem from the fact that Qt::SortOrder can not be converted to an int, and needs to be operated this way. Thanks go to dfaure for explaining me how to do deal with the enum problem. This addresses bug 180646. http://bugs.kde.org/show_bug.cgi?id=180646 Diffs ----- plasma/applets/folderview/folderview.h e458d77 plasma/applets/folderview/folderview.cpp 54ea14a Diff: http://git.reviewboard.kde.org/r/103860/diff/diff Testing ------- Tested, works. Changes the icon sort direction, even though the actual sorting is sometimes broken (my next task, most probably.) Thanks, Ignat Semenov
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel