[Differential] [Commented On] D3753: Fix comparing pa_cvolume objects

2016-12-20 Thread shumski (Hrvoje Senjan)
shumski added a comment. I can confirm the bug is fixed with this. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D3753 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, davidedmundson Cc: shumsk

[Differential] [Changed Subscribers] D3222: Correctly set i18n suffix in mousemark spinbox.

2016-11-03 Thread shumski (Hrvoje Senjan)
shumski added inline comments. INLINE COMMENTS > CMakeLists.txt:89 > KIO > +TextWidgets > NewStuff > Note, "new" dependency was already linked implicitly in other kwin, but we > need to add it for this KCM. For completeness sake, ktextwidgets devel files where not present in bu

Re: Review Request 128763: WindowThumbnail: Do GL calls in the correct thread

2016-09-28 Thread Hrvoje Senjan
) <https://git.reviewboard.kde.org/r/128763/#comment67000> This is added in Qt 5.6, but: set (REQUIRED_QT_VERSION "5.3.0") which is also wrong. - Hrvoje Senjan On Sept. 3, 2016, 10:33 a.m., David Edmundson wrote: > >

[Differential] [Changed Subscribers] D2372: Make powerdevil normal executable instead of kded module

2016-08-08 Thread shumski (Hrvoje Senjan)
shumski added inline comments. INLINE COMMENTS > CMakeLists.txt:135 > > -install(TARGETS kded_powerdevil DESTINATION ${PLUGIN_INSTALL_DIR}/kf5/kded) > +install(TARGETS powerdevil DESTINATION ${CMAKE_INSTALL_FULL_LIBEXECDIR_KF5}) > +install(FILES ${CMAKE_CURRENT_BINARY_DIR}/powerdevil.desktop P

[Differential] [Updated] D1722: Import next-gen libtaskmanager.

2016-06-06 Thread shumski (Hrvoje Senjan)
shumski added a comment. Plasma addons don't build against this change: /home/abuild/rpmbuild/BUILD/kdeplasma-addons-5.6.90git~20160524T120553~https://phabricator.kde.org/rKDEPLASMAADDONS7d85a2cf3c6c968a41ab30425c62b2f058408a3e/applets/activitypager/plugin/activitypager.cpp:53:30: fatal er

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-17 Thread Hrvoje Senjan
marked as submitted. Review request for Plasma and David Faure. Changes --- Submitted with commit 27ebf75bd44101976d8392eec4ff4d20f495fb69 by Hrvoje Senjan to branch Plasma/5.6. Repository: plasma-desktop Description --- Address David's issues in previous rr's regardin

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-17 Thread Hrvoje Senjan
obals and ~/.config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-17 Thread Hrvoje Senjan
s Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-16 Thread Hrvoje Senjan
browser is correctly written in both ~/.kde4/share/config/kdeglobals and ~/.config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 127918: Cleanup and fixup KConfig handling for componentchooser

2016-05-14 Thread Hrvoje Senjan
browser is correctly written in both ~/.kde4/share/config/kdeglobals and ~/.config/kdeglobals Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 123281: Avoid triggering bug 340691

2016-05-14 Thread Hrvoje Senjan
ou're right. Furthermore, the bug is about the source, not the target. - Hrvoje --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123281/#review95454 -------

Re: Review Request 123288: Fix some more KConfig usage (wrt bug 340691)

2016-05-14 Thread Hrvoje Senjan
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123288/#review95455 --- On April 7, 2015, 8:50 p.m., Hrvoje Senjan wrote: > >

[Differential] [Closed] D1237: Fix compilation with gcc 4.8

2016-03-29 Thread shumski (Hrvoje Senjan)
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND34d54f760d2c: Fix compilation with gcc 4.8 (authored by shumski). REPOSITORY rKWAYLAND KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D1237?vs=2980&id=3005 REVISION DETAIL h

[Differential] [Request, 2 lines] D1237: Fix compilation with gcc 4.8

2016-03-28 Thread shumski (Hrvoje Senjan)
shumski created this revision. shumski added a reviewer: graesslin. shumski set the repository for this revision to rKWAYLAND KWayland. shumski added a project: Plasma. Herald added a subscriber: plasma-devel. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1237 AF

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

2016-03-20 Thread Hrvoje Senjan
> On March 16, 2016, 5:31 p.m., Hrvoje Senjan wrote: > > shell/testcorona.cpp, line 22 > > <https://git.reviewboard.kde.org/r/127346/diff/4/?file=449839#file449839line22> > > > > PlasmaQuick doesn't have any headers installed, so the build fails. >

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

2016-03-19 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/127346/#comment63836> PlasmaQuick doesn't have any headers installed, so the build fails. - Hrvoje Senjan On March 16, 2016, 12:46 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically genera

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

2016-03-19 Thread Hrvoje Senjan
> On March 16, 2016, 5:31 p.m., Hrvoje Senjan wrote: > > shell/testcorona.cpp, line 22 > > <https://git.reviewboard.kde.org/r/127346/diff/4/?file=449839#file449839line22> > > > > PlasmaQuick doesn't have any headers installed, so the build fails. >

Re: Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-09 Thread Hrvoje Senjan
marked as submitted. Review request for Plasma and Harald Sitter. Changes --- Submitted with commit 73b5509bd45719e8cbbee95142d25d373172bfe1 by Hrvoje Senjan to branch Plasma/5.6. Repository: breeze-plymouth Description --- KDECompilerSettings aren't included so this wasn'

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-09 Thread Hrvoje Senjan
> On March 8, 2016, 6:20 p.m., Hrvoje Senjan wrote: > > Do we want a kconf_update script with that for all hte people that have > > systemsettings.desktop as favourite in launchers? > > Martin Gräßlin wrote: > I don't think it's needed. The important part

Re: Review Request 127308: Fix name of desktop file to have icon working on Wayland

2016-03-08 Thread Hrvoje Senjan
people that have systemsettings.desktop as favourite in launchers? - Hrvoje Senjan On March 8, 2016, 4:18 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboa

Review Request 127296: [breeze-plymouth] Build with -Wl, --no-undefined linker flag

2016-03-06 Thread Hrvoje Senjan
diff/ Testing --- Now builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 127086: Raise the required CMake version to 3.4.0

2016-02-29 Thread Hrvoje Senjan
odule that only indicates RUNTIME requirement? Another way is to check for ISOcodes only with cmake 3.4. - Hrvoje Senjan On Feb. 16, 2016, 12:13 p.m., Elias Probst wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-21 Thread Hrvoje Senjan
> On Jan. 20, 2016, 11:26 p.m., Hrvoje Senjan wrote: > > so i lost kmail icon in tray after this it seems > > Marco Martin wrote: > do you have an empty space or no icon at all? empty space. - Hrvoje --- This i

Re: Review Request 126792: IconItem: Try to load QIcon::fromTheme icons as svg

2016-01-20 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126792/#review91390 --- so i lost kmail icon in tray after this it seems - Hrvoje

Re: Review Request 126381: kwayland backend for libkscreen

2016-01-04 Thread Hrvoje Senjan
> On Dec. 24, 2015, 9:23 p.m., Hrvoje Senjan wrote: > > backends/CMakeLists.txt, line 3 > > <https://git.reviewboard.kde.org/r/126381/diff/7/?file=424946#file424946line3> > > > > Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should

Re: Review Request 126381: kwayland backend for libkscreen

2015-12-24 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/126381/#comment61717> Either this should be guarded by KF5Wayland_FOUND, or KF5Wayland should be marked as required in top CMakeLists.tyt - Hrvoje Senjan On Dec. 22, 2015, 12:46 a.m., Sebastian Kügler wrote: > > -

Re: Review Request 126320: Read KPluginMetada's property X-Plasma-ComponentTypes as a stringlist

2015-12-11 Thread Hrvoje Senjan
panel would be shown). this patch fixes the problem here. - Hrvoje Senjan On Dec. 11, 2015, 7:48 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126275: Make the "Plasma (Wayland)" xsession file actually say "Plasma (Wayland)"

2015-12-08 Thread Hrvoje Senjan
> On Dec. 8, 2015, 7:51 a.m., Martin Gräßlin wrote: > > -2 for another reason: the display system should not be a user facing part. > > That's a technical detail which will go away in a year or two. Do you want > > to rename it back to Plasma then? If at all we should change the X11 > > sessio

Re: Review Request 126248: change icons in breeze plasma theme

2015-12-06 Thread Hrvoje Senjan
> On Dec. 5, 2015, 5:56 p.m., Hrvoje Senjan wrote: > > Andreas, battery is almost invisible with breeze dark -> > > http://i.imgur.com/aY1igIu.jpg > > andreas kainz wrote: > you have right the problem is also the old one from master doesn't work > in

Re: Review Request 126248: change icons in breeze plasma theme

2015-12-05 Thread Hrvoje Senjan
-> http://i.imgur.com/aY1igIu.jpg - Hrvoje Senjan On Dec. 5, 2015, 8:26 a.m., andreas kainz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.k

Re: Review Request 126250: knetattach: Changing host port does not enable connect button

2015-12-05 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126250/#review89150 --- Andrea, did this build for you? - Hrvoje Senjan On Dec. 5

Re: Review Request 126234: Fix build with Qt 5.6

2015-12-04 Thread Hrvoje Senjan
? - Hrvoje Senjan On Dec. 4, 2015, 10:23 a.m., Jan Kundrát wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 126234: Fix build with Qt 5.6

2015-12-03 Thread Hrvoje Senjan
:D - Hrvoje Senjan On Dec. 3, 2015, 6:37 p.m., Jan Kundrát wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.

Re: Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

2015-11-20 Thread Hrvoje Senjan
icult to differentiate minimized from normal window (i.e. not focused)... i know it's a one man opinion but maybe this can be discussed further. - Hrvoje Senjan On Nov. 18, 2015, 11:51 p.m., Gregor Mi wrote: > > --- > This

Re: Review Request 126091: Remove printscreen.khotkeys from KHotkeys package

2015-11-16 Thread Hrvoje Senjan
her don't assume this ;-) at least send a mail to kde-distro-packagers about the sideeffects if those 3 are pushed asynchronously - Hrvoje Senjan On Nov. 16, 2015, 6:06 p.m., Boudhayan Gupta wrote: > > --- > This is an automati

Re: Review Request 125811: detect gtk engine

2015-11-03 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/125811/#comment60331> KDE_INSTALL_FULL_LIBDIR rather? - Hrvoje Senjan On Oct. 27, 2015, 10:22 a.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

2015-10-29 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/125838/#comment60155> you also didn't set the SOVERSION - Hrvoje Senjan On Oct. 29, 2015, 12:12 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

2015-10-28 Thread Hrvoje Senjan
nd will need to link to libksld. but here you skip the symlink? - Hrvoje Senjan On Oct. 28, 2015, 12:07 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.r

Re: Review Request 125706: Install kconf_update script in kdelibs4 directory

2015-10-19 Thread Hrvoje Senjan
t's built that way :D KMIX_KF5_BUILD will enable KF5 codepath/buildsystem. IOW, you need to make sure both cases are covered - Hrvoje Senjan On Oct. 19, 2015, 6:30 p.m., Jonathan Riddell wrote: > > --- > This is an automati

Re: Review Request 125610: use org.kde.kuiserver5 dbus service (instead of org.kde.kuiserver)

2015-10-12 Thread Hrvoje Senjan
interface, so changing the name now won't be easy (or recommended IMO) - Hrvoje Senjan On Oct. 12, 2015, 6:53 p.m., Rex Dieter wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.re

Re: Review Request 125555: Port KAuth return code error checking in fontinst

2015-10-09 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/12/#comment59612> Shouldn't this be if (!j->exec()) { ? - Hrvoje Senjan On Oct. 8, 2015, 3:38 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. T

Re: Review Request 125408: kcm_keyboard: Port away from KDELibs4Support

2015-09-26 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/125408/#comment59350> This still needs KDELibs4Support, whether the include is still needed, haven't checked - Hrvoje Senjan On Sept. 26, 2015, 10:15 p.m., David Rosca wrote: > > --- > This

Re: Review Request 124298: Remove logitech-mouse-related code

2015-07-10 Thread Hrvoje Senjan
marked as submitted. Review request for Plasma, Aleix Pol Gonzalez and Martin Gräßlin. Changes --- Submitted with commit a029fb591ae6ddba5e23c5d5874afa7f2935fbd9 by Hrvoje Senjan to branch master. Repository: plasma-desktop Description --- As was agreed in review 124275. Newest

Re: Review Request 124298: Remove logitech-mouse-related code

2015-07-08 Thread Hrvoje Senjan
------ On July 8, 2015, 7:05 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124298/ >

Review Request 124298: Remove logitech-mouse-related code

2015-07-08 Thread Hrvoje Senjan
f664d kcms/input/logitechmouse.cpp 49364ea kcms/input/mouse.h 177fcda kcms/input/mouse.cpp 195f29f Diff: https://git.reviewboard.kde.org/r/124298/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-08 Thread Hrvoje Senjan
marked as submitted. Review request for Plasma, Aleix Pol Gonzalez, David Edmundson, and Martin Gräßlin. Changes --- Submitted with commit b30ea5a153bd0cc1c8381eda19ecb09abb5d1b5e by Hrvoje Senjan to branch master. Repository: plasma-desktop Description --- Some distros are slowly

Re: Review Request 124275: Allow building kcminput without libusb-compat

2015-07-07 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124275/#review82157 --- On July 6, 2015, 8:41 p.m., Hrvoje Senjan wrote: > >

Review Request 124275: Allow building kcminput without libusb-compat

2015-07-06 Thread Hrvoje Senjan
option, allow cmake to recognize this also. Diffs - kcms/CMakeLists.txt d8a69a3 kcms/input/CMakeLists.txt ee5c9c3 Diff: https://git.reviewboard.kde.org/r/124275/diff/ Testing --- Builds. Thanks, Hrvoje Senjan ___ Plasma-devel mailing

Re: Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix

2015-07-02 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124215/#review81977 --- Ship it! Ship It! - Hrvoje Senjan On July 2, 2015, 1:07

Re: Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix

2015-07-01 Thread Hrvoje Senjan
> On June 30, 2015, 8:21 p.m., Hrvoje Senjan wrote: > > IMO best would be to use pkg-config to query for xkb_base variable... (if > > xkeyboard-config is really needed during buildtime) > > Aleix Pol Gonzalez wrote: > What do we get? > Also ```pkg-config --l

Re: Review Request 124215: Explicitly look for XKB instead of juggling paths in base of a prefix

2015-06-30 Thread Hrvoje Senjan
variable... (if xkeyboard-config is really needed during buildtime) - Hrvoje Senjan On June 30, 2015, 4:53 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewb

Re: Review Request 123621: Fix reverse scroll setting in Mouse KCM

2015-05-15 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/123621/#comment55158> you're missing check for xf86-input-evdev devel files in cmake (i guess some copying of how's done for synaptics could do) - Hrvoje Senjan On May 15, 2015, 6:45 a.m., Yue Liu wrote: > > --

Re: Review Request 123626: port libplasma away from sycoca as much as possible

2015-05-06 Thread Hrvoje Senjan
f a distro would release with $someotherproductversion-1, and update KF5 monthly they would get nice reports about broken desktops - and in principle all non-rolling distros won't deliver new feature releases for desktop and applications. - Hrvoje Senjan On May 6, 2015, 7:21 p.m

[Breeze] [Bug 345209] breeze sddm theme: Kded5 process launched from greeter is not killed after login.

2015-04-09 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=345209 --- Comment #4 from Hrvoje Senjan --- It shows Fully charged - i shall believe it =) -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel

[Breeze] [Bug 345209] breeze sddm theme: Kded5 process launched from greeter is not killed after login.

2015-04-08 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=345209 --- Comment #1 from Hrvoje Senjan --- From the looks of it, 2b1a48742876a5fb548a71e7a6a52717dcb55ada in plasma-framework fixed this one. At least sddm user has now the following processes: sddm 935 0.0 0.1 40912 4840 ?Ss 03:43 0

Re: Review Request 123289: [kde4breze] Fix some KConfig usage (wrt bug 340691)

2015-04-07 Thread Hrvoje Senjan
marked as submitted. Review request for Plasma, David Edmundson and Marco Martin. Changes --- Submitted with commit 7272e6914ef9b756bbbeb132b63a4e39a79f11e9 by Hrvoje Senjan to branch master. Bugs: 342570 https://bugs.kde.org/show_bug.cgi?id=342570 Repository: breeze Description

Re: Review Request 123288: Fix some more KConfig usage (wrt bug 340691)

2015-04-07 Thread Hrvoje Senjan
marked as submitted. Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Changes --- Submitted with commit 1c56fb2195511f4a2e5ff6e94d70dafedb11657e by Hrvoje Senjan to branch master. Repository: plasma-desktop Description --- We only need to sync the changes to

Review Request 123289: [kde4breze] Fix some KConfig usage (wrt bug 340691)

2015-04-07 Thread Hrvoje Senjan
: 342570 https://bugs.kde.org/show_bug.cgi?id=342570 Repository: breeze Description --- We're interested only in local/users kdeglobals in this case. Diffs - misc/kde4breeze/src/main.cpp 361f965 Diff: https://git.reviewboard.kde.org/r/123289/diff/ Testing --- Thanks, H

Review Request 123288: Fix some more KConfig usage (wrt bug 340691)

2015-04-07 Thread Hrvoje Senjan
patch i had both BrowserApplication[$e]=chromium-browser.desktop (local adjustement) BrowserApplication=firefox.desktop (distro branding) in ~/.kde4/share/config/kdeglobals now i have only locally adjusted value Thanks, Hrvoje Senjan ___ Plasma-devel

Re: Review Request 123281: Avoid triggering bug 340691

2015-04-07 Thread Hrvoje Senjan
marked as submitted. Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. Changes --- Submitted with commit b2fc8174d5733fe3b051f839944870b4f51b8c52 by Hrvoje Senjan to branch master. Repository: plasma-desktop Description --- With Kdelibs4Migration we know

Review Request 123281: Avoid triggering bug 340691

2015-04-07 Thread Hrvoje Senjan
/icons.cpp 16a3141 kcms/migrationlib/kdelibs4config.h 0c1b7fe Diff: https://git.reviewboard.kde.org/r/123281/diff/ Testing --- Changed the default browser in systemsettings5, the config got written in both ~/.config/kdeglobals and ~/.kde4/share/config/kdeglobals Thanks, Hrvoje Senjan

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-26 Thread Hrvoje Senjan
> On March 26, 2015, 4:34 p.m., Hrvoje Senjan wrote: > > the library doesn't seem to like boost 1.56: > > > > ``` > > In file included from > > ../lib/kactivities-stats/src/lib/stats/resultset.cpp:425: > > ../lib/kactivities-stats/src/lib/stats/

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-26 Thread Hrvoje Senjan
5/lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp:94:16: error: cannot convert 'const boost::optional' to 'bool' in return [ 232s] return currentValue; [ 232s] ^ ``` - Hrvoje Senjan On March 26, 2015, 2:47 p.m., Ivan Čukić wrote: > >

Re: Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0

2015-03-23 Thread Hrvoje Senjan
marked as submitted. Review request for Plasma, Martin Gräßlin and Jan Grulich. Changes --- Submitted with commit 17a144bc8c210eae0893bac327e836b0d546e215 by Hrvoje Senjan to branch master. Repository: plasma-workspace Description --- Fix build by adding QT_NO_KEYWORDS definition

Re: Review Request 123088: Adding libkactivities-stats to the build

2015-03-21 Thread Hrvoje Senjan
> On March 20, 2015, 10:23 p.m., Marco Martin wrote: > > +1 from here (will read it more) > > Eike Hein wrote: > +1 too, takes the risk out of me shipping code against the experimental > API in 5.3 and breaking Plasma in a KF upgrade > > Ivan Čukić wrote: > Waiting for +2 since +1 +1 =

Re: Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0

2015-03-20 Thread Hrvoje Senjan
55:32: error: expected ‘:’ before ‘;’ token GDBusSignalInfo **signals; ``` With the attached patch it builds fine. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 123091: [plasma-workspace/dataengines/geolocation] Fix build with NM 1.0.0

2015-03-20 Thread Hrvoje Senjan
fine. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 122315: Build kwrited as kded module if kpty was built w/ utempter

2015-03-19 Thread Hrvoje Senjan
marked as submitted. Review request for Plasma. Changes --- Submitted with commit c3cb87a1b580e0805a9f14d89e5a176d56862c6e by Hrvoje Senjan to branch master. Repository: kwrited Description --- this was the case in all(most?) of kde4 timeline, but with the KF5 port kpty didn&#

Re: Review Request 122919: Remove unused dependencies.

2015-03-13 Thread Hrvoje Senjan
919/#comment53173> you where almost right in rev1 of the patch ;-) this line would welcome e.g. set(HAVE_XFIXES TRUE) othewise the ifdefs are never compiled. whether you want to fix this in this review is up to you - Hrvoje Senjan On March 13, 2015, 6 p.m., Michael Palimaka

Re: Review Request 122919: Remove unused dependencies.

2015-03-13 Thread Hrvoje Senjan
&major, &minor); src/cursortheme/cursortheme.h:102:static bool haveXfixes(); src/cursortheme/cursortheme.h:119:// Convenience function that uses Xfixes to tag a cursor with a name - Hrvoje Senjan On March 12, 2015, 4:30 p.m.,

Re: Review Request 122886: QML-only KCM base

2015-03-11 Thread Hrvoje Senjan
tps://git.reviewboard.kde.org/r/122886/#comment53094> you need also KF5::Auth as public, the new public header has a kauthaction include - Hrvoje Senjan On March 10, 2015, 12:28 p.m., Marco Martin wrote: > > --- > This is an automatically gener

Re: Review Request 122733: Fix path traversal checks in KPackage

2015-03-04 Thread Hrvoje Senjan
ds of Attempting to read file from invalid package! file type: "metadata" file name: "" package path: "/usr/share/wallpapers/Aghi/" ... warnings... - Hrvoje Senjan On March 3, 2015, 6:53 p.m., Alex Richardson wrote: > > ---

Re: Review Request 122810: Adjust kdeclarative public deps

2015-03-04 Thread Hrvoje Senjan
Diffs - KF5DeclarativeConfig.cmake.in 2250239 src/kdeclarative/CMakeLists.txt f99a374 Diff: https://git.reviewboard.kde.org/r/122810/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/lis

Review Request 122810: Adjust kdeclarative public deps

2015-03-04 Thread Hrvoje Senjan
https://git.reviewboard.kde.org/r/122810/diff/ Testing --- Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[ksysguard] [Bug 344612] libksysguard from Plasma 5.2 conflicts with libksysguard from kde-workspace

2015-02-27 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=344612 Hrvoje Senjan changed: What|Removed |Added CC||hrvoje.sen...@gmail.com --- Comment #13 from

Re: Review Request 122726: Make touchpad KCM optional depending on whether we find synaptics

2015-02-26 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122726/#review76650 --- find_package(KDED REQUIRED) is also missing... - Hrvoje

[kio-extras] [Bug 343634] Web Shortcuts segfault

2015-02-01 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=343634 Hrvoje Senjan changed: What|Removed |Added CC||hrvoje.sen...@gmail.com Status

Re: Review Request 122315: Build kwrited as kded module if kpty was built w/ utempter

2015-01-29 Thread Hrvoje Senjan
o reply, visit: https://git.reviewboard.kde.org/r/122315/#review75000 --- On Jan. 29, 2015, 8:48 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated

Review Request 122315: Build kwrited as kded module if kpty was built w/ utempter

2015-01-29 Thread Hrvoje Senjan
--- this was the case in all(most?) of kde4 timeline, but with the KF5 port kpty didn't expose utempter presence Diffs - CMakeLists.txt 8c29e1b Diff: https://git.reviewboard.kde.org/r/122315/diff/ Testing --- working Thanks, Hrvoje S

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-29 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #60 from Hrvoje Senjan --- kded5 bt w/ Davids patch: #0 0x7f505a91685f in pthread_cond_wait@@GLIBC_2.3.2 () at /lib64/libpthread.so.0 #1 0x7f505b89796b in QWaitCondition::wait(QMutex*, unsigned long) (time

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-29 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #58 from Hrvoje Senjan --- from short testing the patch seems to resolves the CPU problem. however: 1) for locking the screen, it now takes some 30s to actually show the locker, 2) konsole action (right click) is blocked with: 0

Re: Review Request 121563: Fix build with Qt 5.5/dev branch in release mode

2015-01-19 Thread Hrvoje Senjan
is to guard the Q_ASSERT with QT_NO_DEBUG" Diffs - processcore/processes.cpp 6c0effc Diff: https://git.reviewboard.kde.org/r/121563/diff/ Testing --- builds with both 5.4 & dev branch Thanks, Hrvoje Senjan ___ Plasma-devel m

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-18 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #44 from Hrvoje Senjan --- i've just tried kdm, and managed to reproduce the issue still... it's essential that the helper, and not XRandBrightness is used. also, i've tried locally to revert the logic in powerdevil (switc

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-18 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #42 from Hrvoje Senjan --- i'm also having two kded5 processes, user's and sddm's. however, only users goes wild. -- You are receiving this mail because: You are the assig

Re: Review Request 121563: Fix build with Qt 5.5/dev branch in release mode

2015-01-17 Thread Hrvoje Senjan
e Q_ASSERT with QT_NO_DEBUG" Diffs (updated) - processcore/processes.cpp 6c0effc Diff: https://git.reviewboard.kde.org/r/121563/diff/ Testing --- builds with both 5.4 & dev branch Thanks, Hrvoje Senjan ___ Plasma-devel mailing l

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-15 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #33 from Hrvoje Senjan --- nope, it is the same process -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https

[Powerdevil] [Bug 340892] System Settings's Power management complains about power management service

2015-01-14 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=340892 Hrvoje Senjan changed: What|Removed |Added CC||hrvoje.sen...@gmail.com --- Comment #5 from

[Powerdevil] [Bug 337674] kded5 is eating CPU

2015-01-12 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=337674 --- Comment #30 from Hrvoje Senjan --- Created attachment 90381 --> https://bugs.kde.org/attachment.cgi?id=90381&action=edit sligthly more debug i am also getting the CPU murdering after recent changes to powerdevil dataengine & powerd

[Breeze] [Bug 342570] New: kde4breeze copies contents of systemwide kdeglobals

2015-01-06 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=342570 Bug ID: 342570 Summary: kde4breeze copies contents of systemwide kdeglobals Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Se

[Breeze] [Bug 342420] New: Provide default wallpaper in png format

2015-01-02 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=342420 Bug ID: 342420 Summary: Provide default wallpaper in png format Product: Breeze Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: grav

Review Request 121563: Fix build with Qt 5.5/dev branch in release mode

2014-12-16 Thread Hrvoje Senjan
c0effc Diff: https://git.reviewboard.kde.org/r/121563/diff/ Testing --- builds with both 5.4 & dev branch Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

[Powerdevil] [Bug 341775] New: Powerdevil kded triggers kded5 loop

2014-12-11 Thread Hrvoje Senjan
https://bugs.kde.org/show_bug.cgi?id=341775 Bug ID: 341775 Summary: Powerdevil kded triggers kded5 loop Product: Powerdevil Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED Severity: grav

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-07 Thread Hrvoje Senjan
> On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update y

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-07 Thread Hrvoje Senjan
> On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update y

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Hrvoje Senjan
> On Dec. 6, 2014, 12:39 a.m., Hrvoje Senjan wrote: > > i've lost brightness control in battery monitor after this change. > > brightnessValueMax returns 9, but Screen Brightness Available is false > > anyway > > Kai Uwe Broulik wrote: > Please update y

Re: Review Request 121355: Expose actual and maximum brightness value in dataengine

2014-12-05 Thread Hrvoje Senjan
this change. brightnessValueMax returns 9, but Screen Brightness Available is false anyway - Hrvoje Senjan On Dec. 5, 2014, 10:06 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 121259: [oxygen] fix kde4 build/configure/cmake stage

2014-11-26 Thread Hrvoje Senjan
cceed Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 121259: [oxygen] fix kde4 build/configure/cmake stage

2014-11-26 Thread Hrvoje Senjan
Description --- it's used unconditionally since r121083 Diffs - CMakeLists.txt b7cfc8e Diff: https://git.reviewboard.kde.org/r/121259/diff/ Testing --- KF5 and kde4 builds succeed Thanks, Hrvoje Senjan ___ Plasma-devel ma

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

2014-11-12 Thread Hrvoje Senjan
cpp 5a6096f Diff: https://git.reviewboard.kde.org/r/120876/diff/ Testing --- builds, succesfully reported bug via patched DrKonqi, wasn't able to do so before. Thanks, Hrvoje Senjan ___ Plasma-devel mailing list Plasma-devel@kde.o

Re: Review Request 120876: Forward-port "Fix and future-proof Dr Konqi security methods on Bugzilla" from kde-runtime

2014-11-12 Thread Hrvoje Senjan
> On Nov. 11, 2014, 11:43 p.m., Hrvoje Senjan wrote: > > 5.1.1 out. should 5(.1.x) be targeted at all? > > Thomas Lübking wrote: > As this is now a straightforward port of what there is in KDE SC 4 and > DrKonqui is atm. useless and crashreports for KF/5 currently

  1   2   3   >