----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122919/#review77434 -----------------------------------------------------------
src/CMakeLists.txt <https://git.reviewboard.kde.org/r/122919/#comment53173> you where almost right in rev1 of the patch ;-) this line would welcome e.g. set(HAVE_XFIXES TRUE) othewise the ifdefs are never compiled. whether you want to fix this in this review is up to you - Hrvoje Senjan On March 13, 2015, 6 p.m., Michael Palimaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122919/ > ----------------------------------------------------------- > > (Updated March 13, 2015, 6 p.m.) > > > Review request for Plasma. > > > Repository: sddm-kcm > > > Description > ------- > > I can't find any reference to these dependencies, so remove them. > > > Diffs > ----- > > CMakeLists.txt 79c1faff6087575296d49c3926732c92c391eccc > src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c > > Diff: https://git.reviewboard.kde.org/r/122919/diff/ > > > Testing > ------- > > Inspected source. Builds. No library links to the affected dependencies > before and after the change. > > > Thanks, > > Michael Palimaka > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
