> On May 13, 2016, 8:59 p.m., David Faure wrote: > > kcms/componentchooser/componentchooserbrowser.cpp, line 86 > > <https://git.reviewboard.kde.org/r/123288/diff/1/?file=360453#file360453line86> > > > > This change makes it impossible for me to choose another browser than > > firefox on OpenSuSE, where /etc/xdg/kdeglobals says > > BrowserApplication=firefox. > > > > (comment added in https://bugs.kde.org/show_bug.cgi?id=340691#c9) > > > > SimpleConfig means that upon saving, kconfig doesn't know it has to > > write > > BrowserApplication[$d] > > It does when I remove SimpleConfig, which fixes the bug for me. > > > > This seems pretty logical to me, so this fix is clearly wrong. If > > something has to be fixed around some "copyTo" that the bug mentions, then > > it has to be fixed differently.
Indeed. Though once you remove the SimpleConfig, the bug will be exposed again for kde4 kdeglobals. I.e. &config will point to both KF5 kdeglobals. - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123288/#review95455 ----------------------------------------------------------- On April 7, 2015, 8:50 p.m., Hrvoje Senjan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123288/ > ----------------------------------------------------------- > > (Updated April 7, 2015, 8:50 p.m.) > > > Review request for Plasma, David Edmundson, Eike Hein, and Marco Martin. > > > Repository: plasma-desktop > > > Description > ------- > > We only need to sync the changes to kde4 kdeglobals once users changes the > defaults, hence only users KF5 kdeglobals need to be evaluated. > This workarounds (though the change is IMO correct anyway) the kconfig bug, > as we can otherwise pass both local and systemwide kdeglobals into copyTo > method. > > > Diffs > ----- > > kcms/componentchooser/componentchooserbrowser.cpp f2b81ef > kcms/componentchooser/componentchooserterminal.cpp be52334 > kcms/input/mouse.cpp 69759bd > > Diff: https://git.reviewboard.kde.org/r/123288/diff/ > > > Testing > ------- > > W/o the patch i had both > BrowserApplication[$e]=chromium-browser.desktop (local adjustement) > BrowserApplication=firefox.desktop (distro branding) > > in ~/.kde4/share/config/kdeglobals > now i have only locally adjusted value > > > Thanks, > > Hrvoje Senjan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
