Re: Review Request 105779: plasma calendar - order events and todos by start date

2015-08-31 Thread Greg T
clock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: https://git.reviewboard.kde.org/r/105779/diff/ Testing --- works for me Thanks, Greg T ___ Plasma-devel mailing list P

Re: Review Request 111087: widget-taskbar: vertical text layout

2014-07-29 Thread Greg T
sktop/applets/tasks/support/textlabel.cpp 9fbc12d621c2917665fb963c0087f3a59c9e86e9 Diff: https://git.reviewboard.kde.org/r/111087/diff/ Testing --- File Attachments https://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/taskbar_nocut.png Thanks, G

Re: Review Request 106448: replace old kickoff with kickoff-qml

2014-07-29 Thread Greg T
t.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 105924: plasma calendar - event system config option

2014-07-29 Thread Greg T
ger.cpp 45c15a9 Diff: https://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 111087: widget-taskbar: vertical text layout

2013-06-18 Thread Greg T
http://git.reviewboard.kde.org/r/111087/diff/ Testing --- File Attachments http://git.reviewboard.kde.org/media/uploaded/files/2013/06/18/taskbar_nocut.png Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kd

Re: Review Request 109124: qml port currentappcontrol

2013-02-28 Thread Greg T
; > > - the close/restore buttons don't glow on hover. I couldn't load a theme > > svg using the IconItem. Is that possible? > > > > you can load an icon file from the svg theme and specify the element to > > use, e.g.: "source: svgname-elementname&q

Re: Review Request 109124: qml port currentappcontrol

2013-02-28 Thread Greg T
compactRepresentation of currentappcontrol shouldn't take the whole panel width - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109124/#review28133 ---

Re: Review Request 109124: qml port currentappcontrol

2013-02-25 Thread Greg T
a/netbook/applets/currentappcontrol/package/contents/ui/Task.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/contents/ui/main.qml PRE-CREATION plasma/netbook/applets/currentappcontrol/package/metadata.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109124/diff

Re: Review Request 109124: qml port currentappcontrol

2013-02-24 Thread Greg T
----- On Feb. 24, 2013, 11:10 a.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109124/ >

Review Request 109124: qml port currentappcontrol

2013-02-24 Thread Greg T
Task.qml PRE-CREATION Diff: http://git.reviewboard.kde.org/r/109124/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 106448: replace old kickoff with kickoff-qml

2013-02-09 Thread Greg T
> On Feb. 8, 2013, 10:16 p.m., Albert Astals Cid wrote: > > What is the status of this? Are you guys still working on it? Needs > > improvements? Can be commited? Should be discarded? It's been 3 months > > without activity! > > Greg T wrote: > nope, t

Re: Review Request 106448: replace old kickoff with kickoff-qml

2013-02-09 Thread Greg T
viewboard.kde.org/r/106448/#review27017 --- On Oct. 21, 2012, 10:23 a.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request: plasmoid currentappconrol - max width of dropdown

2012-11-23 Thread Greg T
plets/currentappcontrol/currentappcontrol.cpp 5c2e73f9d6b8207efd3a3de6464278d1bdbc9263 Diff: http://git.reviewboard.kde.org/r/107433/diff/ Testing --- Screenshots --- dropdown http://git.reviewboard.kde.org/r/107433/s/850/ Thanks, Greg T ___ P

Review Request: plasmoid currentappconrol - max width of dropdown

2012-11-23 Thread Greg T
l.cpp 5c2e73f9d6b8207efd3a3de6464278d1bdbc9263 Diff: http://git.reviewboard.kde.org/r/107433/diff/ Testing --- Screenshots --- dropdown http://git.reviewboard.kde.org/r/107433/s/850/ Thanks, Greg T ___ Plasma-devel mailing list Plasma-

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
gi?id=302111 > http://bugs.kde.org/show_bug.cgi?id=302160 > > > Diffs > - > > powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp > 3d0926fab8dac334d56d5cce430691e501b6f8c7 > > Diff: http://git.reviewboard.kde.org/r/107398/diff/ > &g

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
d.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 Diff: http://git.reviewboard.kde.org/r/107398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
d.cpp 3d0926fab8dac334d56d5cce430691e501b6f8c7 Diff: http://git.reviewboard.kde.org/r/107398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kd

Review Request: powerdevil dbus interface - screenBrightnessChanged Signal

2012-11-21 Thread Greg T
07398/diff/ Testing --- works on my laptop when I set the screen brightness with the batterymonitor plasmoid Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Kickoff-qml fixes

2012-11-03 Thread Greg T
x27;t fade too - Greg T On Oct. 24, 2012, 6:20 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.review

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-21 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review20586 ------- On Oct. 21, 2012, 10:23 a.m., Greg T wrote: > > --- &

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-21 Thread Greg T
rd.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-20 Thread Greg T
rd.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: make kickoff-qml partly c++, restores simpleapplet, applet type switch

2012-10-19 Thread Greg T
desktop files for the kickoff launcher: - metadata.desktop and the old plasma-applet-launcher.desktop - we don't need CMakeLists.txt in core/ anymore? - also it conflicts with my last commit in kickoff-qml (just a minor in kickoff.qml) - Greg T On Oct. 19, 2012, 1:04 p.m., Marco Martin

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-18 Thread Greg T
://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-15 Thread Greg T
usability issue) - Greg T On Oct. 14, 2012, 7:47 p.m., Richard Stockton wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-14 Thread Greg T
> On Oct. 13, 2012, 5:43 p.m., Greg T wrote: > > I'm quite satisfied with the keyboard handling after applying your patch. > > > > some notes: > > - when I press key up/down at the top/bottom of a flippscroll view, the > > launcher jumps back to the favou

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-13 Thread Greg T
ewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Fix regression (keyboard usage) introduced in Kickoff-Widget 4.9.2

2012-10-13 Thread Greg T
sktop/applets/kickoff/ui/flipscrollview.cpp <http://git.reviewboard.kde.org/r/106789/#comment16031> this is already handled in moveCursor, isn't it? plasma/desktop/applets/kickoff/ui/launcher.cpp <http://git.reviewboard.kde.org/r/106789/#comment16030> Why did you spl

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-11 Thread Greg T
asma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-06 Thread Greg T
> On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: > > any updates on this? > > what are the major blocker still remaining for a merge? > > Greg T wrote: > well, to summarize it: > - classic menu broken > - some minor functionality missing &

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-05 Thread Greg T
> On Oct. 5, 2012, 9:37 a.m., Marco Martin wrote: > > any updates on this? > > what are the major blocker still remaining for a merge? > > Greg T wrote: > well, to summarize it: > - classic menu broken > - some minor functionality missing &

Review Request: plasma-desktop: restore toolbox position

2012-10-05 Thread Greg T
b62370e8a428087bb7671b60632e8fe458d1ee67 Diff: http://git.reviewboard.kde.org/r/106743/diff/ Testing --- no issues noted Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: replace old kickoff with kickoff-qml

2012-10-05 Thread Greg T
nts also post-review. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review19954 --- On Sept. 20, 2012, 4:1

Review Request: plasma-netbook: add a settings action to the panel

2012-10-04 Thread Greg T
nel.h 970bf3c0e60915f49dc7318a9789bf9cd0830b59 plasma/netbook/containments/netpanel/panel.cpp a53eb5f642b5102719bf11329b1a5c5be1c13c99 plasma/netbook/shell/plasmaapp.cpp 22c54b2ba9e746e85eb7c581ebee26e3ba63b459 Diff: http://git.reviewboard.kde.org/r/106723/diff/ Testing --- Thanks, G

Re: Review Request: Use Product instead of description for device names

2012-09-29 Thread Greg T
we handle this case somewhere in the model? - Greg T On Sept. 29, 2012, 8:21 p.m., Alex Fiestas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: replace old kickoff with kickoff-qml

2012-09-20 Thread Greg T
TION plasma/generic/dataengines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can star

Re: Review Request: replace old kickoff with kickoff-qml

2012-09-15 Thread Greg T
ngines/packagekit/plasma-dataengine-packagekit.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T __

Re: Review Request: replace old kickoff with kickoff-qml

2012-09-15 Thread Greg T
7;m just using contextMenu from plasmacomponents. The trick is to call menu.open(x, y) with the right coordinates. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106448/#review1

Review Request: replace old kickoff with kickoff-qml

2012-09-14 Thread Greg T
N plasma/desktop/applets/kickoff/package/metadata.desktop PRE-CREATION Diff: http://git.reviewboard.kde.org/r/106448/diff/ Testing --- not too much, surely have to update this diff a couple of times. But you can start dropping comments anyway. Thanks, Greg T _

Re: Review Request: declarative plasmoid object, containment access

2012-09-07 Thread Greg T
g. could it be done using a > > Plasma::Service which does the right thing for the given shell? > > > > also, i don't think missing this feature should stand in the way of the QML > > version replacing the C++ version in master. we need to get this merged as > > soon

Re: Review Request: declarative plasmoid object, containment access

2012-09-07 Thread Greg T
smoid/appletinterface.cpp 75dc2f0 Diff: http://git.reviewboard.kde.org/r/106365/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: declarative plasmoid object, containment access

2012-09-07 Thread Greg T
anch into master before. Can you give me some hints how to do that? It's quite a bunch of code. Actually mgraesslin created this widget, so maybe we should ask him for his opinion... - Greg --- This is an automa

Review Request: declarative plasmoid object, containment access

2012-09-07 Thread Greg T
sting --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-09-01 Thread Greg T
> On Aug. 31, 2012, 7:49 a.m., Albert Astals Cid wrote: > > This has been commited late for 4.9.1 tagging (6 hours late) and without a > > shipit from anyone in the reviewboard, so I'm not that eager to redo the > > tarballs. Can anyone convince me otherwise? (You have 6 hours for that) whoops

Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)

2012-08-27 Thread Greg T
> On Aug. 26, 2012, 7:50 a.m., Greg T wrote: > > besides the points mentioned in review 106125, you have to remember that > > KDE 4.8 is already EOL and there will be no more bugfix release (i.e. > > 4.8.6). > > Richard Stockton wrote: > Yes, but I was aske

Review Request: plasmoid digital-clock - layout bug in small vertical panels

2012-08-26 Thread Greg T
http://bugs.kde.org/show_bug.cgi?id=252291 Diffs - plasma/generic/applets/digital-clock/clock.h f4822ec plasma/generic/applets/digital-clock/clock.cpp 1331776 Diff: http://git.reviewboard.kde.org/r/106223/diff/ Testing --- issue fixed, using long date. Thanks, G

Re: Review Request: Kickoff-Widget: Add Key_Tab support for navigation from search Bar (4.8)

2012-08-26 Thread Greg T
remember that KDE 4.8 is already EOL and there will be no more bugfix release (i.e. 4.8.6). - Greg T On Aug. 22, 2012, 9:06 p.m., Richard Stockton wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-26 Thread Greg T
> On Aug. 23, 2012, 2:53 p.m., Greg T wrote: > > I think this time we can get kickoff-qml into kde 4.10. But this is no > > reason to push this fix not into master :) > > Richard Stockton wrote: > Thanks, Greg! I think we both plan this method for managing the two

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-26 Thread Greg T
If I understand the reporter correctly, he wants to move with Up/Down keys in the search view as soon as he enters a search query. With your patch applied I still have to hit the tab key first. Can you set the focus automatically on the view? - Greg T On Aug. 23, 2012, 12:28 a.m., Richard Stockton

Re: Review Request: Usability: Add keyboard navigation to Kickoff GUI (within and among all Views)

2012-08-23 Thread Greg T
this is no reason to push this fix not into master :) - Greg T On Aug. 23, 2012, 12:28 a.m., Richard Stockton wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.

Re: Review Request: digital clock widget - popup focus

2012-08-20 Thread Greg T
gi?id=221301 Diffs - plasma/generic/applets/digital-clock/clock.cpp 1331776 Diff: http://git.reviewboard.kde.org/r/105933/diff/ Testing ------- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: plasma calendar - event system config option

2012-08-08 Thread Greg T
ose. What dou you think? That unrelated code is from https://git.reviewboard.kde.org/r/105779/ feel free to review it :) - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.k

Re: Review Request: plasma calendar - event system config option

2012-08-08 Thread Greg T
ibs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105924/diff/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: plasma calendar - disable event system config

2012-08-08 Thread Greg T
show_bug.cgi?id=281464 Diffs - libs/plasmaclock/calendar.cpp 75bfc31 libs/plasmaclock/calendartable.h 8678593 libs/plasmaclock/calendartable.cpp d2b436e libs/taskmanager/groupmanager.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105924/diff/ Testing ---

Review Request: plasma calendar - order events and todos by start date

2012-07-29 Thread Greg T
r.cpp 45c15a9 Diff: http://git.reviewboard.kde.org/r/105779/diff/ Testing --- works for me Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: add keyboard nav to konsoleprofiles widget

2012-07-28 Thread Greg T
re referring to. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105765/#review16571 --- On July 28, 2012

Re: Review Request: Make sure kmenuedit use predictable order for showing "Name" and "Description" between various invocations

2012-07-28 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105769/#review16574 --- Ship it! Ship It! - Greg T On July 28, 2012, 1:11 p.m

Review Request: add keyboard nav to konsoleprofiles widget

2012-07-28 Thread Greg T
://git.reviewboard.kde.org/r/105765/diff/ Testing --- tested in a panel Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: kickoff-qml: TabBar button width

2012-07-20 Thread Greg T
> On July 19, 2012, 9:04 a.m., Marco Martin wrote: > > thanks, wouldn;t have remembered ;) > > > > the changes seems good, but i'm not sure about giving kickoff a copy of the > > tabbar. > > > > any reason this is not proposed as a patch for th

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Greg T
p://git.reviewboard.kde.org/r/105405/#review16103 --- On July 1, 2012, 8:42 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request: kickoff-qml: TabBar button width

2012-07-19 Thread Greg T
n automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105405/#review15332 --- On July 1, 2012, 8:42 p.m., Greg T wrote: > > --- > This is an automatica

Re: Review Request: fixed duplication of timezone displayed at tooltip

2012-07-15 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105550/#review15874 --- Ship it! Ship It! - Greg T On July 13, 2012, 11:52 a.m

Re: Review Request: Fix the wrong usage of "Keywords" in one .dekstop file

2012-07-14 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review15869 --- Ship it! Ship It! - Greg T On July 13, 2012, 2:49 p.m

Re: Review Request: Fix the wrong usage of "Keywords" in one .dekstop file

2012-07-14 Thread Greg T
yword entrys? - Greg T On July 13, 2012, 2:49 p.m., Jekyll Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard

Re: Review Request: change default config of taskmanager

2012-07-08 Thread Greg T
kspace from master or some older branch or...? > > Greg T wrote: > ah, I see. > > Nope, I'm using plain master and that bug is definitely *not* fixed. The > preferred filemanager and browser icons keep reappaering on login. The > function GroupManagerPriva

Re: Review Request: added minimum size to 'show activities' plasmoid at desktop

2012-07-07 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105473/#review15533 --- Ship it! Ship It! - Greg T On July 7, 2012, 2:11 p.m

Re: Review Request: fixed widget explorer or activity manager not closed when clicking desktop area above panel

2012-07-02 Thread Greg T
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105340/#review15316 --- Ship it! Ship It! - Greg T On June 29, 2012, 11:38 a.m

Review Request: kickoff-qml: TabBar button width

2012-07-01 Thread Greg T
/ Testing --- Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Plasma qml-Components ToolButton: change text-color on hover more fluently

2012-06-28 Thread Greg T
> On June 28, 2012, 4:58 p.m., Aaron J. Seigo wrote: > > Ship It! > > Johannes Tröscher wrote: > i'm not that experienced with git.. i've pushed it to master, could you > backport it to 4.9? i don't know how to push single commits I suggest you to use 'git cherry-pick' for that task. - G

Re: Review Request: change default config of taskmanager

2012-06-28 Thread Greg T
he first place. That's why I'm opening this review request. This addresses bug 278724. http://bugs.kde.org/show_bug.cgi?id=278724 Diffs (updated) - libs/taskmanager/groupmanager.cpp 5ca0159 Diff: http://git.reviewboard.kde.org/r/105374/diff/ Testing ---

Re: Review Request: change default config of taskmanager

2012-06-28 Thread Greg T
e the name of the launcher is i.e. 'firefox' but never 'browser' - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105374/#review15230 ----

Review Request: change default config of taskmanager

2012-06-28 Thread Greg T
g.cgi?id=278724 Diffs - plasma/desktop/shell/data/layouts/org.kde.plasma-desktop.defaultPanel/contents/layout.js afd1f2c Diff: http://git.reviewboard.kde.org/r/105374/diff/ Testing --- no regressions noted. Thanks, Greg T ___ Plasma

Re: Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)

2012-06-18 Thread Greg T
vigation should be fine. You are welcome to test and review it. - Greg --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105196/#review14571 -----

Review Request: improve/add keyboard navigation in kickoff-qml (mystery included)

2012-06-09 Thread Greg T
sktop/applets/kickoff/package/contents/ui/kickoff.qml 4a9a5e6 Diff: http://git.reviewboard.kde.org/r/105196/diff/ Testing --- kinda works Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: Bug Marble globe wallpaper, reversed spin direction

2012-05-31 Thread Greg T
------- On May 31, 2012, 12:52 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105118/ > --

Review Request: Bug Marble globe wallpaper, reversed spin direction

2012-05-31 Thread Greg T
--- bug fixed. Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Greg T
;) Thanks for your input, guys! "It (probably) can't be closed by pressing CTRL+Q" I'am able to close the activity manager by pressing alt+f4, or what are you talking about? ctrl+q doesn't even work with the old version. - Greg -

Re: Review Request: qml port of showActivityManager (it's just an icon)

2012-05-21 Thread Greg T
r vanishes! Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: qml port of showActivityManager (it's just an icon)

2012-05-15 Thread Greg T
activities/activities.operations f9ce034 plasma/generic/dataengines/activities/activityjob.cpp 7fe8823 Diff: http://git.reviewboard.kde.org/r/104959/diff/ Testing --- click: activity manager comes up click again: manager vanishes! Thank

Review Request: Icon applet - Recognition of desktop files without .desktop extension

2012-04-27 Thread Greg T
he file suffix. This addresses bug 266870. http://bugs.kde.org/show_bug.cgi?id=266870 Diffs - plasma/generic/applets/icon/icon.cpp 4bdbae4 Diff: http://git.reviewboard.kde.org/r/104764/diff/ Testing --- bug fixed Thanks, Greg T _

Re: Review Request: plasmoid qalculate - menu button

2012-03-06 Thread Greg T
--- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: plasmoid qalculate - menu button

2012-03-03 Thread Greg T
/qalculate_settings.cpp b62145b Diff: http://git.reviewboard.kde.org/r/103052/diff/ Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: plasmoid qalculate - menu button

2012-02-29 Thread Greg T
plets/qalculate/qalculate_settings.h 4ce4e73 applets/qalculate/qalculate_settings.cpp b62145b Diff: http://git.reviewboard.kde.org/r/103052/diff/ Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request: icon plasmoid - http url naming

2012-01-10 Thread Greg T
http://bugs.kde.org/show_bug.cgi?id=199811 Diffs - plasma/generic/applets/icon/icon.cpp b25e5d6 Diff: http://git.reviewboard.kde.org/r/103435/diff/diff Testing --- looks good Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org

Review Request: plasmoid web slice - disable geometryEdit if not needed

2011-12-19 Thread Greg T
Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: icon plasmoid - http url naming

2011-12-16 Thread Greg T
: http://git.reviewboard.kde.org/r/103435/diff/diff Testing --- looks good Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: plasmoid qalculate - menu button

2011-12-14 Thread Greg T
4ce4e73 applets/qalculate/qalculate_settings.cpp b62145b Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Re: Review Request: plasmoid qalculate - menu button

2011-12-10 Thread Greg T
-- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8821 --- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > htt

Re: Review Request: plasmoid qalculate - menu button

2011-12-08 Thread Greg T
generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103052/#review8754 ------- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: plasmoid qalculate - menu button

2011-12-08 Thread Greg T
eviewboard.kde.org/r/103052/#review8754 ------- On Dec. 8, 2011, 8:48 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request: plasmoid qalculate - menu button

2011-12-08 Thread Greg T
applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T

Re: Review Request: plasmoid folderview - context menu empty trash bin

2011-12-03 Thread Greg T
is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103282/#review8689 --- On Nov. 28, 2011, 3:52 p.m., Greg T wrote: > > --- > This is an a

Review Request: plasmoid folderview - context menu empty trash bin

2011-11-28 Thread Greg T
, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: kickoff breadcrumb cursor

2011-11-16 Thread Greg T
very nice Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: kickoff breadcrumb cursor

2011-11-16 Thread Greg T
a2acb35 Diff: http://git.reviewboard.kde.org/r/103159/diff/diff Testing --- works very nice Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: plasmoid qalculate - menu button

2011-11-11 Thread Greg T
applets/qalculate/qalculate_applet.cpp 4da9241 applets/qalculate/qalculate_history.h 59185ee applets/qalculate/qalculate_history.cpp 35592a7 Diff: http://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T

Review Request: plasmoid qalculate - menu button

2011-11-05 Thread Greg T
://git.reviewboard.kde.org/r/103052/diff/diff Testing --- seems to work Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: plasma widget qalculate - PluginInfo-Website

2011-11-03 Thread Greg T
. 3, 2011, 12:24 p.m., Greg T wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103037/ > --- &g

Review Request: plasma widget qalculate - PluginInfo-Website

2011-11-03 Thread Greg T
widget qalculate - PluginInfo-Website Description (updated) --- The old link was inaccurate. Diffs (updated) - applets/qalculate/plasma-applet-qalculate.desktop 580c898 Diff: http://git.reviewboard.kde.org/r/103037/diff/diff Testing --- Thanks, Greg T

Review Request: picture frame widget - move to next picture on delete

2011-10-30 Thread Greg T
applets/frame/picture.cpp 57d82ed applets/frame/slideshow.cpp a461244 Diff: http://git.reviewboard.kde.org/r/103001/diff/diff Testing --- it compiles Thanks, Greg T ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

  1   2   >