> On May 31, 2012, 1:08 p.m., Dennis Nienhüser wrote: > > Polarity determines whether north is visible top or bottom, so I don't know > > why the original code was there. > > > > I think you can even strip it down further to a simple > > qreal const direction = polarity < 0 ? -1 : 1; > > > > i.e. ignore the projection -- in non-spherical case polarity is 1. > > > > Note that your patch also fixes bug 216156. You could use > > zoomIn()/zoomOut() though instead of the hard-coded +/- 40.
Thanks for clarification. I could not find zoomIn/Out in MarbleMap. Unfortunately this plasma wallpaper doesn't use MarbleWidget. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105118/#review14296 ----------------------------------------------------------- On May 31, 2012, 12:52 p.m., Greg T wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105118/ > ----------------------------------------------------------- > > (Updated May 31, 2012, 12:52 p.m.) > > > Review request for Marble and Plasma. > > > Description > ------- > > I had to delete a bunch of code to fix the issue. But what was the purpose of > this code? Am I missing some cornercase? > > > This addresses bug 264755. > http://bugs.kde.org/show_bug.cgi?id=264755 > > > Diffs > ----- > > wallpapers/marble/marble.cpp 988a8b6 > > Diff: http://git.reviewboard.kde.org/r/105118/diff/ > > > Testing > ------- > > bug fixed. > > > Thanks, > > Greg T > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
